{"id":24849,"url":"https://patchwork.libcamera.org/api/1.1/patches/24849/?format=json","web_url":"https://patchwork.libcamera.org/patch/24849/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251028093720.383810-1-barnabas.pocze@ideasonboard.com>","date":"2025-10-28T09:37:20","name":"[RFC,v3] libipa: camera_sensor_helper: Add imx708","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9940f74bdf64398f5e630653951d292510d2def4","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24849/mbox/","series":[{"id":5537,"url":"https://patchwork.libcamera.org/api/1.1/series/5537/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5537","date":"2025-10-28T09:37:20","name":"[RFC,v3] libipa: camera_sensor_helper: Add imx708","version":3,"mbox":"https://patchwork.libcamera.org/series/5537/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24849/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24849/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76492C3259\n\tfor ;\n\tTue, 28 Oct 2025 09:37:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4B93607B2;\n\tTue, 28 Oct 2025 10:37:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11CA7603ED\n\tfor ;\n\tTue, 28 Oct 2025 10:37:24 +0100 (CET)","from pb-laptop.local (185.182.215.162.nat.pool.zt.hu\n\t[185.182.215.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71989176B;\n\tTue, 28 Oct 2025 10:35:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W1BEFM97\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761644135;\n\tbh=jDWLzRqTB9z4f1yDCiUK7djK7oIQCXp2GG6ZerHzVTk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=W1BEFM97wNN8PL+SAVDtt5cuUnp3627mzZM/oFhM9nFPAh9UjbIobZfNK9bOP/mP9\n\tyw/uf97kmFFgamTiQj5cB8FLtfEok5HXOGyY+1LWlpGZYs8fXz9EIrhVOQvOYyiXYy\n\te1QLzKHfAfx9+BZFUhCutefHm1j7XDX0/zbRUIjE=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tKieran Bingham ","Subject":"[RFC PATCH v3] libipa: camera_sensor_helper: Add imx708","Date":"Tue, 28 Oct 2025 10:37:20 +0100","Message-ID":"<20251028093720.383810-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Daniel Scally \n\nThe imx708 sensor driver has long been available, especially in raspberry\npi kernels; and the raspberry pi ipa module has had the corresponding\nhelper class since 2023 (952ef94ed78d71). The camera sensor properties\ndatabase also has an entry for it (2fb0f250196326), but the camera sensor\nhelper class is missing from the common libipa component. So add it, with\nthe same gain formula present in the raspberry pi ipa module, and the black\nlevel taken from the rpi tuning files.\n\nHandling the raspberry pi specific \"wide\" / \"noir\" suffixes is omitted.\nThey are not present in the camera sensor properties database either.\n\nSigned-off-by: Daniel Scally \n[Add black level, extend commit message.]\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \n---\nchanges in v3:\n * add black level as well\n\nchanges in v2:\n * drop rpi specific suffixes\n\nv2: https://patchwork.libcamera.org/patch/24765/\nv1: https://patchwork.libcamera.org/patch/24708/\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)\n\n--\n2.51.1","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ef3bd0d621..e3e3e53554 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -642,6 +642,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n\n+class CameraSensorHelperImx708 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx708()\n+\t{\n+\t\tblackLevel_ = 4096;\n+\t\tgain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n+\n class CameraSensorHelperOv2685 : public CameraSensorHelper\n {\n public:\n","prefixes":["RFC","v3"]}