{"id":24816,"url":"https://patchwork.libcamera.org/api/1.1/patches/24816/?format=json","web_url":"https://patchwork.libcamera.org/patch/24816/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251025142300.64480-3-uajain@igalia.com>","date":"2025-10-25T14:22:58","name":"[v3,2/4] gstreamer: Associate libcamera::Stream with Pad","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d658fbf40e377e7d3b3351343ecffd5348a21a6b","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/1.1/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24816/mbox/","series":[{"id":5529,"url":"https://patchwork.libcamera.org/api/1.1/series/5529/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5529","date":"2025-10-25T14:22:56","name":"gstreamer: Assorted fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/5529/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24816/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49736C32D4\n\tfor ;\n\tSat, 25 Oct 2025 14:22:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B66D606DB;\n\tSat, 25 Oct 2025 16:22:46 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0DF0606C5\n\tfor ;\n\tSat, 25 Oct 2025 16:22:39 +0200 (CEST)","from amazon1-vf-gw.lnd.cw.net ([195.89.103.118] helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCfAE-00F7ub-RJ; Sat, 25 Oct 2025 16:22:38 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"na5O6jPh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=erzCrCZ3kCxtERMQLav6bLuT/GZbdQbsinW3ixG1RZw=;\n\tb=na5O6jPhiE/kMoCvibWniA1OBg\n\thcYkqGRF3B0SS/qSD8/EX4L/wOQyhjAV3ZQhwwxwo1GWRC1LqJ9j9I8Zq+pJGZdrBHNoSI7a9BAFg\n\t4R6pTOvkDmMSus+F8ROtRXZVxuKWPnYVdTLi4vIUaQhNy0aKeUoaBW+HZhr6Agx4jPJkqA6bgUUVL\n\t0gdodTk2KrW/eLK05yA6HLpWpscFbl3CFJMEDvwg65MuTkz15LZwiHhsEOB+KRb3n9ps26tbsLxf0\n\t9LyLQWP9xei4RMZbddUlZwEwBc8W6IWcpuhlqjtMcWj8SsuTp8iMhoRa6xTSr3Npx2y7g/0ZA0ARn\n\tOFuD3JXQ==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"barnabas.pocze@ideasonboard.com,\n\tNicolas Dufresne ,\n\tUmang Jain ","Subject":"[PATCH v3 2/4] gstreamer: Associate libcamera::Stream with Pad","Date":"Sat, 25 Oct 2025 15:22:58 +0100","Message-ID":"<20251025142300.64480-3-uajain@igalia.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251025142300.64480-1-uajain@igalia.com>","References":"<20251025142300.64480-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of trying to figure out which libcamera::Stream, the GstPad\nis configured with (from the libcamera pool), associate the Stream\nwith the GstPad directly. The association can be set using\ngst_pad_set_element_private().\n\nAdjust the gst_libcamera_pad_get_stream() to use to complementary\ngetter gst_pad_get_element_private().\n\nSigned-off-by: Umang Jain \n---\n src/gstreamer/gstlibcamerapad.cpp | 7 +------\n src/gstreamer/gstlibcamerasrc.cpp | 6 +++++-\n 2 files changed, 6 insertions(+), 7 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 22b96719..90738489 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -192,12 +192,7 @@ void gst_libcamera_pad_set_video_info(GstPad *pad, const GstVideoInfo *info)\n Stream *\n gst_libcamera_pad_get_stream(GstPad *pad)\n {\n-\tauto *self = GST_LIBCAMERA_PAD(pad);\n-\n-\tif (self->pool)\n-\t\treturn gst_libcamera_pool_get_stream(self->pool);\n-\n-\treturn nullptr;\n+\treturn static_cast(gst_pad_get_element_private(pad));\n }\n \n void\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a1556cc5..a3c48b1d 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -357,7 +357,7 @@ int GstLibcameraSrcState::processRequest()\n \t\tGstBuffer *buffer = wrap->detachBuffer(stream);\n \n \t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n-\t\tconst StreamConfiguration &stream_cfg = config_->at(i);\n+\t\tconst StreamConfiguration &stream_cfg = stream->configuration();\n \t\tGstBufferPool *video_pool = gst_libcamera_pad_get_video_pool(srcpad);\n \n \t\tif (video_pool) {\n@@ -692,6 +692,9 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tgst_libcamera_pad_set_pool(srcpad, pool);\n \t\tgst_libcamera_pad_set_video_pool(srcpad, video_pool);\n \n+\t\t/* Associate the configured stream with the src pad. */\n+\t\tgst_pad_set_element_private(srcpad, stream_cfg.stream());\n+\n \t\t/* Clear all reconfigure flags. */\n \t\tgst_pad_check_reconfigure(srcpad);\n \t}\n@@ -888,6 +891,7 @@ gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n \t\tfor (GstPad *srcpad : state->srcpads_) {\n \t\t\tgst_libcamera_pad_set_latency(srcpad, GST_CLOCK_TIME_NONE);\n \t\t\tgst_libcamera_pad_set_pool(srcpad, nullptr);\n+\t\t\tgst_pad_set_element_private(srcpad, nullptr);\n \t\t}\n \t}\n \n","prefixes":["v3","2/4"]}