{"id":24779,"url":"https://patchwork.libcamera.org/api/1.1/patches/24779/?format=json","web_url":"https://patchwork.libcamera.org/patch/24779/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-14-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:37","name":"[v1,13/35] ipa: rkisp1: Add initializeFrameContext() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"322727481f94c89e8254acdb28fb1e7743af958e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24779/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/1.1/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24779/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24779/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4408C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A648D608C4;\n\tFri, 24 Oct 2025 10:52:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E22460871\n\tfor ;\n\tFri, 24 Oct 2025 10:52:16 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CA01A1E78; \n\tFri, 24 Oct 2025 10:50:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NYsGzvfl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295830;\n\tbh=3djUqQG0nWA/eMrJnEfgCvzJGz41gkaqYt8keBU2li8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NYsGzvflYk0p5MF7wMGZ/RBC06HMmCW26eyYYFZiBnqJ3efSZUWO19BGMaZZl9/5k\n\tGtFCwjF55hQMQQ0KYTNa7W9VU/ilUnmT6NzNuGUvcyr9pZBTF/lDTAqC718CSLyBDv\n\tqpGq55tc++222MJfGxHaOUC1AUMgFa1x6vqmjhLY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 13/35] ipa: rkisp1: Add initializeFrameContext() function","Date":"Fri, 24 Oct 2025 10:50:37 +0200","Message-ID":"<20251024085130.995967-14-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation to handling startup controls, split the frame context\ninitialization from queueRequest into a separate function.\n\nThis patch contains no functional changes.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/rkisp1.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex ee87c899fcb1..a55bac260026 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -67,6 +67,9 @@ public:\n \n \tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n \tvoid computeParams(const uint32_t frame, const uint32_t bufferId) override;\n+\tvoid initializeFrameContext(const uint32_t frame,\n+\t\t\t\t IPAFrameContext &frameContext,\n+\t\t\t\t const ControlList &controls);\n \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n \t\t\t const ControlList &sensorControls) override;\n \n@@ -331,6 +334,13 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n \tcontext_.debugMetadata.enableByControl(controls);\n \n+\tinitializeFrameContext(frame, frameContext, controls);\n+}\n+\n+void IPARkISP1::initializeFrameContext(const uint32_t frame,\n+\t\t\t\t IPAFrameContext &frameContext,\n+\t\t\t\t const ControlList &controls)\n+{\n \tfor (auto const &a : algorithms()) {\n \t\tAlgorithm *algo = static_cast(a.get());\n \t\tif (algo->disabled_)\n","prefixes":["v1","13/35"]}