{"id":24776,"url":"https://patchwork.libcamera.org/api/1.1/patches/24776/?format=json","web_url":"https://patchwork.libcamera.org/patch/24776/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-11-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:34","name":"[v1,10/35] pipeline: rkisp1: Add a frameStart function to handle DelayedControls::applyControls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"33954fb6bd90d1fb46015d56e7e92affba6537e7","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24776/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/1.1/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24776/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24776/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B68E6C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:52:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71C8B608BE;\n\tFri, 24 Oct 2025 10:52:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F8E160871\n\tfor ;\n\tFri, 24 Oct 2025 10:52:06 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 00DC61AC5; \n\tFri, 24 Oct 2025 10:50:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ghTdwVku\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295821;\n\tbh=6a/BD2w3Wvdd0+vmdLhxYk3YtXZJ0ULr+FFOcsOu8xc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ghTdwVkuUXir5om0CYm3Tl0FJjm8gTJghpL44hOfP7C6lJqStioj5o/jkrjZMOgCG\n\tfsipDteWjd6r61tOVOZhGduSxjxJbX/9hkeIXSbS+2K1MIKiedKBjWDA7eN8hI3oXP\n\tDaHGYO0gxyeRbMuuAlnHueR2usFAyeiAr0j9ThL4=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 10/35] pipeline: rkisp1: Add a frameStart function to\n\thandle DelayedControls::applyControls","Date":"Fri, 24 Oct 2025 10:50:34 +0200","Message-ID":"<20251024085130.995967-11-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the call to applyControls into an intermediate function for\nupcoming modfications.\n\nWhile at it, properly disconnect the signal on failure.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 17250cbd5ae6..9be9f44db479 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1540,6 +1540,7 @@ const uint32_t kDefaultExtParamsBlocks = 0xfffff;\n \n int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n {\n+\tutils::ScopeExitActions actions;\n \tint ret;\n \n \tstd::unique_ptr data =\n@@ -1570,8 +1571,10 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tdata->delayedCtrls_ =\n \t\tstd::make_unique(data->sensor_->device(),\n \t\t\t\t\t\t params);\n-\tisp_->frameStart.connect(data->delayedCtrls_.get(),\n-\t\t\t\t &DelayedControls::applyControls);\n+\tisp_->frameStart.connect(this,\n+\t\t\t\t &PipelineHandlerRkISP1::frameStart);\n+\n+\tactions += [&]() { isp_->frameStart.disconnect(this); };\n \n \tuint32_t supportedBlocks = kDefaultExtParamsBlocks;\n \n@@ -1603,9 +1606,20 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \n \tregisterCamera(std::move(camera));\n \n+\tactions.release();\n+\n \treturn 0;\n }\n \n+void PipelineHandlerRkISP1::frameStart(uint32_t sequence)\n+{\n+\tif (!activeCamera_)\n+\t\treturn;\n+\n+\tRkISP1CameraData *data = cameraData(activeCamera_);\n+\tdata->delayedCtrls_->applyControls(sequence);\n+}\n+\n bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n {\n \tDeviceMatch dm(\"rkisp1\");\n","prefixes":["v1","10/35"]}