{"id":24767,"url":"https://patchwork.libcamera.org/api/1.1/patches/24767/?format=json","web_url":"https://patchwork.libcamera.org/patch/24767/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-2-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:25","name":"[v1,01/35] libcamera: delayed_controls: Add push() function that accepts a sequence number","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6f472361fadc9b4fcfc376e8e3b71c469e7beebd","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24767/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/1.1/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24767/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24767/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01C82C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:51:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C27DB6087C;\n\tFri, 24 Oct 2025 10:51:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 851646085B\n\tfor ;\n\tFri, 24 Oct 2025 10:51:39 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0FCD8177F; \n\tFri, 24 Oct 2025 10:49:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vbnAErZl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295794;\n\tbh=6W2BisUo8z5q3pMwUV4ajbCf6goYEOHA6JQaFBACUvw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vbnAErZlXbh+C2wwooP5m5zOrV2jgFfcCaXZB0yJxELGF+BU++ZZ0sqyhAbSZQb3J\n\tNUngXf0H/rsJEPXQ3RBN1/shBw+o3MAGxedcUt5+pk9eJF6AwuYndK13WSORyFrSZL\n\t/Jm3semrxs3XwCZOjgGTb5w932hD0qtgu42QfNlY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 01/35] libcamera: delayed_controls: Add push() function\n\tthat accepts a sequence number","Date":"Fri, 24 Oct 2025 10:50:25 +0200","Message-ID":"<20251024085130.995967-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The push function is asymmetric to the get() and applyControls()\nfunction in that it doesn't allow to specify a frame number. This leads\nto the unfortunate situation that it is very difficult to detect if\nanything goes out of sync. Add a version of the push() function that\ntakes a sequence parameter and warns when the sequence provided differs\nfrom the expected sequence. Don't take any further actions for now to\nsee where issues pop up.\n\nSigned-off-by: Stefan Klug \n---\n include/libcamera/internal/delayed_controls.h | 1 +\n src/libcamera/delayed_controls.cpp | 32 ++++++++++++++++++-\n 2 files changed, 32 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\nindex b64d8bba7cf7..c650e672d964 100644\n--- a/include/libcamera/internal/delayed_controls.h\n+++ b/include/libcamera/internal/delayed_controls.h\n@@ -32,6 +32,7 @@ public:\n \tvoid reset();\n \n \tbool push(const ControlList &controls);\n+\tbool push(uint32_t sequence, const ControlList &controls);\n \tControlList get(uint32_t sequence);\n \n \tvoid applyControls(uint32_t sequence);\ndiff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 94d0a575b01b..246e7cefa4e5 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -144,10 +144,40 @@ void DelayedControls::reset()\n * Push a set of controls to the control queue. This increases the control queue\n * depth by one.\n *\n+ * \\note The usage of this function is discouraged as it does not provide a way\n+ * to detect double pushes for the same sequence. Better\n+ * DelayedControls::push(uint32_t sequence, const ControlList &controls)\n+ * instead.\n+ *\n * \\returns true if \\a controls are accepted, or false otherwise\n */\n bool DelayedControls::push(const ControlList &controls)\n {\n+\tLOG(DelayedControls, Debug) << \"Deprecated: Push without sequence number\";\n+\treturn push(queueCount_, controls);\n+}\n+\n+/**\n+ * \\brief Push a set of controls on the queue\n+ * \\param[in] sequence The sequence number to push for\n+ * \\param[in] controls List of controls to add to the device queue\n+ *\n+ * Push a set of controls to the control queue. This increases the control queue\n+ * depth by one.\n+ *\n+ * The \\a sequence number is used to do some sanity checks to detect double\n+ * pushes for the same sequence (either due to a bug or a request underrun).\n+ *\n+ * \\returns true if \\a controls are accepted, or false otherwise\n+ */\n+bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n+{\n+\tif (sequence < queueCount_) {\n+\t\tLOG(DelayedControls, Warning)\n+\t\t\t<< \"Double push for sequence \" << sequence\n+\t\t\t<< \" current queue index: \" << queueCount_;\n+\t}\n+\n \t/* Copy state from previous frame. */\n \tfor (auto &ctrl : values_) {\n \t\tInfo &info = ctrl.second[queueCount_];\n@@ -276,7 +306,7 @@ void DelayedControls::applyControls(uint32_t sequence)\n \twhile (writeCount_ > queueCount_) {\n \t\tLOG(DelayedControls, Debug)\n \t\t\t<< \"Queue is empty, auto queue no-op.\";\n-\t\tpush({});\n+\t\tpush(queueCount_, {});\n \t}\n \n \tdevice_->setControls(&out);\n","prefixes":["v1","01/35"]}