{"id":24746,"url":"https://patchwork.libcamera.org/api/1.1/patches/24746/?format=json","web_url":"https://patchwork.libcamera.org/patch/24746/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-20-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:20","name":"[v2,19/35] libcamera: converter: Add dw100 converter class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5067ae166b197cd2ad03ce185e6f671e385c423e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24746/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/1.1/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24746/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24746/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7B4EC333D\n\tfor ;\n\tThu, 23 Oct 2025 14:49:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BFCD60827;\n\tThu, 23 Oct 2025 16:49:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0E2F6081B\n\tfor ;\n\tThu, 23 Oct 2025 16:49:43 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BB8D0177F; \n\tThu, 23 Oct 2025 16:47:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qk28LQCt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230878;\n\tbh=swYmmu87kl8GkVUrs4QNf1ckrkILpGD5Fx54UnIycSA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Qk28LQCt487Y6ToVxr4Ezl1MhvzuprcD/2BOEPAjsAn1UTTY0CAsfZfewgU3yQ+UQ\n\tc/+MkC0X7yd/Gtt2gzqlkCpIWAEqOcWqStMdyiMQvZnv6Yz+61SteYGJwdC1H2Hv3g\n\tj5QSLLqP0B4b8fyyxVBY94MVxPlBTL3gisBjUbXA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tUmang Jain ,\n\tPaul Elder ","Subject":"[PATCH v2 19/35] libcamera: converter: Add dw100 converter class","Date":"Thu, 23 Oct 2025 16:48:20 +0200","Message-ID":"<20251023144841.403689-20-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Umang Jain \n\nDW100 Dewarp engine is present on i.MX8MP SoC. This patch\nprovides a dedicated converter class (inherited from V4L2M2MConverter).\n\nThe DW100 dewarp engine has scaling capabilites and can be used\nto set crop rectangles in the rkisp1 pipeline handler. Plumbing\nin the RkISP1 pipeline-handler is done in the subsequent patch.\n\nThe ConverterDW100 class will be extended by upcoming patches to support\nthe dewarping by setting a dewarp vertex map as well.\n\nSigned-off-by: Umang Jain \nReviewed-by: Paul Elder \nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Drop validateSize() as it is not used anywhere\n\nChanges in v0.9\n- Use shared_ptr in constructor\n---\n .../internal/converter/converter_dw100.h | 24 ++++++++++++\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 37 +++++++++++++++++++\n src/libcamera/converter/meson.build | 1 +\n 4 files changed, 63 insertions(+)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp","diff":"diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nnew file mode 100644\nindex 000000000000..dc41f365b5c7\n--- /dev/null\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class MediaDevice;\n+class Rectangle;\n+class Stream;\n+\n+class ConverterDW100 : public V4L2M2MConverter\n+{\n+public:\n+\tConverterDW100(std::shared_ptr media);\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\nindex 891e79e7d493..85007a4b0f8b 100644\n--- a/include/libcamera/internal/converter/meson.build\n+++ b/include/libcamera/internal/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_headers += files([\n+ 'converter_dw100.h',\n 'converter_v4l2_m2m.h',\n ])\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nnew file mode 100644\nindex 000000000000..1d2d0435b08e\n--- /dev/null\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -0,0 +1,37 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n+\n+#include \n+\n+#include \n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Converter)\n+\n+/**\n+ * \\class libcamera::ConverterDW100\n+ * \\brief The i.MX8MP dewarp converter implements the converter interface based\n+ * on V4L2 M2M device.\n+*/\n+\n+/**\n+ * \\fn ConverterDW100::ConverterDW100\n+ * \\brief Construct a ConverterDW100 instance\n+ * \\param[in] media The media device implementing the converter\n+ */\n+ConverterDW100::ConverterDW100(std::shared_ptr media)\n+\t: V4L2M2MConverter(media)\n+{\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\nindex af1a80fec683..fe2dcebb67da 100644\n--- a/src/libcamera/converter/meson.build\n+++ b/src/libcamera/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_sources += files([\n+ 'converter_dw100.cpp',\n 'converter_v4l2_m2m.cpp'\n ])\n","prefixes":["v2","19/35"]}