{"id":24691,"url":"https://patchwork.libcamera.org/api/1.1/patches/24691/?format=json","web_url":"https://patchwork.libcamera.org/patch/24691/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251016140720.216006-1-uajain@igalia.com>","date":"2025-10-16T14:07:19","name":"[v2] libcamera: request: Clarify ReuseBuffers flag usage with fences","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"17cf70210a49b86471799bf11d438d7fa026f11e","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/1.1/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24691/mbox/","series":[{"id":5506,"url":"https://patchwork.libcamera.org/api/1.1/series/5506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5506","date":"2025-10-16T14:07:19","name":"[v2] libcamera: request: Clarify ReuseBuffers flag usage with fences","version":2,"mbox":"https://patchwork.libcamera.org/series/5506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24691/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24691/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AAB2BE080\n\tfor ;\n\tThu, 16 Oct 2025 14:07:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A741D60689;\n\tThu, 16 Oct 2025 16:07:06 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12974605D7\n\tfor ;\n\tThu, 16 Oct 2025 16:07:05 +0200 (CEST)","from [49.36.127.56] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1v9OdC-00ATPu-Nr; Thu, 16 Oct 2025 16:07:03 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"PQQdTucQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:\n\tDate:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=bIi5m13jE0cHCqJ/sNK7bs7OagrkcVHquuyOPXwr7uk=;\n\tb=PQQdTucQQZQUKU99Aoul1stOYw\n\tHPEBQQZMOequgyNGz0/vPvHRphw9Pab3woiz0XXzyD+ne60mhtipY6VFKB8wBH5P8fHX+Rp6Pt4kU\n\tk5pqmGCvgHG0jg7FAXAqu0fkhEWIIdZrT+pG8iIE0Zc7Tx+lyBNC7fe4VlG+2vsB59BzGsvOGyHI+\n\tAa+mUBlXrqgI+D+7QccRvxc6lTLE/lhdNYMzKL2z/0pmCeizmqy18SQg2dfPV+VRi1gE3zCgbAxMP\n\tuwpV/Yzn+i0sxw0TzqMwykTAebknb8xCXL+mI6uhk4Bil5WaHKJdDGWl4m1+Lw8UFUyZ2Vvk985kh\n\t4I1hbrHA==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tUmang Jain ,\n\tKieran Bingham ","Subject":"[PATCH v2] libcamera: request: Clarify ReuseBuffers flag usage with\n\tfences","Date":"Thu, 16 Oct 2025 19:37:19 +0530","Message-ID":"<20251016140720.216006-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Explicitly clarify the usage of Request::ReuseBuffers flag in context\nof buffer fences. Fences are user-supplied and are not re-cycled as\npart of Request::reuse(), hence document this behaviour explicitly.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \n---\nChanges in v2:\n- Use \\note annotation suggested by Barnabás\n\nv1: https://patchwork.libcamera.org/patch/24070/\n---\n src/libcamera/request.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 26bba8f2..992d476e 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -327,6 +327,9 @@ void Request::Private::timeout()\n * Don't reuse buffers\n * \\var Request::ReuseBuffers\n * Reuse the buffers that were previously added by addBuffer()\n+ *\n+ * \\note Fences associated with the buffers are not reused.\n+ * This flag should not be used if fences are used.\n */\n \n /**\n","prefixes":["v2"]}