{"id":24621,"url":"https://patchwork.libcamera.org/api/1.1/patches/24621/?format=json","web_url":"https://patchwork.libcamera.org/patch/24621/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:27","name":"[v1,05/12] ipa: rkisp1: lsc: Rename res to ret","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7dc7d08545956067d956d222d21efb97a48f15ff","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24621/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/1.1/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24621/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24621/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE27EBF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 315CD605D0;\n\tTue, 14 Oct 2025 09:53:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80A876052F\n\tfor ;\n\tTue, 14 Oct 2025 09:53:13 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 529AAC73;\n\tTue, 14 Oct 2025 09:51:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mdnGsEWH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428295;\n\tbh=dg6CvKFqBV5VDXoxIZfPMXvTEHeS9+it41urpZy1QOc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mdnGsEWHbCAbK+0oTy6/eyEns2TGI80c1Mt28pECMircG1XfSQUzUlCXtVfe55GWp\n\tg/C4uPxLoOv9atVb45nHrSb0bPz9kahYxdYM+K/Kqsc5Ia9/knMzYRi2hhXoh/Kt85\n\tnhIyq6bu/UrzEY2HQUvFbXQi605Fx8hg9wsf4oMc=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","Date":"Tue, 14 Oct 2025 09:52:27 +0200","Message-ID":"<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename res to ret as that is used in libcamera for return codes.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex bb58386ae646..e4938dbd657c 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -320,28 +320,29 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n \t\treturn -EINVAL;\n \t}\n \n+\tint ret = 0;\n \tstd::map lscData;\n-\tint res = 0;\n+\n \tstd::string type = tuningData[\"type\"].get(\"table\");\n \tif (type == \"table\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n \t\tauto loader = LscTableLoader();\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else if (type == \"polynomial\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n \t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n \t\t\t\t\t\t context.sensorInfo.analogCrop,\n \t\t\t\t\t\t xSize_,\n \t\t\t\t\t\t ySize_);\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else {\n \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n \t\t\t\t << type << \"'\";\n-\t\tres = -EINVAL;\n+\t\tret = -EINVAL;\n \t}\n \n-\tif (res)\n-\t\treturn res;\n+\tif (ret)\n+\t\treturn ret;\n \n \tsets_.setData(std::move(lscData));\n \n","prefixes":["v1","05/12"]}