{"id":24620,"url":"https://patchwork.libcamera.org/api/1.1/patches/24620/?format=json","web_url":"https://patchwork.libcamera.org/patch/24620/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-5-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:26","name":"[v1,04/12] ipa: rkisp1: lsc: Rename res to positions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0ee819e8a55a8bb121448dbae8acfd6541c8d2ad","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24620/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/1.1/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24620/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24620/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FEF1BF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 415DD605D7;\n\tTue, 14 Oct 2025 09:53:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 046A4605D0\n\tfor ;\n\tTue, 14 Oct 2025 09:53:11 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ABDBC741;\n\tTue, 14 Oct 2025 09:51:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cea6rgnK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428292;\n\tbh=9iKWzfrp5sGrmZ68X330iYb6beiyYZPZMkiEhz3X12Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cea6rgnKXAmQDRmpNFYDA4IdKxnMqtr/NhMGZQ/6nvh+seJ/h4IGs7wKMtQHraE5P\n\t1ddow34OxvUVXhm+0D3hq9+8LkLk85oBYhU1SSdlFnlP5zKLOxn+xwpU+EMz4f8hmo\n\tUbIgRwUeiGCwPVz5CuUSGxpNn42qQ3RGQlMe75iY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 04/12] ipa: rkisp1: lsc: Rename res to positions","Date":"Tue, 14 Oct 2025 09:52:26 +0200","Message-ID":"<20251014075252.2876485-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the res variable to positions which better describes the intent.\nThis was commented in review after being merged.\n\nWhile at it, improve the documentation a bit.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex c581e6441853..bb58386ae646 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -132,9 +132,11 @@ public:\n \n private:\n \t/*\n-\t * The lsc grid has custom spacing defined on half the range (see\n-\t * parseSizes() for details). For easier handling this function converts\n-\t * the spaces vector to positions and mirrors them. E.g.:\n+\t * The rkisp1 LSC grid spacing is defined by the cell sizes on the first\n+\t * half of the grid. This is then mirrored in hardware to the other\n+\t * half. See parseSizes() for further details. For easier handling, this\n+\t * function converts the cell sizes of half the grid to a list of\n+\t * position of the whole grid (on one axis). Example:\n \t *\n \t * input: | 0.2 | 0.3 |\n \t * output: 0.0 0.2 0.5 0.8 1.0\n@@ -142,17 +144,17 @@ private:\n \tstd::vector sizesListToPositions(const std::vector &sizes)\n \t{\n \t\tconst int half = sizes.size();\n-\t\tstd::vector res(half * 2 + 1);\n+\t\tstd::vector positions(half * 2 + 1);\n \t\tdouble x = 0.0;\n \n-\t\tres[half] = 0.5;\n+\t\tpositions[half] = 0.5;\n \t\tfor (int i = 1; i <= half; i++) {\n \t\t\tx += sizes[half - i];\n-\t\t\tres[half - i] = 0.5 - x;\n-\t\t\tres[half + i] = 0.5 + x;\n+\t\t\tpositions[half - i] = 0.5 - x;\n+\t\t\tpositions[half + i] = 0.5 + x;\n \t\t}\n \n-\t\treturn res;\n+\t\treturn positions;\n \t}\n \n \tstd::vector samplePolynomial(const LscPolynomial &poly)\n","prefixes":["v1","04/12"]}