{"id":24536,"url":"https://patchwork.libcamera.org/api/1.1/patches/24536/?format=json","web_url":"https://patchwork.libcamera.org/patch/24536/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930150428.11101-4-hansg@kernel.org>","date":"2025-09-30T15:04:25","name":"[v4,3/6] ipa: software_isp: AGC: Raise exposure or gain not both at the same time","commit_ref":"5d62463915f1a2ccb903958bbd72a9c185e7e688","pull_url":null,"state":"accepted","archived":false,"hash":"1f3aab39be3c9ed8e010e20f3ea5fe88022d79de","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/1.1/people/239/?format=json","name":"Hans de Goede","email":"hansg@kernel.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24536/mbox/","series":[{"id":5470,"url":"https://patchwork.libcamera.org/api/1.1/series/5470/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5470","date":"2025-09-30T15:04:22","name":"ipa: software_isp: AGC: Fix AGC oscillation bug","version":4,"mbox":"https://patchwork.libcamera.org/series/5470/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24536/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24536/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5661AC328C\n\tfor ;\n\tTue, 30 Sep 2025 15:04:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 457626B614;\n\tTue, 30 Sep 2025 17:04:44 +0200 (CEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B8C46B5F9\n\tfor ;\n\tTue, 30 Sep 2025 17:04:39 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 67C7D62892;\n\tTue, 30 Sep 2025 15:04:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D9F00C4CEF0;\n\tTue, 30 Sep 2025 15:04:36 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"GJgZZivJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1759244678;\n\tbh=Ytqc3j+RlSAjQpfzFAAH1QPOZnlUEEjm1YxgWtn6q3A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GJgZZivJi5oP2uJZaO4sw+LwwM+MFmCUHWPfgcbpndLzKlf4puHxaaKkfOnc2vmA7\n\tkVrN+Qb9XaCbOSAlya+4J4eDPMCy9TSB7i7k3UWimVobx5mkfTprW150nleiuH28Ua\n\tX1lnpyJy88xrhjs2NlZaOG8bKoBY4MDUxDepntwgsIQ6klN3vuCOf8+2+dozmMVEy2\n\t4NdukgxlN2RNVjCEexGdLzer11987ttXnTn2jVLR+CV4Xxv6DfEOyPqv7ivysgOcbT\n\tZAJl9F4kTnL7TTZy5cbD2WFW7t1SKklQbXAiue20IJDcNTtMQJjn5xjfKNfw17Ewgy\n\tYILNQiqLwigKg==","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans de Goede , Milan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v4 3/6] ipa: software_isp: AGC: Raise exposure or gain not\n\tboth at the same time","Date":"Tue, 30 Sep 2025 17:04:25 +0200","Message-ID":"<20250930150428.11101-4-hansg@kernel.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250930150428.11101-1-hansg@kernel.org>","References":"<20250930150428.11101-1-hansg@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Raise either exposure or gain; not both at the same time.\n\nBefore this change when the last exposure raise is done, hitting\nexposure-max, gain would be increased at the same time.\n\nReviewed-by: Milan Zamazal \nTested-by: Milan Zamazal \nTested-by: Kieran Bingham \nSigned-off-by: Hans de Goede \n---\n src/ipa/simple/algorithms/agc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex 1fc8d7f42..f7f734514 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -56,12 +56,13 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \tdouble &again = frameContext.sensor.gain;\n \n \tif (exposureMSV < kExposureOptimal - kExposureSatisfactory) {\n-\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n-\t\tif (next - exposure < 1)\n-\t\t\texposure += 1;\n-\t\telse\n-\t\t\texposure = next;\n-\t\tif (exposure >= context.configuration.agc.exposureMax) {\n+\t\tif (exposure < context.configuration.agc.exposureMax) {\n+\t\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n+\t\t\tif (next - exposure < 1)\n+\t\t\t\texposure += 1;\n+\t\t\telse\n+\t\t\t\texposure = next;\n+\t\t} else {\n \t\t\tnext = again * kExpNumeratorUp / kExpDenominator;\n \t\t\tif (next - again < context.configuration.agc.againMinStep)\n \t\t\t\tagain += context.configuration.agc.againMinStep;\n","prefixes":["v4","3/6"]}