{"id":24532,"url":"https://patchwork.libcamera.org/api/1.1/patches/24532/?format=json","web_url":"https://patchwork.libcamera.org/patch/24532/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930122726.1837524-34-stefan.klug@ideasonboard.com>","date":"2025-09-30T12:26:54","name":"[v1,33/33] DNI pipeline: rkisp1: Workaround for customer kernels without requests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"22a7ffad749d56be1fb6de9cc96210481c944d5b","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24532/mbox/","series":[{"id":5468,"url":"https://patchwork.libcamera.org/api/1.1/series/5468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5468","date":"2025-09-30T12:26:21","name":"Full dewarper support on imx8mp","version":1,"mbox":"https://patchwork.libcamera.org/series/5468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24532/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24532/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62A37C328C\n\tfor ;\n\tTue, 30 Sep 2025 13:41:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D0876B5F0;\n\tTue, 30 Sep 2025 15:41:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B695262C35\n\tfor ;\n\tTue, 30 Sep 2025 15:41:53 +0200 (CEST)","from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7D07816A;\n\tTue, 30 Sep 2025 15:40:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kTLFc7Z6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759239625;\n\tbh=x+vjD6onUSlvK78JMqMvix69fARA+qz6/JunZ/8/qCE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kTLFc7Z6FA+DKytS9NlKorj5rKSin6PiDV/7r+Na/C8GQREKfzqQTW2X7Vk36+8jX\n\tHfa5Uq54MOGiywbsFac56AC8tlUOWoOoO8WghKwU/yWFyAvgiw5T+w6CJwESXlJLCi\n\t4LzK8E9oDFrG+m7KIfHe1AbBYjXhI9Dvr20mjTGk=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 33/33] DNI pipeline: rkisp1: Workaround for customer\n\tkernels without requests","Date":"Tue, 30 Sep 2025 14:26:54 +0200","Message-ID":"<20250930122726.1837524-34-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There are a few kernels out there that have dynamic vertex map support,\nbut no requests support. Allow full dewarp usage on these.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 98521c804d84..e50cf8c0f978 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -183,6 +183,13 @@ static constexpr unsigned int kRkISP1MaxQueuedRequests = 4;\n */\n static constexpr unsigned int kRkISP1MinBufferCount = 4;\n \n+/*\n+ * This flag allows to use dynamic dewarp maps to support pan, zoom, rotate when\n+ * the kernel driver doesn't support requests. Only needed for legacy customer\n+ * kernels.\n+ */\n+static constexpr bool kAllowDynamicDewarpMapsWithoutRequests = true;\n+\n } /* namespace */\n \n class PipelineHandlerRkISP1 : public PipelineHandler\n@@ -1514,7 +1521,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\t\t\t\t\t\t\t maxCrop);\n \t\t}\n \n-\t\tif (dewarper_->supportsRequests()) {\n+\t\tif (dewarper_->supportsRequests() || kAllowDynamicDewarpMapsWithoutRequests) {\n \t\t\tcontrols[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f);\n \t\t\tcontrols[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f);\n \t\t\tcontrols[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));\n","prefixes":["v1","33/33"]}