{"id":24516,"url":"https://patchwork.libcamera.org/api/1.1/patches/24516/?format=json","web_url":"https://patchwork.libcamera.org/patch/24516/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930122726.1837524-18-stefan.klug@ideasonboard.com>","date":"2025-09-30T12:26:38","name":"[v1,17/33] libcamera: rkisp1: Allow upscaling when the dewarper is present","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"86250ad76805c58fb3c9633374b276e6e3a1a045","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24516/mbox/","series":[{"id":5468,"url":"https://patchwork.libcamera.org/api/1.1/series/5468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5468","date":"2025-09-30T12:26:21","name":"Full dewarper support on imx8mp","version":1,"mbox":"https://patchwork.libcamera.org/series/5468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24516/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24516/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF0ACC324C\n\tfor ;\n\tTue, 30 Sep 2025 13:08:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 181356B60F;\n\tTue, 30 Sep 2025 15:08:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6E2B69367\n\tfor ;\n\tTue, 30 Sep 2025 15:08:42 +0200 (CEST)","from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 993D3169;\n\tTue, 30 Sep 2025 15:07:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t1F+v7Pj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759237634;\n\tbh=C7ViNxbYsmiuOIF/YlfGElK4yVzAkd+18FUpPuuHQpQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=t1F+v7PjwXcQOkVm0SpF+6cHWAbNkLnVVRfYy+4Z1qrzccrQbRksE+h9fxCnvX5oH\n\tiMa6LeTb4OM/6lab42Wtqxa+IT1fJJBzTuDlt81xP/XJheiS25/vEk2E6R+fuQ6IOK\n\tW4DLu7NQAwotLcouesDHU+9DA+/pPHwHnIyKqlWg=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 17/33] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","Date":"Tue, 30 Sep 2025 14:26:38 +0200","Message-ID":"<20250930122726.1837524-18-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the dewarper is present, there is no need to forbid upscaling of\nthe image data.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 35a9d03198f1..61eec1bb8c44 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -614,6 +614,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t\t\treturn false;\n \n \t\tif (useDewarper) {\n+\t\t\t/*\n+\t\t\t * The dewarper output is independent of the ISP path.\n+\t\t\t * Reset to the originally requested size.\n+\t\t\t */\n+\t\t\ttryCfg.size = cfg.size;\n \t\t\tbool adjusted;\n \n \t\t\tpipe->dewarper_->validateOutput(&tryCfg, &adjusted,\n","prefixes":["v1","17/33"]}