{"id":24512,"url":"https://patchwork.libcamera.org/api/1.1/patches/24512/?format=json","web_url":"https://patchwork.libcamera.org/patch/24512/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930122726.1837524-14-stefan.klug@ideasonboard.com>","date":"2025-09-30T12:26:34","name":"[v1,13/33] libcamera: converter_v4l2_m2m: Add helper to apply controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"991917251858b3d0f6fe898ecb41666f28d189c3","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24512/mbox/","series":[{"id":5468,"url":"https://patchwork.libcamera.org/api/1.1/series/5468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5468","date":"2025-09-30T12:26:21","name":"Full dewarper support on imx8mp","version":1,"mbox":"https://patchwork.libcamera.org/series/5468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24512/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24512/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42F9BC324C\n\tfor ;\n\tTue, 30 Sep 2025 12:59:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E3276B5F0;\n\tTue, 30 Sep 2025 14:59:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 708E662C35\n\tfor ;\n\tTue, 30 Sep 2025 14:59:29 +0200 (CEST)","from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 10D48220;\n\tTue, 30 Sep 2025 14:58:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B3IoG+YR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759237081;\n\tbh=lBSgWBKYE8ufshhpqAOnTsznC+sPEavN+06FLfUpjLE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=B3IoG+YRz4qdcX2v7aC3Uo4K3GXKwPNv97O0eWGuMIMebKIVqD/pYBehGIlpTzSBe\n\tABeKs1zEUQlS0Qxd2oEzNzhlbgByBygVj9HhYxfqpOgzwK8Ihg/PJQN6p/ExbMu3UG\n\t0EvGE2a2yuFDP+dd0Nmk/R3aUTW+TC1y5AYhERJ0=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tUmang Jain ","Subject":"[PATCH v1 13/33] libcamera: converter_v4l2_m2m: Add helper to apply\n\tcontrols","Date":"Tue, 30 Sep 2025 14:26:34 +0200","Message-ID":"<20250930122726.1837524-14-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Umang Jain \n\nAdd applyControls() helper to apply controls for a stream.\n\nSigned-off-by: Umang Jain \nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v0.9\n- Include request support in applyControls\n---\n .../internal/converter/converter_v4l2_m2m.h | 5 +++++\n .../converter/converter_v4l2_m2m.cpp | 19 +++++++++++++++++++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\nindex 3b8fc5392b7d..615369c1a167 100644\n--- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n+++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n@@ -24,6 +24,7 @@\n \n namespace libcamera {\n \n+class ControlList;\n class FrameBuffer;\n class MediaDevice;\n class Size;\n@@ -73,6 +74,8 @@ public:\n \tstd::pair inputCropBounds() override { return inputCropBounds_; }\n \tstd::pair inputCropBounds(const Stream *stream) override;\n \n+\tint applyControls(const Stream *stream, ControlList &ctrls, const V4L2Request *request = nullptr);\n+\n \tint allocateRequests(unsigned int count,\n \t\t\t std::vector> *requests);\n \n@@ -94,6 +97,8 @@ protected:\n \t\tint start();\n \t\tvoid stop();\n \n+\t\tint applyControls(ControlList &ctrls, const V4L2Request *request = nullptr);\n+\n \t\tint queueBuffers(FrameBuffer *input, FrameBuffer *output,\n \t\t\t\t const V4L2Request *request = nullptr);\n \ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex e57db8a438ab..82e6d56e3d5c 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -18,6 +18,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n #include \n@@ -251,6 +252,12 @@ void V4L2M2MConverter::V4L2M2MStream::captureBufferReady(FrameBuffer *buffer)\n \tconverter_->outputBufferReady.emit(buffer);\n }\n \n+int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls,\n+\t\t\t\t\t\t const V4L2Request *request)\n+{\n+\treturn m2m_->capture()->setControls(&ctrls, request);\n+};\n+\n /* -----------------------------------------------------------------------------\n * V4L2M2MConverter\n */\n@@ -744,6 +751,18 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n \treturn 0;\n }\n \n+/**\n+ * libcamera::Converter::applyControls\n+ */\n+int V4L2M2MConverter::applyControls(const Stream *stream, ControlList &ctrls, const V4L2Request *request)\n+{\n+\tauto iter = streams_.find(stream);\n+\tif (iter == streams_.end())\n+\t\treturn -EINVAL;\n+\n+\treturn iter->second->applyControls(ctrls, request);\n+}\n+\n /**\n * \\copydoc libcamera::MediaDevice::allocateRequests\n */\n","prefixes":["v1","13/33"]}