{"id":24494,"url":"https://patchwork.libcamera.org/api/1.1/patches/24494/?format=json","web_url":"https://patchwork.libcamera.org/patch/24494/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250929201924.45019-7-mzamazal@redhat.com>","date":"2025-09-29T20:19:23","name":"[v5,6/7] ipa: simple: blc: Prevent division by zero in BLC","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c54121ce6191e7ef51b24f065d0f979cee6e20f5","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24494/mbox/","series":[{"id":5466,"url":"https://patchwork.libcamera.org/api/1.1/series/5466/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5466","date":"2025-09-29T20:19:17","name":"Fix stats related problems in software ISP","version":5,"mbox":"https://patchwork.libcamera.org/series/5466/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24494/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24494/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 136F5C324C\n\tfor ;\n\tMon, 29 Sep 2025 20:20:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3DE86B647;\n\tMon, 29 Sep 2025 22:20:00 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A7606B635\n\tfor ;\n\tMon, 29 Sep 2025 22:19:56 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-219-_VUXu6PpM8egfLeVclntiw-1;\n\tMon, 29 Sep 2025 16:19:51 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D57B4180057C; Mon, 29 Sep 2025 20:19:49 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A5D3D19560B4; Mon, 29 Sep 2025 20:19:47 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"i1PBlNMy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1759177194;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=0vG1RzvtkN9GpHKzUJAvHhmys4xFr8duDDYgf71W3L0=;\n\tb=i1PBlNMys+YMaGTh92Fg6POlcTCR9NmmuCpqKMyvHXKDxK7x7MVZEorT63PrhRW4jIc3fl\n\tzTxYrU7uCd2i4oJQeYg+oDXOA9mOIwEa9YhYQbyhwgy9F9RQESBc+9LqRxsuGxVKxKUnr4\n\tYOh4/yQHaLxWdL7UpkjtozyWpDQqKaI=","X-MC-Unique":"_VUXu6PpM8egfLeVclntiw-1","X-Mimecast-MFC-AGG-ID":"_VUXu6PpM8egfLeVclntiw_1759177190","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, hansg@kernel.org, =?utf-8?b?QmFybmFiw6Fz?=\n\t=?utf-8?q?_P=C5=91cze?= ","Subject":"[PATCH v5 6/7] ipa: simple: blc: Prevent division by zero in BLC","Date":"Mon, 29 Sep 2025 22:19:23 +0200","Message-ID":"<20250929201924.45019-7-mzamazal@redhat.com>","In-Reply-To":"<20250929201924.45019-1-mzamazal@redhat.com>","References":"<20250929201924.45019-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"EBzUym3FbOe007ni7msPrKgN6xFu6-8DwhcVaQn0Hs0_1759177190","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When there are no values in the histogram, BLC simple IPA can crash on\ndivision by zero. We cannot get anything meaningful in such a case\nanyway, let's simply return from `process()' then.\n\nTested-by: Barnabás Pőcze \nReviewed-by: Barnabás Pőcze \nReviewed-by: Maciej S. Szmigiero \nReviewed-by: Hans de Goede \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/blc.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 8c1e9ed08..ea5356443 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -77,6 +77,11 @@ void BlackLevel::process(IPAContext &context,\n \tconstexpr float ignoredPercentage = 0.02;\n \tconst unsigned int total =\n \t\tstd::accumulate(begin(histogram), end(histogram), 0);\n+\tif (total == 0) {\n+\t\tLOG(IPASoftBL, Debug) << \"Not guessing black level, histogram is empty\";\n+\t\treturn;\n+\t}\n+\n \tconst unsigned int pixelThreshold = ignoredPercentage * total;\n \tconst unsigned int histogramRatio = 256 / SwIspStats::kYHistogramSize;\n \tconst unsigned int currentBlackIdx =\n","prefixes":["v5","6/7"]}