{"id":24463,"url":"https://patchwork.libcamera.org/api/1.1/patches/24463/?format=json","web_url":"https://patchwork.libcamera.org/patch/24463/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250925221708.7471-2-hansg@kernel.org>","date":"2025-09-25T22:17:03","name":"[v2,1/6] ipa: software_isp: Fix context_.configuration.agc.againMin init","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ce05dd561721d3d83776876150b2dbbc7e6aa19a","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/1.1/people/239/?format=json","name":"Hans de Goede","email":"hansg@kernel.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24463/mbox/","series":[{"id":5459,"url":"https://patchwork.libcamera.org/api/1.1/series/5459/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5459","date":"2025-09-25T22:17:02","name":"ipa: software_isp: AGC: Fox AGC oscillation bug","version":2,"mbox":"https://patchwork.libcamera.org/series/5459/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24463/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24463/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BB42BDB1C\n\tfor ;\n\tThu, 25 Sep 2025 22:17:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A4936B606;\n\tFri, 26 Sep 2025 00:17:20 +0200 (CEST)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 434886B5F8\n\tfor ;\n\tFri, 26 Sep 2025 00:17:14 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id D1C8F4057B;\n\tThu, 25 Sep 2025 22:17:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 73F90C4CEF0;\n\tThu, 25 Sep 2025 22:17:11 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"NfQqyKeq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758838632;\n\tbh=i8luKV32QotAPxo62xELugb2IsfDO0Szq6/oYQ9c35A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NfQqyKeqd+FzWj7BNiwZp8wmQVOZUeALTuFjTblv2XY0iF6VNa9uWlsRbe7vuGw70\n\tywNLgC1CA7TbFBf+jN7CWLpsLLjYHxLIEthoZWauVPhuf64ifTJCWn15H3+so4X4RX\n\tz//uCiWFmuxTW9qZthoyfgQXT54nklrW5r3KuZ89i4u0ma6PQhVh7+tJD3IsDOkYbF\n\tGj49+0z6YNhp8enknfTDUPGTPAyBQWPtgOkz5Ndc32s/2h/bvwGFGj1vqTL4cidn5l\n\tIy9ylay4sIq14luizIyEuqJGIj396aZbyouyxj5D59iJxpO/A/Ch7nhF8y7wPsXrpx\n\tkdHiUkN6r0CGQ==","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans de Goede , Milan Zamazal ,\n\tIsaac Scott ,\n\tKieran Bingham ","Subject":"[PATCH v2 1/6] ipa: software_isp: Fix\n\tcontext_.configuration.agc.againMin init","Date":"Fri, 26 Sep 2025 00:17:03 +0200","Message-ID":"<20250925221708.7471-2-hansg@kernel.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250925221708.7471-1-hansg@kernel.org>","References":"<20250925221708.7471-1-hansg@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently context_.configuration.agc.againMin is not initialized\nwhen the control reports a non 0 minimum gain value.\n\nSo far only the againMin == 0 case was handled and\ncontext_.configuration.agc.againMin was left unset otherwise.\n\nReviewed-by: Milan Zamazal \nReviewed-by: Isaac Scott \nTested-by: Milan Zamazal \nTested-by: Kieran Bingham \nSigned-off-by: Hans de Goede \n---\n src/ipa/simple/soft_simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex c94c4cd5..e70439ee 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -246,7 +246,9 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n \t\t * other) we limit the range of the gain values used.\n \t\t */\n \t\tcontext_.configuration.agc.againMax = againMax;\n-\t\tif (!againMin) {\n+\t\tif (againMin) {\n+\t\t\tcontext_.configuration.agc.againMin = againMin;\n+\t\t} else {\n \t\t\tLOG(IPASoft, Warning)\n \t\t\t\t<< \"Minimum gain is zero, that can't be linear\";\n \t\t\tcontext_.configuration.agc.againMin =\n","prefixes":["v2","1/6"]}