{"id":24448,"url":"https://patchwork.libcamera.org/api/1.1/patches/24448/?format=json","web_url":"https://patchwork.libcamera.org/patch/24448/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250924124713.3361707-3-barnabas.pocze@ideasonboard.com>","date":"2025-09-24T12:47:07","name":"[RFC,v1,2/7] libcamera: base: bound_method: Forward when invoking","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8ea0f91441b05b586adea9ceb0c66846b44ecd36","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24448/mbox/","series":[{"id":5457,"url":"https://patchwork.libcamera.org/api/1.1/series/5457/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5457","date":"2025-09-24T12:47:05","name":"libcamera: camera: Add `applyControls()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5457/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24448/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24448/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8AB7BDB1C\n\tfor ;\n\tWed, 24 Sep 2025 12:47:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A41896B605;\n\tWed, 24 Sep 2025 14:47:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 115BC6B5F0\n\tfor ;\n\tWed, 24 Sep 2025 14:47:17 +0200 (CEST)","from pb-laptop.local (185.221.140.70.nat.pool.zt.hu\n\t[185.221.140.70])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05E1C15E9;\n\tWed, 24 Sep 2025 14:45:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YlHyXQ2P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758717953;\n\tbh=vh+fIL4wFVuH2fOBu8NgwwtpBDP/2tf5eRRCK6gsAeA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YlHyXQ2PF2pRvJdcabAYrsYV6HOXzqpdfM6/BDWuTN21mUI9jppMDuhmhOP9o0jqu\n\tbJw0eKrJwX2qjRL3Dgxnl7lezzQh+kVFP5A6vKE1ET2SBMIH+3c3nlSnHQ/9QG6cyn\n\t0Uq323s0BFBG/LFLEPbT90HF0d3qcPmWrceqN+08=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"[RFC PATCH v1 2/7] libcamera: base: bound_method: Forward when\n\tinvoking","Date":"Wed, 24 Sep 2025 14:47:07 +0200","Message-ID":"<20250924124713.3361707-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","References":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"At the moment a single argument pack is used just once, hence it is safe\nto forward the arguments from the pack, allowing moving to take place\ninstead of copying.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/bound_method.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex cb642e0a9..0552a9f30 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -97,9 +97,9 @@ private:\n \t\t[[maybe_unused]] auto *args = static_cast(pack);\n \n \t\tif constexpr (!std::is_void_v)\n-\t\t\targs->ret_ = invoke(std::get(args->args_)...);\n+\t\t\targs->ret_ = invoke(std::forward>(std::get(args->args_))...);\n \t\telse\n-\t\t\tinvoke(std::get(args->args_)...);\n+\t\t\tinvoke(std::forward>(std::get(args->args_))...);\n \t}\n \n public:\n","prefixes":["RFC","v1","2/7"]}