{"id":24440,"url":"https://patchwork.libcamera.org/api/1.1/patches/24440/?format=json","web_url":"https://patchwork.libcamera.org/patch/24440/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250923190657.21453-2-hansg@kernel.org>","date":"2025-09-23T19:06:53","name":"[1/5] ipa: software_isp: Fix context_.configuration.agc.againMin init","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ce05dd561721d3d83776876150b2dbbc7e6aa19a","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/1.1/people/239/?format=json","name":"Hans de Goede","email":"hansg@kernel.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24440/mbox/","series":[{"id":5455,"url":"https://patchwork.libcamera.org/api/1.1/series/5455/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5455","date":"2025-09-23T19:06:52","name":"ipa: software_isp: AGC: Fox AGC oscillation bug","version":1,"mbox":"https://patchwork.libcamera.org/series/5455/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24440/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24440/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4F78C32A9\n\tfor ;\n\tTue, 23 Sep 2025 19:07:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FB7D6B606;\n\tTue, 23 Sep 2025 21:07:07 +0200 (CEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 252C36B5C4\n\tfor ;\n\tTue, 23 Sep 2025 21:07:03 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 0EF5040A38\n\tfor ;\n\tTue, 23 Sep 2025 19:07:02 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 23BD6C4CEF5;\n\tTue, 23 Sep 2025 19:07:00 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"ADlLHnE1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758654421;\n\tbh=ramw4DO9WLojIiNJYWPw1VXQmGJRsjyRNuX+hJ5G2z4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ADlLHnE1/CBQvWfy+lHfT3LUw14xaqVctWAIthjpDGdHTEP87M8MjzTz7Xfy4XnBh\n\tGOzqEw7BBExkPcEc1NIoygQSoGuEgV9Dnk/h5vA2dpCBIKFz/99S9VS9XOPb/bXCTS\n\tA+PdV8dvL88VPZ/xU48yHdLXle5t8HjW/aBxSOTN0cNNcrujVQSYqFzPOv5zhX40RY\n\tkLv/IBaUlljc6oMq5qmmOKDnbHPSUqvsLHNFBzhLYmIdj2OxsDQpk5/QbPZOQUkONb\n\tyBnOwvxh3MAFe9GsHIzk0p5CIyJhqscHX974cbVpMcCG9kPd8cPedY33Oae9VG9jIo\n\t6bgNRfbjL5EAw==","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans de Goede ","Subject":"[PATCH 1/5] ipa: software_isp: Fix\n\tcontext_.configuration.agc.againMin init","Date":"Tue, 23 Sep 2025 21:06:53 +0200","Message-ID":"<20250923190657.21453-2-hansg@kernel.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250923190657.21453-1-hansg@kernel.org>","References":"<20250923190657.21453-1-hansg@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently context_.configuration.agc.againMin is not initialized\nwhen the control reports a non 0 minumum gain value.\n\nSo far only the againMin == 0 case was handled and\ncontext_.configuration.agc.againMin was left unset otherwise.\n\nSigned-off-by: Hans de Goede \n---\n src/ipa/simple/soft_simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex c94c4cd55..e70439ee5 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -246,7 +246,9 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n \t\t * other) we limit the range of the gain values used.\n \t\t */\n \t\tcontext_.configuration.agc.againMax = againMax;\n-\t\tif (!againMin) {\n+\t\tif (againMin) {\n+\t\t\tcontext_.configuration.agc.againMin = againMin;\n+\t\t} else {\n \t\t\tLOG(IPASoft, Warning)\n \t\t\t\t<< \"Minimum gain is zero, that can't be linear\";\n \t\t\tcontext_.configuration.agc.againMin =\n","prefixes":["1/5"]}