{"id":24436,"url":"https://patchwork.libcamera.org/api/1.1/patches/24436/?format=json","web_url":"https://patchwork.libcamera.org/patch/24436/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250922083712.3364-1-david.plowman@raspberrypi.com>","date":"2025-09-22T08:37:12","name":"ipa: rpi: agc: Allow exposure mode to be updated in auto mode","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1acaba81cc5c8decbd1ea72c62f777655957b005","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24436/mbox/","series":[{"id":5452,"url":"https://patchwork.libcamera.org/api/1.1/series/5452/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5452","date":"2025-09-22T08:37:12","name":"ipa: rpi: agc: Allow exposure mode to be updated in auto mode","version":1,"mbox":"https://patchwork.libcamera.org/series/5452/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24436/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24436/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E91ABDB1C\n\tfor ;\n\tMon, 22 Sep 2025 08:37:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DC076B5F9;\n\tMon, 22 Sep 2025 10:37:18 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A157E6B58E\n\tfor ;\n\tMon, 22 Sep 2025 10:37:15 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id\n\tffacd0b85a97d-3b9edf4cf6cso3507065f8f.3\n\tfor ;\n\tMon, 22 Sep 2025 01:37:15 -0700 (PDT)","from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-464f64ad1b0sm215823005e9.21.2025.09.22.01.37.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Sep 2025 01:37:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"A6az1kz+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1758530235; x=1759135035;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=h3CcS5dzY0ZH6Q0MQGIdueiz+bLH5Mm4iQforFBMD5s=;\n\tb=A6az1kz+fX9k6fypkLeKBd/yhCTnUKTgxqdFLey7EmjE5aLm4z39CFoCjQCWOFhtcL\n\tamZbTQIUt5bgZyhesxo59+ixxaM/8hkIQZFIDHPF3OIB6DLDeyt6QcoXKGB9fwzrWv8A\n\tfs4rjiwT6nflegxHED07nPWPD811fQosYjkcNUY3S8iEb29bAlDm16uSBUDmI12NqL3o\n\tHaqyI6RR4gEXnd6/3m8n6pk3ztudhpkAVzTWuHcc3W1t5mXPq8xj3qCjr/jRiYE7s6/V\n\tj3n5uLnwpt1JWIBsEqJ7SsceyefB2vx/8ShpjPG4dutoRX5L7FwPClasIVLAOaiCiSRO\n\t6Vfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1758530235; x=1759135035;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=h3CcS5dzY0ZH6Q0MQGIdueiz+bLH5Mm4iQforFBMD5s=;\n\tb=eumy6zGqzHarqeYssqvmMBoCtnfi8x65cfBzKXaWmIkjFkI5RkQY1clwlsOWZLSA9n\n\t9W33koi06TMx8y3SJWQT+D+w7cj8TBJhIyjF/gnoTIoPi/WEyv5+VcKEq0rXoI88CTkj\n\ttcFmpRpUPegTEN3P7W2ZTvUA+e4Vjt55FPmKKVz94sOdHXPN4/MDPNZcHAL5uTp4WCg3\n\tmnO1AfCyavkrmvDD6P40Xf02Mrkf8wK8eFaOzfImGzUDelZpgjda5NFvljMJrNy3Zw7Q\n\tEaYoN41HrwGddN1dVW6L7zKce8L7z87zHZj2O6TukCtxPqNtGb3rkF1upG2kxhYpsuLv\n\t1E8Q==","X-Gm-Message-State":"AOJu0YxnnTiZQtgP+vNysxmhqZZZ5D0vjmLeHZw4453M+2VFEyyTBAG6\n\tiLZKxzo7Z/EwlVDP/IFIZIHe0nSjgJPBN4lcOP8rXTFCV2SfkHAQuT73mc/X8S5OE3Rew/GSluN\n\t0O0Ll","X-Gm-Gg":"ASbGncuHyxLsIh/+ITna/BH/v471xIY3yJT7HwIbl0TwXqlLKepxp5ylhCFAl6K5YYy\n\tXXLy2MEKTLhBD1uU6l1A59QwS7EBoNau3nS62rM+sklOftExDKCB0lEcqpJC55f4AhLO9Qsjya1\n\tTUC6EZBjBsOTn8RTacXsBxzRu2JVr9OXuVYHrS8b8+XkH0Pr8/xbU68093sGllSXOBYZ0FciFSq\n\t9prOkSNRHAz6XlagWX4JiWAsUzo6R2C7XH8IZGKh9yjk5dZpME22iG0XelHDMaPq3JTqBbIO0ok\n\t63Ob2ezUlhxLjX8CtNFGP+PWdL/KcTHGuehxN3jUhZ4Ix4WTxPHMa/0MFDKNhANqA6OVmtgVKFv\n\tSfIQszwys7DJghRXTxc2hUEnwNIOJ/NL+MsY8Vlz21xt8nlIFbnzSX+j84i4X+3BKnoMSAEs+AS\n\teVQNCIXS1N94Onj3pa3cR3U9upRbiSt7BQFYgpspwIAF5iroAKTw==","X-Google-Smtp-Source":"AGHT+IFpCwe6wWDypuQATcnzxke7lh/FJdRcApYiI33IImKxZuI82bOLUPXZrJosXYjcg3wNiedfkA==","X-Received":"by 2002:a05:6000:401f:b0:400:818:bae9 with SMTP id\n\tffacd0b85a97d-4000818be40mr795688f8f.32.1758530234615; \n\tMon, 22 Sep 2025 01:37:14 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH] ipa: rpi: agc: Allow exposure mode to be updated in auto\n\tmode","Date":"Mon, 22 Sep 2025 09:37:12 +0100","Message-Id":"<20250922083712.3364-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.5","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The code was only allowing the exposure mode to be updated when both\nexposure/gain were in manual mode, which is a mistake. It needs to be\nupdatable precisely when the auto modes are enabled.\n\nThe fix is to ignore the enabled/disabled status of AEC/AGC, matching\nour other controls (metering mode, constraint mode etc.). While there\nmight be a debate to be had about what the actual behaviour of all\nthese controls should be, for the time being we'll just match\neverything else.\n\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/common/ipa_base.cpp | 7 -------\n 1 file changed, 7 deletions(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 6448e6ab..8dfe35cc 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -1026,13 +1026,6 @@ void IpaBase::applyControls(const ControlList &controls)\n \t\t\t\tbreak;\n \t\t\t}\n \n-\t\t\t/*\n-\t\t\t * Ignore AE_EXPOSURE_MODE if the shutter or the gain\n-\t\t\t * are in auto mode.\n-\t\t\t */\n-\t\t\tif (agc->autoExposureEnabled() || agc->autoGainEnabled())\n-\t\t\t\tbreak;\n-\n \t\t\tint32_t idx = ctrl.second.get();\n \t\t\tif (ExposureModeTable.count(idx)) {\n \t\t\t\tagc->setExposureMode(ExposureModeTable.at(idx));\n","prefixes":[]}