{"id":24431,"url":"https://patchwork.libcamera.org/api/1.1/patches/24431/?format=json","web_url":"https://patchwork.libcamera.org/patch/24431/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250919173709.220881-3-mzamazal@redhat.com>","date":"2025-09-19T17:37:05","name":"[v3,2/6] libcamera: software_isp: Pass correct y-coordinate to stats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"94ac82cb4a06472adc5772d50c69f384c8b3e6db","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24431/mbox/","series":[{"id":5451,"url":"https://patchwork.libcamera.org/api/1.1/series/5451/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5451","date":"2025-09-19T17:37:03","name":"Fix stats related problems in software ISP","version":3,"mbox":"https://patchwork.libcamera.org/series/5451/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24431/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24431/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6160BE173\n\tfor ;\n\tFri, 19 Sep 2025 17:37:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CD206B5A9;\n\tFri, 19 Sep 2025 19:37:36 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F61962C3B\n\tfor ;\n\tFri, 19 Sep 2025 19:37:32 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-595-zMd_IbR7MviDut3tgLZ-vA-1;\n\tFri, 19 Sep 2025 13:37:29 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 33E00180034F; Fri, 19 Sep 2025 17:37:28 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.9])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6E5301800451; Fri, 19 Sep 2025 17:37:26 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AWhSgXYC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758303451;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=nZ0gFy69l3odchIGXnwMc4CAvSP9LesFjEyjR0qsIxo=;\n\tb=AWhSgXYCCZangNoPP1qYDrGuFInE1IJbOYm4aVWgIIpXWhGbJBUEkhftsmdVHKZ07vABe8\n\ty5hRDJTBQmlYL/jb/hZMOY0Nz5SoQ6caPYNTnYUP7FmfM5o02IysLlaSOryrwkwnMmu7sb\n\t2XP08YnTv4SVHIUMKjwALdFqgzPxpjY=","X-MC-Unique":"zMd_IbR7MviDut3tgLZ-vA-1","X-Mimecast-MFC-AGG-ID":"zMd_IbR7MviDut3tgLZ-vA_1758303448","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name","Subject":"[PATCH v3 2/6] libcamera: software_isp: Pass correct y-coordinate to\n\tstats","Date":"Fri, 19 Sep 2025 19:37:05 +0200","Message-ID":"<20250919173709.220881-3-mzamazal@redhat.com>","In-Reply-To":"<20250919173709.220881-1-mzamazal@redhat.com>","References":"<20250919173709.220881-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"I87h5Gbh7SB0iaC29U9VKTmAX0P9bHzYL7TVy5tAJcA_1758303448","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The window set by SwStatsCpu::setWindow is relative to the processed\nimage area. But debayering passes the processed line y-coordinate to\nthe stats relative to the whole image area. This can result in\ngathering stats from a wrong image area or in not gathering stats at\nall.\n\nLet's pass the correct y-coordinate to the stats processing methods.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=280\nSigned-off-by: Maciej S. Szmigiero \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/debayer_cpu.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex bcc847ae6..185edd814 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -648,7 +648,7 @@ void DebayerCpu::memcpyNextLine(const uint8_t *linePointers[])\n \n void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n {\n-\tunsigned int yEnd = window_.y + window_.height;\n+\tunsigned int yEnd = window_.height;\n \t/* Holds [0] previous- [1] current- [2] next-line */\n \tconst uint8_t *linePointers[3];\n \n@@ -664,12 +664,12 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n \t\tlinePointers[1] = src + inputConfig_.stride;\n \t\tlinePointers[2] = src;\n \t\t/* Last 2 lines also need special handling */\n-\t\tyEnd -= 2;\n+\t\tyEnd = (yEnd > 2 ? yEnd - 2 : 0);\n \t}\n \n \tsetupInputMemcpy(linePointers);\n \n-\tfor (unsigned int y = window_.y; y < yEnd; y += 2) {\n+\tfor (unsigned int y = 0; y < yEnd; y += 2) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n \t\tstats_->processLine0(y, linePointers);\n@@ -703,7 +703,7 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n \n void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n {\n-\tconst unsigned int yEnd = window_.y + window_.height;\n+\tconst unsigned int yEnd = window_.height;\n \t/*\n \t * This holds pointers to [0] 2-lines-up [1] 1-line-up [2] current-line\n \t * [3] 1-line-down [4] 2-lines-down.\n@@ -721,7 +721,7 @@ void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n \n \tsetupInputMemcpy(linePointers);\n \n-\tfor (unsigned int y = window_.y; y < yEnd; y += 4) {\n+\tfor (unsigned int y = 0; y < yEnd; y += 4) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n \t\tstats_->processLine0(y, linePointers);\n","prefixes":["v3","2/6"]}