{"id":24358,"url":"https://patchwork.libcamera.org/api/1.1/patches/24358/?format=json","web_url":"https://patchwork.libcamera.org/patch/24358/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250912142915.53949-8-mzamazal@redhat.com>","date":"2025-09-12T14:29:08","name":"[v18,06/12] libcamera: camera_manager: Look up pipelines match list in configuration file","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"91e2df25ba01a668e3b1cac4cd016174519878ef","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24358/mbox/","series":[{"id":5442,"url":"https://patchwork.libcamera.org/api/1.1/series/5442/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5442","date":"2025-09-12T14:29:08","name":null,"version":18,"mbox":"https://patchwork.libcamera.org/series/5442/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24358/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24358/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E4D7BDB13\n\tfor ;\n\tFri, 12 Sep 2025 14:29:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36E8A6937E;\n\tFri, 12 Sep 2025 16:29:51 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AF3569381\n\tfor ;\n\tFri, 12 Sep 2025 16:29:49 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-617-i20orPy0Na6xm4YWjDnatw-1;\n\tFri, 12 Sep 2025 10:29:44 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id CADD31800350; Fri, 12 Sep 2025 14:29:43 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.48])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 55AA31800447; Fri, 12 Sep 2025 14:29:41 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"buzOxniJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1757687388;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=H3jcKiFYLN2reP9etT547s3KTsnb35JwU340uIEJEsg=;\n\tb=buzOxniJY51oTlrlx+XL+ogFa6B+jCOInppTnE1BvDChgba9gxvXkgXPwtic1+/Ou1dQOn\n\trb6+8zRVuqHJ37n38qThJhkx8wKJBSsJc9MSt7kERo20WNF6MH3j4GX75EDT3v4Aalv+3A\n\tf0MkwcYc522ObVc8PG3JKNdrKmobHSw=","X-MC-Unique":"i20orPy0Na6xm4YWjDnatw-1","X-Mimecast-MFC-AGG-ID":"i20orPy0Na6xm4YWjDnatw_1757687383","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t, Paul Elder\n\t","Subject":"[PATCH v18 06/12] libcamera: camera_manager: Look up pipelines match\n\tlist in configuration file","Date":"Fri, 12 Sep 2025 16:29:08 +0200","Message-ID":"<20250912142915.53949-8-mzamazal@redhat.com>","In-Reply-To":"<20250912142915.53949-1-mzamazal@redhat.com>","References":"<20250912142915.53949-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"AzdmxFPj1MhCIrSEKlpMOf055T3DJLVYmRNT7qnviq4_1757687383","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's add a configuration file item for the pipelines match list.\n\nThe configuration snippet:\n\n configuration:\n pipelines_match_list: rkisp1,simple\n\nReviewed-by: Paul Elder \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/camera_manager.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 64df62444..c203b08f7 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -111,14 +111,16 @@ void CameraManager::Private::createPipelineHandlers()\n \t * file and only fallback on environment variable or all handlers, if\n \t * there is no configuration file.\n \t */\n-\tconst char *pipesList =\n-\t\tutils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n-\tif (pipesList) {\n+\tconst auto pipesList =\n+\t\tconfiguration().envListOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n+\t\t\t\t\t { \"pipelines_match_list\" },\n+\t\t\t\t\t \",\");\n+\tif (pipesList.has_value()) {\n \t\t/*\n \t\t * When a list of preferred pipelines is defined, iterate\n \t\t * through the ordered list to match the enumerated devices.\n \t\t */\n-\t\tfor (const auto &pipeName : utils::split(pipesList, \",\")) {\n+\t\tfor (const auto &pipeName : pipesList.value()) {\n \t\t\tconst PipelineHandlerFactoryBase *factory;\n \t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n \t\t\tif (!factory)\n","prefixes":["v18","06/12"]}