{"id":24349,"url":"https://patchwork.libcamera.org/api/1.1/patches/24349/?format=json","web_url":"https://patchwork.libcamera.org/patch/24349/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250912125528.1963619-1-barnabas.pocze@ideasonboard.com>","date":"2025-09-12T12:55:27","name":"[RFC,v2,1/2] py: gen-py-formats.py: Open input file in binary mode","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7073e789d7e20be460aae72466f1947fd007a027","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24349/mbox/","series":[{"id":5440,"url":"https://patchwork.libcamera.org/api/1.1/series/5440/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5440","date":"2025-09-12T12:55:27","name":"[RFC,v2,1/2] py: gen-py-formats.py: Open input file in binary mode","version":2,"mbox":"https://patchwork.libcamera.org/series/5440/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24349/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24349/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2890C324E\n\tfor ;\n\tFri, 12 Sep 2025 12:55:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B95FC69367;\n\tFri, 12 Sep 2025 14:55:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 408FA69367\n\tfor ;\n\tFri, 12 Sep 2025 14:55:34 +0200 (CEST)","from pb-laptop.local (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EF1FC6E;\n\tFri, 12 Sep 2025 14:54:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uoUJzZQi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757681658;\n\tbh=e/G19yM/wrBv1C/0sDFJW6ys5NsuwKRGFiM/Jkf3xSQ=;\n\th=From:To:Subject:Date:From;\n\tb=uoUJzZQiFBVsOxmfouSI6a9T+H9TA6EnCfZ1hZud8BKEi17vpgDtY6DcSSNopwmzv\n\tjv23HlQfwXk/wrtb4DdQNBwT5PRNx5rMA8jjx5zp18ik2Hb2ggJs/+3PWwvrXrT7+b\n\tVCmUP7faboFfT6XvNyPVkRcsKLclkgz67j5R/lG4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v2 1/2] py: gen-py-formats.py: Open input file in binary\n\tmode","Date":"Fri, 12 Sep 2025 14:55:27 +0200","Message-ID":"<20250912125528.1963619-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Other code generation scripts do that already and let pyyaml deal with\ndecoding utf-8, etc. So do the same here as well.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/py/libcamera/gen-py-formats.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/py/libcamera/gen-py-formats.py b/src/py/libcamera/gen-py-formats.py\nindex 0ff1d12ac..6323e237f 100755\n--- a/src/py/libcamera/gen-py-formats.py\n+++ b/src/py/libcamera/gen-py-formats.py\n@@ -37,7 +37,7 @@ def main(argv):\n help='Template file name.')\n args = parser.parse_args(argv[1:])\n \n- with open(args.input, encoding='utf-8') as f:\n+ with open(args.input, 'rb') as f:\n formats = yaml.safe_load(f)['formats']\n \n data = generate(formats)\n","prefixes":["RFC","v2","1/2"]}