{"id":2432,"url":"https://patchwork.libcamera.org/api/1.1/patches/2432/?format=json","web_url":"https://patchwork.libcamera.org/patch/2432/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191217015106.1175515-2-niklas.soderlund@ragnatech.se>","date":"2019-12-17T01:51:04","name":"[libcamera-devel,v2,1/3] libcamera: utils: Add exchange()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"83d2430f5f2962721231776d333aedf7044a713d","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/1.1/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/2432/mbox/","series":[{"id":590,"url":"https://patchwork.libcamera.org/api/1.1/series/590/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=590","date":"2019-12-17T01:51:03","name":"libcamera: Add FileDescriptor to help pass numerical fds around","version":2,"mbox":"https://patchwork.libcamera.org/series/590/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2432/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2432/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B484601ED\n\tfor ;\n\tTue, 17 Dec 2019 02:51:17 +0100 (CET)","from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de\n\t[84.172.88.101]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid b6548959-206f-11ea-a00b-005056917a89;\n\tTue, 17 Dec 2019 02:51:16 +0100 (CET)"],"X-Halon-ID":"b6548959-206f-11ea-a00b-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 17 Dec 2019 02:51:04 +0100","Message-Id":"<20191217015106.1175515-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.24.0","In-Reply-To":"<20191217015106.1175515-1-niklas.soderlund@ragnatech.se>","References":"<20191217015106.1175515-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/3] libcamera: utils: Add exchange()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Dec 2019 01:51:17 -0000"},"content":"C++11 does not support std::exchange(), add a custom implementation in\nutils.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/include/utils.h | 9 +++++++++\n src/libcamera/utils.cpp | 8 ++++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex a80f7d096bf725a1..32e3b009040d9efc 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -66,6 +66,15 @@ const T& clamp(const T& v, const T& lo, const T& hi)\n \treturn std::max(lo, std::min(v, hi));\n }\n \n+/* C++11 doesn't provide std::exchange */\n+template\n+T exchange(T &obj, U &&new_value)\n+{\n+\tT old_value = std::move(obj);\n+\tobj = std::forward(new_value);\n+\treturn old_value;\n+}\n+\n using clock = std::chrono::steady_clock;\n using duration = std::chrono::steady_clock::duration;\n using time_point = std::chrono::steady_clock::time_point;\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex d632f6e66638038d..6ebb4e8ce39010c0 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -95,6 +95,14 @@ char *secure_getenv(const char *name)\n * \\return lo if v is less than lo, hi if v is greater than hi, otherwise v\n */\n \n+/**\n+ * \\fn libcamera::utils::exchange(T &obj, U &&new_value)\n+ * \\brief Replace the value of \\a obj with \\a new_value and return the old value\n+ * \\param[inout] obj Object whose value to replace\n+ * \\param[in] new_value The value to assign to obj\n+ * \\return The old value of \\a obj\n+ */\n+\n /**\n * \\typedef clock\n * \\brief The libcamera clock (monotonic)\n","prefixes":["libcamera-devel","v2","1/3"]}