{"id":24226,"url":"https://patchwork.libcamera.org/api/1.1/patches/24226/?format=json","web_url":"https://patchwork.libcamera.org/patch/24226/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250825114219.562831-6-paul.elder@ideasonboard.com>","date":"2025-08-25T11:42:07","name":"[v4,5/8] libcamera: camera_manager: Add LayerManager","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2da55ea54498afda3ccc03f4efdfab49da55e339","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24226/mbox/","series":[{"id":5401,"url":"https://patchwork.libcamera.org/api/1.1/series/5401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5401","date":"2025-08-25T11:42:02","name":"Add Layers support","version":4,"mbox":"https://patchwork.libcamera.org/series/5401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24226/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24226/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF843BEFBE\n\tfor ;\n\tMon, 25 Aug 2025 11:42:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 486D7692F8;\n\tMon, 25 Aug 2025 13:42:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB70B692F6\n\tfor ;\n\tMon, 25 Aug 2025 13:42:43 +0200 (CEST)","from neptunite.infra.iob (unknown\n\t[IPv6:2404:7a81:160:2100:39d7:37aa:64a2:5533])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00A2B50F1;\n\tMon, 25 Aug 2025 13:41:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QdIwxJBJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1756122101;\n\tbh=wSSMJBdlEBL4TbRooTIgPhzLl8gvws/0R+TMA7OQiFY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QdIwxJBJ7UoESIxKnYtb5KlsGlNVsV0QvGX+qduEzAehMhGUbPDu15z6WMfkf3VEM\n\t9WMEzyKOtO+QGanqshVlexieRo5ox5ghPlAcJG110dGq3pDUEzl/+f0AnfuC6B5zaP\n\tzer1gbcYR3qPXCW7/mL0ctgOwjs4HaIkogGWaw5k=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder , kieran.bingham@ideasonboard.com,\n\tstefan.klug@ideasonboard.com, barnabas.pocze@ideasonboard.com","Subject":"[PATCH v4 5/8] libcamera: camera_manager: Add LayerManager","Date":"Mon, 25 Aug 2025 20:42:07 +0900","Message-ID":"<20250825114219.562831-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.47.2","In-Reply-To":"<20250825114219.562831-1-paul.elder@ideasonboard.com>","References":"<20250825114219.562831-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add to the CameraManager a LayerManager member. This allows us to have\none LayerManager that handles loading all the layer shared objects, and\nthen each Camera can access the layer via the LayerManager via through\nthe CameraManager.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \n\n---\nChanges in v4:\n- Put LayerManager directly in CameraManager, as opposed to a unique\n pointer\n\nNo change in v3\n\nNew in v2\n---\n include/libcamera/internal/camera_manager.h | 3 +++\n src/libcamera/camera_manager.cpp | 1 +\n 2 files changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\nindex 5dfbe1f6546c..ff4197f47acb 100644\n--- a/include/libcamera/internal/camera_manager.h\n+++ b/include/libcamera/internal/camera_manager.h\n@@ -18,6 +18,7 @@\n #include \n #include \n \n+#include \"libcamera/internal/layer_manager.h\"\n #include \"libcamera/internal/process.h\"\n \n namespace libcamera {\n@@ -39,6 +40,7 @@ public:\n \tvoid removeCamera(std::shared_ptr camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n \n \tIPAManager *ipaManager() const { return ipaManager_.get(); }\n+\tconst LayerManager *layerManager() const { return &layerManager_; }\n \n protected:\n \tvoid run() override;\n@@ -65,6 +67,7 @@ private:\n \tstd::unique_ptr enumerator_;\n \n \tstd::unique_ptr ipaManager_;\n+\tLayerManager layerManager_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex f81794bfd6fe..a2505a5a12a3 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -15,6 +15,7 @@\n \n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/layer_manager.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n","prefixes":["v4","5/8"]}