{"id":24218,"url":"https://patchwork.libcamera.org/api/1.1/patches/24218/?format=json","web_url":"https://patchwork.libcamera.org/patch/24218/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-36-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:48","name":"[v2,36/37] libcamera: software_isp: Add a gpuisp todo list","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9550db37061d9cb82d183fde85174160e2b4b53d","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24218/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/1.1/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24218/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24218/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE968BEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:49:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D9CB69342;\n\tSun, 24 Aug 2025 02:49:46 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2646069329\n\tfor ;\n\tSun, 24 Aug 2025 02:49:10 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-45a1b0c82eeso27029845e9.3\n\tfor ;\n\tSat, 23 Aug 2025 17:49:10 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.49.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:49:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XZkdN03+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996549; x=1756601349;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=DTTcwJfG7ak8JDbsC+gvp8t3BtyZQS47SSilc/BHVNE=;\n\tb=XZkdN03+Qy7eNNNE2y0OgCOvuFCRkJFKhlD90YkwW4KuJt02eZ94BzYh518sdjWVIo\n\tBhYU3A6H+cAH3PQZS2WqzH4WmZo8Usr+k0wQJObkri48UemwxhYP4wDa0s7pcRWuc2PN\n\t88U2zF4DZIbOIuVSnTgUODaO+8YJuTDQRhxWGRpGZw9+BIeki4nNddEYsz4rd5QCj0S4\n\tU/RbwBAuaID4OXtHgHvbA4NA9aR+8gXcErWRnxTuocHN/ltnJAdgFIlPgmJswxGpOLaH\n\tjfTs7itXmf/DJNQkS7/UdfQcNz6HNoc96c72m1E14yrh60c5dE6fbRHPzhQ16OezcmyA\n\tGyhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996549; x=1756601349;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=DTTcwJfG7ak8JDbsC+gvp8t3BtyZQS47SSilc/BHVNE=;\n\tb=tQA1DoCWQNfxP1n24/3QCGGZn6VkKDPw4u4qpzGLkcosgsE9mH9BfWs9zqf9uQ10pX\n\ti4vg9/GpE1Rpcml4wL+1Of1WMJOC/kU/QwGHp1xXeZ+E6/X2tyeXe15/E4vAef+WizuD\n\t0i1lWUAc3p30xmTpv0xoBojxXAC6UodtVlviGmoqHfRIQnR/IX2/PYOrfVJM6L+FlCrc\n\t2NWL+njAd3ewIEg7G6ko09oFNvm/sg+HPHvaWkoqMJBJ+wCH+wue4bZ/4v9GW4M0bJ0Z\n\t7S6YhPl27t6eiweN3WFS1RZ6zJ6vRoWdRomQ0EKAOVOQ1pc4/GagZ6hjbc6lhT08rgRp\n\tCwpQ==","X-Gm-Message-State":"AOJu0Ywr3h1XiGRX4IVblsTEA3oPoZ/9ao2tvEQRzqLPt22Q0zStEDoP\n\t4zWR3ajWFq+LmjzBPSRAChfOn+z02DCa1UKtwrCAveCAc48j5TlHq1LM3qRK0+hIm3pvXLp3lCo\n\tw0MtQMnA=","X-Gm-Gg":"ASbGncubyNDk4EKbPcgs9Ew8fGGlS4p5rNUd3x2tiAHN1h5ePB57Pu06i9NhBldNjEm\n\tBW9KHzwNbYtb8y3uvw90Wwgb/F+MsawRzU+SGFSve9rr/JQk6Xa95HutdvnayD/Ac7LOfP7+1hm\n\tAZMoLInCjVvK0zokwqsIQ6+cEynT+IOkWFJwNntBD0Y8j1z+xYUDkVzUmqvaqBCQyo4xDO81JSq\n\t5KS28BnVsGmsjRTDCenuLu6BcGtx3M8AcOTK2FUkxsu85ucJkpAWkZM9/pFvrgEaA/B1msCpxpK\n\tCxRloavGRA892efnyLm8bx/mMk6q14TFnM7zKLKwaj2XS0P7bx1U69eDk9nY+8q16nuWnqaKjYQ\n\t6IRS5GT5vtTphqY8f/BxgAO+anBFp916VmiqnqwThz+dnDiXOjDtb+ut3hkNuqryPw/RayXvpoO\n\t9AcSHb2N04wlv9eLbsYMiv","X-Google-Smtp-Source":"AGHT+IHxExngAvTts5eFr72F2OqlFav1cKsrzg4+O3442fpQkH5wQYkFeve3xd3u2gXQf1X/k4qs+w==","X-Received":"by 2002:a05:600c:3b2a:b0:453:2066:4a26 with SMTP id\n\t5b1f17b1804b1-45b5179f3d1mr90594065e9.16.1755996549319; \n\tSat, 23 Aug 2025 17:49:09 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:48 +0100","Subject":"[PATCH v2 36/37] libcamera: software_isp: Add a gpuisp todo list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-36-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3052;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=fkjJdxpwJCUqkX+i6uEWQGqq/pTEpLO+hSigKW03abk=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFifMwU/iPZVmSeEQPpeXThnFXdg8dMtnCoN\n\toL0+CMes5GJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYgAKCRAicTuzoY3I\n\tOkhFEACT/4I0D0wz+IL3JLsvDp88MQU2iTV8CpoqWWLi2fHPnZSPlwm+7FaAtYjELHFvw8BnUuI\n\tB1GUTenXy4GzWB5D3h/kcVIqQ70qyASAdvf8O7EAQAyc9roHtnoiwERo9HKxFruwnYE9+sxqgoA\n\toAF3/VMzYtNbFqT2+jFDpSlzhmfFlblDLEmg7QGCIroJBRLGck0+RAiom284erBdApIRKMhKu1A\n\tcO0ix4kphZRsZ2ETN29F+WKca02r2ndqYFfryj4nnkyl2zUHFoFYaCqGIIKKhqDVxKG/5PdwImA\n\tNYu5IRwbcyDut3vB0eKg9XAzAkwKvAM68RKYRCZ6SdTXfSYyxdBBUb6KXXy2n7bTMrL26DJ2HHo\n\tsEyyChkV/F3ik+UVhmU5A8f6/UrTdGwJoWU6gZO6LrxelGGHHtA05sR1URXBe0PL+GhHgpYPhos\n\twT1pUUpGd8/fF1mOMPyzlAag+RXhJEIHlqHId7nNKX9DMRUrcrSxC4t5z5WY7v1tLcIQs9c68T8\n\tHQRXFWB3cTTna5f6zxGFCkOruSkeRpZv0Z2VralO8Ml35iFsgnKP2tTbYow3EHwRe7drShKe+ri\n\tZ1Eicw+GL4hIKIglTRVTuIHKMYe9YdlEVQmIWyzoYizCNod1KvDdE5UA/Vm4pXQO0/qvcjtNoFf\n\trCQRtmRV5I5u8tg==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/gpuisp-todo.txt | 61 ++++++++++++++++++++++++++++++\n 1 file changed, 61 insertions(+)","diff":"diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..d283959c3ee2864f8ec3534107938505ae858c61\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,61 @@\n+List the TODOs in perceived order of ease.\n+\n+Version 2:\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Denoising:\n+\t- Run a denoise algorithm in the shaders\n+\t- Supply a control to influence the noise-floor ?\n+\n+Dead pixel correction:\n+\t- Add logic to correct dead pixels in the fragment shaders\n+\n+Version 1:\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\t- Version 2:\n+\t This is not possible.\n+\t gl_FragColor expects vec4 not vec3 on the output.\n+\t If you really want RGB888 run cpuisp.\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\t- Version 2:\n+\t Complete GBM surface removed, memcpy() phase removed also\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\t- Version 2:\n+\t Complete sm8250 test platform shows 20x performance increase\n+\t with CCM.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\t- Version 2:\n+\t Done in version 2\n","prefixes":["v2","36/37"]}