{"id":2421,"url":"https://patchwork.libcamera.org/api/1.1/patches/2421/?format=json","web_url":"https://patchwork.libcamera.org/patch/2421/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191209163446.32381-11-jacopo@jmondi.org>","date":"2019-12-09T16:34:46","name":"[libcamera-devel,v3,10/10] cam: Add option to list camera properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bf6562ded5c006511800b86fb3e8b1fa8576a340","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2421/mbox/","series":[{"id":586,"url":"https://patchwork.libcamera.org/api/1.1/series/586/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=586","date":"2019-12-09T16:34:36","name":"Introduce libcamera properties","version":3,"mbox":"https://patchwork.libcamera.org/series/586/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2421/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2421/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C97461D5A\n\tfor ;\n\tMon, 9 Dec 2019 17:32:48 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0D8611C000E;\n\tMon, 9 Dec 2019 16:32:47 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 9 Dec 2019 17:34:46 +0100","Message-Id":"<20191209163446.32381-11-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.24.0","In-Reply-To":"<20191209163446.32381-1-jacopo@jmondi.org>","References":"<20191209163446.32381-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 10/10] cam: Add option to list camera\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 09 Dec 2019 16:32:48 -0000"},"content":"Add the '-p'|'--list-properties' option to the cam application to list\nthe properties of a camera.\n\nSigned-off-by: Jacopo Mondi \n---\n src/cam/main.cpp | 50 ++++++++++++++++++++++++++++++++++++++++++++++++\n src/cam/main.h | 1 +\n 2 files changed, 51 insertions(+)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex a38cca959aca..41aedea3ab17 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -11,6 +11,7 @@\n #include \n \n #include \n+#include \n \n #include \"capture.h\"\n #include \"event_loop.h\"\n@@ -36,6 +37,7 @@ public:\n private:\n \tint parseOptions(int argc, char *argv[]);\n \tint prepareConfig();\n+\tint listProperties();\n \tint infoConfiguration();\n \tint run();\n \n@@ -180,6 +182,7 @@ int CamApp::parseOptions(int argc, char *argv[])\n \tparser.addOption(OptInfo, OptionNone,\n \t\t\t \"Display information about stream(s)\", \"info\");\n \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n+\tparser.addOption(OptProps, OptionNone, \"List cameras properties\", \"list-properties\");\n \n \toptions_ = parser.parse(argc, argv);\n \tif (!options_.valid())\n@@ -268,6 +271,47 @@ int CamApp::prepareConfig()\n \treturn 0;\n }\n \n+int CamApp::listProperties()\n+{\n+\tif (!camera_) {\n+\t\tstd::cout << \"Cannot list properties without a camera\"\n+\t\t\t << std::endl;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tconst ControlList &properties = camera_->properties();\n+\tfor (const auto &prop : properties) {\n+\t\tunsigned int id = prop.first;\n+\t\tconst auto &ctrlId = properties::properties.find(id);\n+\t\tconst ControlId *ctrl = ctrlId->second;\n+\t\tconst ControlValue &value = prop.second;\n+\n+\t\tstd::cout << \"Property: \" << ctrl->name() << \" = \";\n+\n+\t\tswitch (ctrl->type()) {\n+\t\tcase ControlTypeBool: {\n+\t\t\tbool val = value.get();\n+\t\t\tstd::cout << (val ? \"True\" : \"False\") << std::endl;\n+\t\t\tbreak;\n+\t\t}\n+\t\tcase ControlTypeInteger32: {\n+\t\t\tint32_t val = value.get();\n+\t\t\tstd::cout << val << std::endl;\n+\t\t\tbreak;\n+\t\t}\n+\t\tcase ControlTypeInteger64: {\n+\t\t\tint64_t val = value.get();\n+\t\t\tstd::cout << val << std::endl;\n+\t\t\tbreak;\n+\t\t}\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n int CamApp::infoConfiguration()\n {\n \tif (!config_) {\n@@ -312,6 +356,12 @@ int CamApp::run()\n \t\t}\n \t}\n \n+\tif (options_.isSet(OptProps)) {\n+\t\tret = listProperties();\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n \tif (options_.isSet(OptInfo)) {\n \t\tret = infoConfiguration();\n \t\tif (ret)\ndiff --git a/src/cam/main.h b/src/cam/main.h\nindex 0997476bb335..afcad4353b7d 100644\n--- a/src/cam/main.h\n+++ b/src/cam/main.h\n@@ -14,6 +14,7 @@ enum {\n \tOptHelp = 'h',\n \tOptInfo = 'I',\n \tOptList = 'l',\n+\tOptProps = 'p',\n \tOptStream = 's',\n };\n \n","prefixes":["libcamera-devel","v3","10/10"]}