{"id":24204,"url":"https://patchwork.libcamera.org/api/1.1/patches/24204/?format=json","web_url":"https://patchwork.libcamera.org/patch/24204/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-22-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:34","name":"[v2,22/37] libcamera: software_isp: gbm: Add in a GBM helper class for GPU surface access","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6fcfd7d3359aa344f47abf2204271dadc36c782a","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24204/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/1.1/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24204/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24204/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C09DBEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:49:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FFB269312;\n\tSun, 24 Aug 2025 02:49:23 +0200 (CEST)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7887A69317\n\tfor ;\n\tSun, 24 Aug 2025 02:48:56 +0200 (CEST)","by mail-wr1-x430.google.com with SMTP id\n\tffacd0b85a97d-3c79f0a5b8bso660159f8f.1\n\tfor ;\n\tSat, 23 Aug 2025 17:48:56 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"wagop2wE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996536; x=1756601336;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=Kn95fqpa0M3VlH/ov1S+PHQQo16NVdFOXN/7e6MZaAs=;\n\tb=wagop2wEfAAM3vlTHIe8E5vNTOLQfLARlsBH5naFejBdAsUbHeT6hnZQ5SQhXFHCEj\n\t7qxMtZhzstjd03HOnGy/r+a1gUIcYqHsXx4mhH8QS18dXNbobt5WEED8r2OMKvjjbJK8\n\tfK3CZcAzZW9n7JRDi3/aX2tpJ6Bt/SubLObtdTFjiri9bH31WFBsLfTtW8x2yO+pE/+W\n\t3aXQ+6JZDtCG5dkaoIEAZePv6JLmsB5f4fBEtxeVscMwFTSKV/U8bytFt4oskr0uH+oA\n\tJWAQ32MZxffnMAAxfY/JteLAi6UBOEmKRBZ0BZTspfaXfzsu+E2lk69rh3MQKZuafGAS\n\tZKHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996536; x=1756601336;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Kn95fqpa0M3VlH/ov1S+PHQQo16NVdFOXN/7e6MZaAs=;\n\tb=Wwc8UCt1I+lud5dU0rgURSGf0WYtPdEdLHdlL4rPC0ZYDBkd9WhD9yW+DuZQ+OzffD\n\tljpWylRsvBkSpks+qVvFjuttPKaxcxnvyf0up+V/K+j23CS1XdCKwG0TrJq2mqT8d5kv\n\txWK7YbkbZbdCb7tpj+KpS95DTreWbVN4kVRUilzcIlVBfWxRrJ6px90w2ELyGZ1QfvOh\n\tsvR77zbqs3/XnNQU9ZS6O9Psarcd555P9VtHGZdWgPVmDwpUe42U7r2eispzuTrMzbUr\n\tHR2L1MneGC5vmxaqnVDUSLAjop1kTgxdLSv94CFkoVX5QrY/lmJXqKzBY0dIbihciEeo\n\tB/rA==","X-Gm-Message-State":"AOJu0Yy534JyjiVd3MsO7N1/Fz4vb09qwiEPL3E7mdt7Ffi+AMhAnI8J\n\t7nbFf564gtiwvDdFNJevemziuNM5Bb0VCmjo1Hfo9B4ddtu31NNGK7c/mNjqFXRMEUd0UEkDVlO\n\tglpcgudU=","X-Gm-Gg":"ASbGncuO+T+JOKZxXRJzpNti/9hRzuZN6Qex7LN/7jMBVzTUKIws9tY1mnWMDWwwtWL\n\t9m4/doQBJF6CIA3V7xItTJpWZsJrIjnV4tAAi2ihprg88CFopd1/dX5qbIRhJRCfxNnMOcEzRvD\n\tqbvV8+rmR/V8E+vf9JgzY8+WN5Sz4FcfdyhKjvqIYFSdDtQRc9ag9uNi+Er5yYqiK3yYIosQ5GV\n\tV7Y0GYB2vywxyFNe3UBce8bgXuU6va17XL5qK+krNBUNPEddpSF/snDCAS2UVdNW13lSPgK0JF2\n\t+0c/feq+oihQusnHU000xtoqJsuQjXkxmwSaf7MThxuYV1qDp+b79ubPBmvRc7bPS60ghpvahwj\n\t5IYm8R5hMsR2+vLfMyMdN0P/w29RkzSomDRP0JUqbqk/V4YOkRRe3lPZ3A4pSqQHG1H/95UBuq6\n\trrkKXZagZ087kuw6r73l2InF0N7sJFo9M=","X-Google-Smtp-Source":"AGHT+IHHL3bDAY4Rrw3j94OMpBcONvwEGj8WSUdXtO01KObhnqwoJ6IY8zCws4t9foTcUhqNUsGJVw==","X-Received":"by 2002:a05:6000:2211:b0:3b9:7bea:14da with SMTP id\n\tffacd0b85a97d-3c5dcdfd479mr5160578f8f.29.1755996535948; \n\tSat, 23 Aug 2025 17:48:55 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:34 +0100","Subject":"[PATCH v2 22/37] libcamera: software_isp: gbm: Add in a GBM helper\n\tclass for GPU surface access","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-22-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4346;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=egsSMfvlLEe6bXc52sk6IMnd2gt0PPvVs9ZsgHzSO90=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFg1GoWTLssI0JidAMdp2Ruvm9b7J1y7yS4C\n\tmfpfmkZnwuJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYAAKCRAicTuzoY3I\n\tOtdPD/92DrNp7bLmefiMO7HIqCjzcBRjpPkt1PrQXqqnFAFo+ndKr3z7J1t6PKjj28/6kodO+3R\n\t5QYVm6wTH0gCRBYCGKc/EipFYOe+gMBaBlrB6zwBNFg0uZIHPJJGzNHXtDVRPE37S2pU+NNMY3P\n\tRWOrn00B1h5tpH7L4n0lMgayc2ziQ8+MDZDlCFaEDeO1ZZb79NNBli7nIOTIHv+Zwr6fcTGicd0\n\tgSIwTjOmnby3rszaOou3F7P9CBUivf3YoyvSO3gc1O4dKMbGH/iwamI5pBqgpuJTDU+xqcPgKnr\n\tqLYgFjLeqjKmK/6XLNr5SI8yR2lFACpFEuZrlPSyvwLtcF6odSDQ4RR59rdEzTLzsDsmHtumnxl\n\tc7nUkwLDZMbigiC8iYTJ+BJVikciiMyuFWuvz5eZvXaYB22WDmdJMSOY1Osgn5+pErIcPFzQLo1\n\t6pZF1CWpXU0cmNcI+bWvpl+VDTiqBtYu32VCZCczi3xG+iCTXax5U8h4fnbsB6NEvINureEQo4B\n\tlX0W9HI5sTLWwX5aCD0mWEa2Ef0I6KSS2CknRpmUCNNn1b/9qx50A940nhyi9tVwl5/1zclZFrp\n\tS/PUPO+ZhY8CeqHCG6NU8uNwVhFXu0Ysk7vsq8DH9zdh74kB3h0SaahPqNjsUPFeF56x8o+tNkS\n\tfaHEx28BWTjlXVQ==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A helper class to interact with GBM. This will allow us to specify the\ninternal storage format of the CPU when making a texture for the Debayer\nvertext/fragment shaders and thus ensure we receive an uncompressed and\nuntiled output buffer.\n\nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/gbm.h | 39 ++++++++++++++++++++++\n include/libcamera/internal/meson.build | 1 +\n src/libcamera/gbm.cpp | 61 ++++++++++++++++++++++++++++++++++\n src/libcamera/meson.build | 11 ++++++\n 4 files changed, 112 insertions(+)","diff":"diff --git a/include/libcamera/internal/gbm.h b/include/libcamera/internal/gbm.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..ccf7b2da54eebb1b69a5b7c050eed778c199ac8f\n--- /dev/null\n+++ b/include/libcamera/internal/gbm.h\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * gbm.h - Helper class for managing GBM interactions.\n+ */\n+\n+#pragma once\n+\n+#include \n+\n+#include \n+\n+#include \n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(GBM)\n+\n+class GBM\n+{\n+public:\n+\tGBM();\n+\t~GBM();\n+\n+\tint createDevice();\n+\tstruct gbm_device *getDevice() { return gbm_device_; }\n+\tPixelFormat getPixelFormat() { return format_; }\n+\n+private:\n+\tint fd_;\n+\tstruct gbm_device *gbm_device_;\n+\tPixelFormat format_;\n+};\n+\n+} // namespace libcamera\ndiff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 90155857e44fc64803df5b5a054ad62e48b8e2f5..6c65254ddd95fbe9cbb6dadafc0826226b895a7f 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -24,6 +24,7 @@ libcamera_internal_headers = files([\n 'dma_buf_allocator.h',\n 'formats.h',\n 'framebuffer.h',\n+ 'gbm.h',\n 'ipa_data_serializer.h',\n 'ipa_manager.h',\n 'ipa_module.h',\ndiff --git a/src/libcamera/gbm.cpp b/src/libcamera/gbm.cpp\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..caf9ca1c742ce3269ec10f0b6394f9821dabd932\n--- /dev/null\n+++ b/src/libcamera/gbm.cpp\n@@ -0,0 +1,61 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * egl.cpp - Helper class for managing GBM interactions.\n+ */\n+\n+#include \"libcamera/internal/gbm.h\"\n+\n+#include \n+#include \n+#include \n+#include \n+\n+#include \n+#include \n+\n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(GBM)\n+\n+GBM::GBM()\n+{\n+\tfd_ = 0;\n+}\n+\n+GBM::~GBM()\n+{\n+\tif (gbm_device_)\n+\t\tgbm_device_destroy(gbm_device_);\n+\n+\tif (fd_ >= 0)\n+\t\tclose(fd_);\n+}\n+\n+int GBM::createDevice()\n+{\n+\tconst char *dri_node = \"/dev/dri/renderD128\"; //TODO: get from an env or config setting\n+\n+\tfd_ = open(dri_node, O_RDWR | O_CLOEXEC);\n+\tif (fd_ < 0) {\n+\t\tLOG(GBM, Error) << \"Open \" << dri_node << \" fail \" << fd_;\n+\t\treturn fd_;\n+\t}\n+\n+\tgbm_device_ = gbm_create_device(fd_);\n+\tif (!gbm_device_) {\n+\t\tLOG(GBM, Error) << \"gbm_crate_device fail\";\n+\t\tgoto fail;\n+\t}\n+\n+\tformat_ = libcamera::formats::ARGB8888;\n+\n+\treturn 0;\n+fail:\n+\treturn -ENODEV;\n+}\n+} //namespace libcamera\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex de1eb99b28fdb07b78b529ed21d9d584675d50ae..64270b571cea2ece8d4dfea8a23b8edf60de70d3 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -68,6 +68,16 @@ libcamera_deps = []\n libatomic = cc.find_library('atomic', required : false)\n libthreads = dependency('threads')\n \n+libgbm = cc.find_library('gbm', required: false)\n+gbm_works = cc.check_header('gbm.h', required: false) \n+\n+if libgbm.found() and gbm_works\n+ config_h.set('HAVE_GBM', 1)\n+ libcamera_internal_sources += files([\n+ 'gbm.cpp',\n+ ])\n+endif\n+\n subdir('base')\n subdir('converter')\n subdir('ipa')\n@@ -181,6 +191,7 @@ libcamera_deps += [\n libcamera_base_private,\n libcrypto,\n libdl,\n+ libgbm,\n liblttng,\n libudev,\n libyaml,\n","prefixes":["v2","22/37"]}