{"id":24198,"url":"https://patchwork.libcamera.org/api/1.1/patches/24198/?format=json","web_url":"https://patchwork.libcamera.org/patch/24198/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:28","name":"[v2,16/37] libcamera: software_isp: debayer: Introduce a stop() callback to the debayer object","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"33f87eb670cce8f35b598ad1b448f5152232a2eb","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24198/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/1.1/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24198/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24198/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEFD5BEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:49:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 492956932A;\n\tSun, 24 Aug 2025 02:49:10 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20206692F4\n\tfor ;\n\tSun, 24 Aug 2025 02:48:51 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-3c4e9efb88aso1759274f8f.2\n\tfor ;\n\tSat, 23 Aug 2025 17:48:51 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RBY5tSbM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996530; x=1756601330;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=buyPJiIJKZXiM/HnjpnpDLGVy4LpqFUeppgQojCV8f8=;\n\tb=RBY5tSbMgLFXET7H2PtfLHH3vowGzrydzLSMqbJdMdtP4gQmZiwiXzyqIpO3kJpWmx\n\tQaF10T1dLeh+VvX5IOVkrp9tcTazJpiseDNDde4Z8FBm5f2KwanrzZQ9dOYV8iP2KKbS\n\tPV4xLBVhbo0WabC0LTT8fgyughpViPyGLqAt71KiM8ED5i3BM0/qMXVs2R0YwnjHD88r\n\tIFTGi3MgrKLSBxxcoucWXuFE1N0CkhjbDB4w9skowtmN4peRT5kSThkr/FjHv6bML1On\n\tsN2vOL3GXlGj7guZQka8XKz+L/SsWSD3n7/JBbv4ZGn906mFnfwR7GdiF5ar5p5I3e6X\n\tjb6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996530; x=1756601330;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=buyPJiIJKZXiM/HnjpnpDLGVy4LpqFUeppgQojCV8f8=;\n\tb=lDiXZxEKqGCmJ+nWpykPSuQaO+uqrroywO0e1iBvrhFAn9a2hfJYPhUfh92iWnark5\n\tKSjvlqTHxhszqFlVwDGcjsCZCI4hroZtgVEXwU6bCoavhF3TcyVdowQzUrsZ2YBoKTzF\n\trAnGAub2mHAfRx2lbtbQ8pY2lxTIh21b3rHqjZQtKU9FtLkTcjRqdmsepYAWRU6c/f3a\n\twVb2cgqPIRB9HnQbR7XydA/uiP6BCmdr0+p/t8H9hMq0/FUoS+NfW2highU8QjzTRIFs\n\tua8/f7x6+qcPN9wHRjB1YO9gNx+CB2dKwnvmwpvX73niNPoDo2F3LSp2WZiaWq9Z/BLu\n\tTybg==","X-Gm-Message-State":"AOJu0YxLCAFSrQ15SM91Qvy4DKgwFWx5ysF4XR7pskYdO4qM/C1nYqke\n\tY03MJB9itKSvZxe0fLgCTFtAhvYstyn7J6TRIf3yE+7tMmM5lsUGIFb35wSaf0Qo+FU=","X-Gm-Gg":"ASbGncv9V/4TbTpoD7o7nsEMyjEK1OXO4GtE+px9csVCPh1vZ3arzN/uyAENhOCUB+b\n\tCIw2WwFRDtgPI3q+YHPA815NLc+V7IPe2NrQdVfTmKDHyyKXqDqX5h+ht7SJ/psCZZudWoLiLqM\n\tKSq4pAn61PnMkr136Oz7hCbZWZdmlVfdenvbClYl9W4fESMv6R+zLtORfbK5aJhsLk1F0X2IjH9\n\t06AnHa6jplHL5aERuSYOW0M7slbvs2j8xZHgudYJxHfhK8bsG41sdSwyoMZ5eJdc8IJFrECgHnO\n\tKymIFogjatPlcx7o9KVp8O9ZP6Oh5MeYn5SZd5QtaLvuduJSvFtg6EsdoeI1nGQsOvBYE8LibHO\n\tzwRSx/aLJYa0CL2YlvV+sk6d+d8VT6Xgs2P3diSXaKym+cnwkJhWj4C/Oamqk3GHCv0xe1nMQDS\n\tupYvkCfPJQmg1f3AySq8FM","X-Google-Smtp-Source":"AGHT+IFdn/1fN2eF5MPZ7muvVg4a/iHUokPPieTHyJy4LpgdSzufLYQq18NIf1ZbPniZxEwrH5kKjA==","X-Received":"by 2002:a05:600c:45d0:b0:459:e025:8c5a with SMTP id\n\t5b1f17b1804b1-45b517d4b94mr71758495e9.33.1755996530576; \n\tSat, 23 Aug 2025 17:48:50 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:28 +0100","Subject":"[PATCH v2 16/37] libcamera: software_isp: debayer: Introduce a\n\tstop() callback to the debayer object","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-16-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1785;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=Zoj/84VUy61EbRwVaSQZKyt7j6W8BL9rD4a7kpxc2TY=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFf6iqPFJTnJR58QTPrrv5gQpia+YZFe9hDn\n\tPeBdIUyUReJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXwAKCRAicTuzoY3I\n\tOrnmEACiTMVlr6jfHHyujv8bUETtxx6jhjTzYzauXmnqtx+nZ02FQzT+uejFLdTHtBFQlSv0Fc+\n\tLHcOij86C1LeDP5KUYjTbZyNaEiXcPHh8vSSu6Mc1jCZ3Q325bTk5gUz6eJZUJCGmGnPfq241kt\n\tIHsedtUvCMknsQWgQbwwiM2eXQITte+8WV02Bww/fe++yNu1NDibG6yuMaUn6b3UAFNsgJvrWL9\n\twMVU0MG616ygbMGud25IyNkaHGGrJjhjLGWVQ0eNGhXIh2L/TTfEHMk2mfmphX5+fG5yhhg9fxA\n\tDR0NuM4hl7eswbCOPrs5W4mRqgfXxnoymIByl5VV8l/9ByS6Pks4dlwpEGxtc+fNQXI7uZuis7G\n\tqHn19+T7kh9oOo8jls7DsGrdeWudrgTvWtfocj8Kc/i/lqpawieoiyVIOrgzVYtL/pIvJ/a+ec6\n\t+XCwDpw2HyqpmV02WLfTt+Dkj30hFC+WmXd24orYImb6ll8uoXa5+0I+RsQgsVIgL6LzWjga7uF\n\tjSsEFo6lr6N7oJ2wRtxGxBfmUNWwKtfgKNYE7ZTAXCx3oVz4mVpaALuMutIuhJjk6llc3mY/itn\n\t3jl4OSPEYZlb4EKN6iZE9t5mSGSvaGV5T6WKrEyZOb2TihaZASbMW1qy/M4/dMhfx2Y/IibI9OB\n\t1ro7yTSbFCUY8eg==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The eGL class wants to be able to teardown its sync_ data member\nproperly but, doing so in the destructor means we can't make the eGL\ncontext current and thus can't tear down the sync primitive properly.\n\nIntroduce a stop() method to the debayer class which triggers from the\nsoftisp's stop method, allowing a controlled and appropriate tear-down\nof debayer-egl and egl class related data well before the destructors\nget invoked.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 3 +++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 214bcdd3c535bae7851d6e0221ba68c19785507d..352ffb89ad9d5a32ed1bbb14253af5e3f21d508c 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -47,6 +47,7 @@ public:\n \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n \n \tvirtual void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n+\tvoid stop() {}\n \n \tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n \ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex e8fa8a17a11c63ebab1338a90df204f4a888c4d6..e6bf76f214280194bc20aaaed4b5bc96598436fb 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -363,6 +363,9 @@ int SoftwareIsp::start()\n */\n void SoftwareIsp::stop()\n {\n+\tdebayer_->invokeMethod(&Debayer::stop,\n+\t\t\t ConnectionTypeQueued);\n+\n \tispWorkerThread_.exit();\n \tispWorkerThread_.wait();\n \n","prefixes":["v2","16/37"]}