{"id":24196,"url":"https://patchwork.libcamera.org/api/1.1/patches/24196/?format=json","web_url":"https://patchwork.libcamera.org/patch/24196/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-13-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:25","name":"[v2,13/37] libcamera: software_isp: Move configure to worker thread","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1e5afac0095b6381ff51f46b8a779a03441014f1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24196/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/1.1/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24196/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24196/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 809FFBEFBE\n\tfor ;\n\tSun, 24 Aug 2025 00:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A98F66931F;\n\tSun, 24 Aug 2025 02:49:05 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECB0C69303\n\tfor ;\n\tSun, 24 Aug 2025 02:48:48 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-45b4e5c3d0fso6424895e9.2\n\tfor ;\n\tSat, 23 Aug 2025 17:48:48 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SuaQoFiV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996528; x=1756601328;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=NNAYhv4oH51PNDeH7ZZtRdYMZk/R8PHqFK1u1jXAV/E=;\n\tb=SuaQoFiV6Bff9Yg0WVz2o0+E3k/ItEMhhYiH4s4j3zaxJBSt5uWHB90BNpYTroVFIP\n\tdgwuNEbim63tKPc2xFSBkC6UD45Ms1Ml8l4NT9rhYy1MYx+Cqk3KnaXX+6zcP9Y8iz4f\n\tAqZMPpSSh3XTFsIlaAV7ETvYZDiEoiScS/3ATz+yZTSBmflD2YD7savgXTh5KukBcuIH\n\t2Fr/0jG83deuoNGMvRJ8Q2+YaNd1ZUHzkkAidGA7irBfgy6Fx8a1om5mZa3IOWeZPcAP\n\tId3OJOChDeXOKjPXYO6OTyKRlc8CIphRtpouRE5y1RKRDWgD0i3gziQlAQf4QyAPs5PA\n\tKaSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996528; x=1756601328;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=NNAYhv4oH51PNDeH7ZZtRdYMZk/R8PHqFK1u1jXAV/E=;\n\tb=n5DaATQKBv89117ww9FtSVX+txJyg/m5XA8u7JPXxITo7jQajY3G/n885h4M1gnn/n\n\tDSLERrQmwSSExVM6iDDa4vpcObXSqS2m29TE6WWcQfGz/dH+q9DoStDfgHmAqadzIomG\n\tSc2EgIwZ16qF7EIEOpCpurxPVbPwHVMAhSKhTJxez9QV5BGREEGj8yagnehmsDDNf84u\n\tvIV5XiubEbuLmsNk7vaiqZNE6cZI2tsRG5ClUEKTrR50djGN14bVUBKPi2TFBYTpista\n\tkfnK+qBVsPPVOdOBiLX5W3UG50Mld5WXnYqxBRd42ytnosDbwLo0g7SqRckuQ5Tkpj+s\n\t89xA==","X-Gm-Message-State":"AOJu0Yw+10VoulwCjUfO/kweCSg3C3RjeA6izvbEVg4+VxmQULpGk1ER\n\t7JujaGxuT9xFaygDPt+cuqTnpypO2258+YUnXUZhY2mCRPXLdSYiUiXCrfEIBJti8DjpiHcHLHA\n\tNNDOFE1Y=","X-Gm-Gg":"ASbGncu+SbK7ynZIIKiO0jx5VKsvqnzyFD6mx/GGjlKMk6ype05kCGOki5xZHIfDss0\n\tvk3PKjRhlKyiTXEru9wIpesNuecMveUnmbjYIPTXDKnhwL1b/zip/Yr3vzuYdAS8weIHl1ywHnI\n\tgVtmdqdiRrBRzYN+OyT+MfJCmJw+Gky36WJ9XUT4tsmtZ9niNBZ0ANXZ1gXhoFAe+SZd6/9b4Gw\n\t++zVvC58tVg8MNt+I/EiSIU/fDCv8+/XHTT9u4uId4jFfIh7WoGqJSem3mHkUqiWhA8iQPl+3gO\n\t+mo4P3kjFDFyy7UCSadw5yAGDEJ9RRb/5zoWy0zDSGG7u3W6NlEfKXj93KBzagt3AGagd7+mjyt\n\tPmyrV0mS/pJwO2L6i/9a7rhq04rD7wdddAJJPGHerIXo+lTC8JwTulhN2+v5AmTbPWRfLD3hcLx\n\te0sr6MHXJYwrkB2mYa9OPp","X-Google-Smtp-Source":"AGHT+IFjIuWbknYbasQ29IzTrPAqkZVaNHzqQeWABKv0YRK0TFFNkFNCVGj00wEAtL52zZdUV3pp3g==","X-Received":"by 2002:a05:600c:4f41:b0:456:fc1:c26d with SMTP id\n\t5b1f17b1804b1-45b5179557fmr55642855e9.2.1755996528080; \n\tSat, 23 Aug 2025 17:48:48 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:25 +0100","Subject":"[PATCH v2 13/37] libcamera: software_isp: Move configure to worker\n\tthread","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-13-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1537;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=yPLs+JaO0rbCfUdrjCCe0Lkj75znaoEZ8v5pMMr2iR8=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFerCDGsqA5S7Kb0vS0+ft1dCgjgeklcoh9c\n\thn6qZPJJy2JAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXgAKCRAicTuzoY3I\n\tOu+kD/0QsUbkYKyUSByqrpuGdAG8+EdXT81CJeVR/DzhOrSSCgvX3jZnyEelnAOznM1CcahsUkB\n\t6WcdaYQioudpi8DtwUHqzsVm15Y6pmAHff0UE5ZN8sjmKPvWJwnY5du48DN2veWIA11GjRir0RR\n\t0IDLUjcLZG8IfF9vZ8CAGuyt7kFtveaY05LxUM8IEkMhwqq9BoFRqBdg3y58d8ibXn+uT99SHFq\n\teZDab/pK4eQMyRNCQVokXiAcITGHemcDDT5nK7A6WQ1JEXCrCY9BEKrVE9eo5kNy01Nw39lfWKg\n\tBrDAF84h6KEcFjJy5SqaEjje9WMiId1fQa9udibgM6SeugaD4Cz2hNybSlLMXRiEtq0odzs2l5N\n\tDIoyP1/F7NJ32W7OJ7NzDHibWJxRzVz/FPyyTF34ZgzqRRlPr0z4FMYfDyHV12nsKWFnkVQKrF7\n\tj4oQtGU9Kk/E4+ptrQG7S5JIY6oP5NT2W31DRgKgwXw6rAyklMhjLdlvQgiof9mFHQLPgpZNhM0\n\tJKLGbc1NLm8aiNxPD7WPTXxP2NwLDYGqYuoOmTZB1W7P0IXs45oAEjkqo0eMboXjQo1WgX5bzPf\n\tA9aykbQebkiER1iwm5GW6azXjToDly+VUtUtS5rF7f+2/i35dFaFnrovna0hzgpkvkO6cMLOVfX\n\tyF4mHJ3VyBCmjEg==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7bee8f0681dd5cedcd81950ed49f611b514e763d..e8fa8a17a11c63ebab1338a90df204f4a888c4d6 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -263,7 +263,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tdebayer_->moveToThread(&ispWorkerThread_);\n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n@@ -386,7 +394,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n","prefixes":["v2","13/37"]}