{"id":24134,"url":"https://patchwork.libcamera.org/api/1.1/patches/24134/?format=json","web_url":"https://patchwork.libcamera.org/patch/24134/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815113400.20623-5-laurent.pinchart@ideasonboard.com>","date":"2025-08-15T11:33:56","name":"[v2,4/8] pipeline: rpi: Use structured bindings in range-based for loop","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"00ab4de1ede5570befb52a54f80364b6449f5196","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24134/mbox/","series":[{"id":5383,"url":"https://patchwork.libcamera.org/api/1.1/series/5383/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5383","date":"2025-08-15T11:33:52","name":"libcamera: Use span in FrameBuffer & assorted cleanups","version":2,"mbox":"https://patchwork.libcamera.org/series/5383/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24134/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24134/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3D1ABEFBE\n\tfor ;\n\tFri, 15 Aug 2025 11:34:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7363D6925D;\n\tFri, 15 Aug 2025 13:34:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A370269257\n\tfor ;\n\tFri, 15 Aug 2025 13:34:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9A71B63B;\n\tFri, 15 Aug 2025 13:33:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LA7ihypI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755257611;\n\tbh=R+akpr3BA09U9c5eXYOfZHxCa4barmtuykPCYQuuVC8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LA7ihypIGQgFNWvMAnKNcHI2ILeUi4H1y6sSL7Boig6ZrDCayPqVToibtYsGwR0Pn\n\tMs7ItwOVEivGFUlWaksVDszneEP4fRBcBzAA+RusKRhVPdHZHFduH09+p8W88sAVVC\n\tQFMQOysHY1vTfvbAYBjyQuVTmxyl9ZMhsHewuRlw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Daniel_R=C3=A1kos?= ","Subject":"[PATCH v2 4/8] pipeline: rpi: Use structured bindings in range-based\n\tfor loop","Date":"Fri, 15 Aug 2025 14:33:56 +0300","Message-ID":"<20250815113400.20623-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.1","In-Reply-To":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","References":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Simplify a range-based for loop by replacing an iterator with structure\nbindings. This makes the code easier to read.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 563df198e6e4..09d30f34d9b7 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -882,10 +882,10 @@ void PipelineHandlerBase::mapBuffers(Camera *camera, const BufferMap &buffers, u\n \t * This will allow us to identify buffers passed between the pipeline\n \t * handler and the IPA.\n \t */\n-\tfor (auto const &it : buffers) {\n-\t\tbufferIds.push_back(IPABuffer(mask | it.first,\n-\t\t\t\t\t it.second.buffer->planes()));\n-\t\tdata->bufferIds_.insert(mask | it.first);\n+\tfor (auto const &[id, buffer] : buffers) {\n+\t\tbufferIds.push_back(IPABuffer(mask | id,\n+\t\t\t\t\t buffer.buffer->planes()));\n+\t\tdata->bufferIds_.insert(mask | id);\n \t}\n \n \tdata->ipa_->mapBuffers(bufferIds);\n","prefixes":["v2","4/8"]}