{"id":24081,"url":"https://patchwork.libcamera.org/api/1.1/patches/24081/?format=json","web_url":"https://patchwork.libcamera.org/patch/24081/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250808141315.413839-11-stefan.klug@ideasonboard.com>","date":"2025-08-08T14:12:48","name":"[v2,10/16] pipeline: rkisp1: Add error log when parameter queuing fails","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9c86de3ce4c5050a0f99bbcb6733be129f414363","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24081/mbox/","series":[{"id":5364,"url":"https://patchwork.libcamera.org/api/1.1/series/5364/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5364","date":"2025-08-08T14:12:38","name":"Implement WDR algorithm","version":2,"mbox":"https://patchwork.libcamera.org/series/5364/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24081/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24081/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08F32BDCC1\n\tfor ;\n\tFri, 8 Aug 2025 14:14:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B627269227;\n\tFri, 8 Aug 2025 16:14:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F3E469221\n\tfor ;\n\tFri, 8 Aug 2025 16:14:13 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3ea1:35ac:90da:a221])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2499C185B; \n\tFri, 8 Aug 2025 16:13:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mAUKwrGp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754662403;\n\tbh=nOvzFXaNpsdqSZiKH6UrWYHEak/kLAo46+DfYL22M/A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mAUKwrGpesNE6g8kzp/v5lbccDz/vWG+JffyRA/LotwKL87RDVbR8n6hoWaOVhe2y\n\t4DrNjZJ2lgdxQ0HnyQU9CR1ZwzR1F08v1ImdAPYXJ0boB7NA1/Hyy497ExCeQTPwy5\n\tTmlTe+iGRXhjFj5Yv0A9ZlRw+yGMJdSxiKogxhAI=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v2 10/16] pipeline: rkisp1: Add error log when parameter\n\tqueuing fails","Date":"Fri, 8 Aug 2025 16:12:48 +0200","Message-ID":"<20250808141315.413839-11-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the extensible parameters queued to the kernel contain an unknown\nblock type it fails with -EINVAL. This should not happen as user land is\nsupposed to check for the supported parameter types. But it took a while\nto figure out where things went wrong. Add a error statement when\nqueuing of the parameter buffer fails for whatever reason.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n\n---\n\nChanges in v4:\n- Improved commit message\n\nChanges in v3:\n- Collected tags\n- Removed hint regarding unsupported parameter types as this will be\n handled using the now upstreamed RKISP1_CID_SUPPORTED_PARAMS_BLOCKS.\n\nChanges in v2:\n- Also print the error code in case of failure\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 8b434a56ea04..06785cb2fd57 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -429,7 +429,14 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\treturn;\n \n \tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n-\tpipe->param_->queueBuffer(info->paramBuffer);\n+\n+\tint ret = pipe->param_->queueBuffer(info->paramBuffer);\n+\tif (ret < 0) {\n+\t\tLOG(RkISP1, Error) << \"Failed to queue parameter buffer: \"\n+\t\t\t\t << strerror(-ret);\n+\t\treturn;\n+\t}\n+\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n \tif (info->mainPathBuffer)\n","prefixes":["v2","10/16"]}