{"id":24074,"url":"https://patchwork.libcamera.org/api/1.1/patches/24074/?format=json","web_url":"https://patchwork.libcamera.org/patch/24074/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250808141315.413839-4-stefan.klug@ideasonboard.com>","date":"2025-08-08T14:12:41","name":"[v2,03/16] libipa: camera_sensor_helper: Add quantizeGain() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f0ef2e8081d15f49018158b3bafc58434f758b68","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24074/mbox/","series":[{"id":5364,"url":"https://patchwork.libcamera.org/api/1.1/series/5364/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5364","date":"2025-08-08T14:12:38","name":"Implement WDR algorithm","version":2,"mbox":"https://patchwork.libcamera.org/series/5364/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24074/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24074/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1968BDCC1\n\tfor ;\n\tFri, 8 Aug 2025 14:13:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D1F869221;\n\tFri, 8 Aug 2025 16:13:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 176CF6921C\n\tfor ;\n\tFri, 8 Aug 2025 16:13:52 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3ea1:35ac:90da:a221])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 314CF42D0; \n\tFri, 8 Aug 2025 16:13:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wfl++2kv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754662382;\n\tbh=iT03ipL+lnvUK0FZKqO3DvtO5ANT+3w79AyDtnbnQEs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wfl++2kvSplL8Strj2CPkAC9VEsQxlkZQITuhqw7sCFPQY/yZZiCtz5W2uHeo4h/g\n\tOYIOC9geLEiteiYKvg4/NPJE6D7fv40Ci4hOwyDn8hWBWY61cJuDyK0o6C8KyEB4Px\n\tgH5gGgPD57q8jVbics3sMEiJiGm1V/euBTGbXoz8=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 03/16] libipa: camera_sensor_helper: Add quantizeGain()\n\tfunction","Date":"Fri, 8 Aug 2025 16:12:41 +0200","Message-ID":"<20250808141315.413839-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>","References":"<20250808141315.413839-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a small utility function that calculates the quantized gain that\ngets applied by a sensor when the gain code is set to gainCode(gain).\nThis is needed by algorithms to calculate a digital correction gain that\ngets applied to mitigate the error introduce by quantization.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 23 +++++++++++++++++++++++\n src/ipa/libipa/camera_sensor_helper.h | 1 +\n 2 files changed, 24 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex dcd69d9f2bbb..0a7b66cd003a 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -131,6 +131,29 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n \t}\n }\n \n+/**\n+ * \\brief Quantize the given gain value\n+ * \\param[in] _gain The real gain\n+ * \\param[out] quantizationGain The gain that is lost due to quantization\n+ *\n+ * This function returns the actual gain that get's applied when the sensors\n+ * gain is set to gainCode(gain).\n+ *\n+ * It shall be guaranteed that gainCode(gain) == gainCode(quantizeGain(gain)).\n+ *\n+ * If \\a quantizationGain is provided it is filled with the gain that is lost\n+ * due to quantization.\n+ *\n+ * \\return The quantized real gain\n+ */\n+double CameraSensorHelper::quantizeGain(double _gain, double *quantizationGain) const\n+{\n+\tdouble g = gain(gainCode(_gain));\n+\tif (quantizationGain)\n+\t\t*quantizationGain = _gain / g;\n+\treturn g;\n+}\n+\n /**\n * \\struct CameraSensorHelper::AnalogueGainLinear\n * \\brief Analogue gain constants for the linear gain model\ndiff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex a9300a64f1e7..42bdb3c5550f 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -29,6 +29,7 @@ public:\n \tstd::optional blackLevel() const { return blackLevel_; }\n \tvirtual uint32_t gainCode(double gain) const;\n \tvirtual double gain(uint32_t gainCode) const;\n+\tvirtual double quantizeGain(double gain, double *quantizationGain) const;\n \n protected:\n \tstruct AnalogueGainLinear {\n","prefixes":["v2","03/16"]}