{"id":24044,"url":"https://patchwork.libcamera.org/api/1.1/patches/24044/?format=json","web_url":"https://patchwork.libcamera.org/patch/24044/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250731123247.755475-1-barnabas.pocze@ideasonboard.com>","date":"2025-07-31T12:32:47","name":"[RFC,v1] Documentation: Fix documentation generation when subproject","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b55b052233258bc7ccb4bdce550b9887e38e0dfd","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24044/mbox/","series":[{"id":5352,"url":"https://patchwork.libcamera.org/api/1.1/series/5352/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5352","date":"2025-07-31T12:32:47","name":"[RFC,v1] Documentation: Fix documentation generation when subproject","version":1,"mbox":"https://patchwork.libcamera.org/series/5352/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24044/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24044/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAE10BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Jul 2025 12:32:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43D7969212;\n\tThu, 31 Jul 2025 14:32:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B894E69154\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Jul 2025 14:32:50 +0200 (CEST)","from pb-laptop.local (185.221.140.213.nat.pool.zt.hu\n\t[185.221.140.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 853D61809\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Jul 2025 14:32:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Og0evqjX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753965126;\n\tbh=gslb5cGCG0RPyqIu7eOgitgv+Zygd8lETGy3bxXjupQ=;\n\th=From:To:Subject:Date:From;\n\tb=Og0evqjXo0jEgZ12QirmuUeIn7ppFen1+QU4Nas/P1O/zMJ/R+j5Es+gvxIWe3d2+\n\tX7lR+Bg3gatz++pDTCn7LicfumSpLF81uIKfO91IsFgTC4NNh6Q7OVaf2ZbiDCi9F7\n\tgjH2Kr8ed/+PvVTlgOqw5C1CL7J5Yoo3qMph1rZw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1] Documentation: Fix documentation generation when\n\tsubproject","Date":"Thu, 31 Jul 2025 14:32:47 +0200","Message-ID":"<20250731123247.755475-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The paths of the doxygen tag files for sphinxcontrib-doxygen must be\nabsolute or relative the the current working directory. However, when\nlibcamera is built as a subproject, the current working directory\nis the top-level build directory. Thus the paths for the tag files\nwill not be correct.\n\nFix that by using `configure_file()` to generate the final sphinx\nconfiguration with the appropriate paths queried from meson.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n Documentation/{conf.py => conf.py.in} |  6 +++---\n Documentation/meson.build             | 16 ++++++++++++++--\n 2 files changed, 17 insertions(+), 5 deletions(-)\n rename Documentation/{conf.py => conf.py.in} (95%)","diff":"diff --git a/Documentation/conf.py b/Documentation/conf.py.in\nsimilarity index 95%\nrename from Documentation/conf.py\nrename to Documentation/conf.py.in\nindex f50be60a1..097e579b5 100644\n--- a/Documentation/conf.py\n+++ b/Documentation/conf.py.in\n@@ -74,11 +74,11 @@ pygments_style = None\n \n doxylink = {\n     'doxy-pub': (\n-        'Documentation/api-html/tagfile.xml',\n+        '@TOP_BUILDDIR@/Documentation/api-html/tagfile.xml',\n         '../api-html/',\n     ),\n     'doxy-int': (\n-        'Documentation/internal-api-html/tagfile.xml',\n+        '@TOP_BUILDDIR@/Documentation/internal-api-html/tagfile.xml',\n         '../internal-api-html/',\n     ),\n }\n@@ -89,7 +89,7 @@ doxylink = {\n # a list of builtin themes.\n #\n html_theme = 'theme'\n-html_theme_path = ['.']\n+html_theme_path = ['@THEME_DIR@']\n \n # Theme options are theme-specific and customize the look and feel of a theme\n # further.  For a list of options available for each theme, see the\ndiff --git a/Documentation/meson.build b/Documentation/meson.build\nindex b898ba3a0..0710084fe 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -142,11 +142,20 @@ if sphinx.found()\n               .format(mod, version, min_version))\n     endif\n \n+    sphinx_conf = configure_file(input : 'conf.py.in',\n+                                 output : 'conf.py',\n+                                 configuration : {\n+                                    'TOP_BUILDDIR': meson.project_build_root(),\n+                                    'THEME_DIR': meson.current_source_dir(),\n+                                 })\n+\n+    sphinx_conf_dir = fs.parent(sphinx_conf)\n+\n     docs_sources = [\n         'camera-sensor-model.rst',\n         'code-of-conduct.rst',\n         'coding-style.rst',\n-        'conf.py',\n+        sphinx_conf,\n         'contributing.rst',\n         'design/ae.rst',\n         'documentation-contents.rst',\n@@ -171,6 +180,7 @@ if sphinx.found()\n \n     custom_target('documentation',\n                   command : [sphinx, '-D', release, '-q', '-W', '-b', 'html',\n+                             '--conf-dir', sphinx_conf_dir,\n                              meson.current_source_dir(), '@OUTPUT@'],\n                   input : docs_sources,\n                   output : 'html',\n@@ -184,7 +194,9 @@ if sphinx.found()\n                   install_tag : 'doc')\n \n     custom_target('documentation-linkcheck',\n-                  command : [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n+                  command : [sphinx, '-W', '-b', 'linkcheck',\n+                             '--conf-dir', sphinx_conf_dir,\n+                             meson.current_source_dir(), '@OUTPUT@'],\n                   build_always_stale : true,\n                   input : docs_sources,\n                   output : 'linkcheck')\n","prefixes":["RFC","v1"]}