{"id":24027,"url":"https://patchwork.libcamera.org/api/1.1/patches/24027/?format=json","web_url":"https://patchwork.libcamera.org/patch/24027/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250729154954.161715-1-uajain@igalia.com>","date":"2025-07-29T15:49:54","name":"gstreamer: Use G_TYPE_UINT type for libcamera::Size","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"42568ce6ea9acda67387987dd08becdec8f3d03d","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/1.1/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24027/mbox/","series":[{"id":5347,"url":"https://patchwork.libcamera.org/api/1.1/series/5347/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5347","date":"2025-07-29T15:49:54","name":"gstreamer: Use G_TYPE_UINT type for libcamera::Size","version":1,"mbox":"https://patchwork.libcamera.org/series/5347/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24027/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24027/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDD33BDC71\n\tfor ;\n\tTue, 29 Jul 2025 15:49:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAAB7691E2;\n\tTue, 29 Jul 2025 17:49:47 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89F1169052\n\tfor ;\n\tTue, 29 Jul 2025 17:49:46 +0200 (CEST)","from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ugmaH-005V6x-9A; Tue, 29 Jul 2025 17:49:45 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"EFwTsf8R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=BlNt7A6i7Gm+o4BFrXhna9avuo5GipneIfGKo9FY51w=;\n\tb=EFwTsf8Rc4pFqbMdWatD247e5r\n\tCly9Ds5ti6bjz/Emj0QCydc8ZXg8N2TF2pMcNv/TEHeIiqVuHo3ISqZ8b02awR2uggoBcezPwy69w\n\tbB49CjyYWPNCdaCAYe5mOe46DpPUVvxM5My0b4VNfuSm6p10S/5O1jN3TE/vjnnJRaYLBE+0GjCmU\n\tTiFpLVq+Pyj643yuPE+JFX3c4ksCDemkg+lYXDq2paT/oCSCZNX8/EpFp2hJi43ilQxLyHKIT7dln\n\t9ASkDXmBPQmvW+yriiceIrUD+x4hvKL6Z8iFqFCA9gikLmn3ugUSAflx0vo2JHOlYhg/hJFJEPXHA\n\t1CIMW35g==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jaslo Ziska ,\n\tNicolas Dufresne ,\n\tUmang Jain ","Subject":"[PATCH] gstreamer: Use G_TYPE_UINT type for libcamera::Size","Date":"Tue, 29 Jul 2025 21:19:54 +0530","Message-ID":"<20250729154954.161715-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera::Size has two components - width and height, which are of\nunsigned integer type. Hence, use the G_TYPE_UINT for initialising\nand setting the GValue for libcamera::Size in\ngst_libcamera_gvalue_set_size().\n\nSigned-off-by: Umang Jain \n---\nBased on [PATCH v5 0/3] gstreamer: Report camera properties as device properties\n---\n src/gstreamer/gstlibcamera-utils.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex ebc43f6c..e13ed43a 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -629,13 +629,13 @@ void gst_libcamera_gvalue_set_point(GValue *value, const Point &point)\n void gst_libcamera_gvalue_set_size(GValue *value, const Size &size)\n {\n \tGValue width = G_VALUE_INIT;\n-\tg_value_init(&width, G_TYPE_INT);\n-\tg_value_set_int(&width, size.width);\n+\tg_value_init(&width, G_TYPE_UINT);\n+\tg_value_set_uint(&width, size.width);\n \tgst_value_array_append_and_take_value(value, &width);\n \n \tGValue height = G_VALUE_INIT;\n-\tg_value_init(&height, G_TYPE_INT);\n-\tg_value_set_int(&height, size.height);\n+\tg_value_init(&height, G_TYPE_UINT);\n+\tg_value_set_uint(&height, size.height);\n \tgst_value_array_append_and_take_value(value, &height);\n }\n \n","prefixes":[]}