{"id":23920,"url":"https://patchwork.libcamera.org/api/1.1/patches/23920/?format=json","web_url":"https://patchwork.libcamera.org/patch/23920/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250724065256.75175-4-dan.scally@ideasonboard.com>","date":"2025-07-24T06:52:49","name":"[03/10] libcamera: bayer_format: Add \"NONE\" to BayerFormat::Order enum","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e63bc54b6e6e9f9ce91b1c5a50e469c1e4cc2ccf","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23920/mbox/","series":[{"id":5319,"url":"https://patchwork.libcamera.org/api/1.1/series/5319/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5319","date":"2025-07-24T06:52:46","name":"Support memory input mode in mali-c55","version":1,"mbox":"https://patchwork.libcamera.org/series/5319/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23920/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23920/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3627C3323\n\tfor ;\n\tThu, 24 Jul 2025 06:53:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E31AB6908C;\n\tThu, 24 Jul 2025 08:53:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2382169083\n\tfor ;\n\tThu, 24 Jul 2025 08:53:15 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32A7F7F0;\n\tThu, 24 Jul 2025 08:52:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bCswFjzI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753339956;\n\tbh=5RAKvTIfp8RHT/B2l1kVT4fZU1T6Wk1qqcrv8/GTyvg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bCswFjzIT5llmBXM/+4ZIah7qDC5Fe/T3MTff2+RqVeDplw2mXvs4NqzWl9N9+Xyt\n\tQgYeIPYtn3bj6YCj6G2XPtOcBCIs75TuV8yBcwWKOVAq7Rj3cJSQ4+YKDfNnpEst1k\n\tJmeMBF3toSSI5muADrw/3gwYrVK0brjvuVcdbbZg=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","Subject":"[PATCH 03/10] libcamera: bayer_format: Add \"NONE\" to\n\tBayerFormat::Order enum","Date":"Thu, 24 Jul 2025 07:52:49 +0100","Message-Id":"<20250724065256.75175-4-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250724065256.75175-1-dan.scally@ideasonboard.com>","References":"<20250724065256.75175-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a NONE entry to BayerFormat::Order enumeration to denote pixel\nformats encoding bayer data but which do not correspond to a specific\norder.\n\nSigned-off-by: Daniel Scally \n---\n include/libcamera/internal/bayer_format.h | 3 ++-\n src/libcamera/bayer_format.cpp | 3 +++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 6 ++++++\n 3 files changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\nindex 5c14bb5f..9b6b5b58 100644\n--- a/include/libcamera/internal/bayer_format.h\n+++ b/include/libcamera/internal/bayer_format.h\n@@ -27,7 +27,8 @@ public:\n \t\tGBRG = 1,\n \t\tGRBG = 2,\n \t\tRGGB = 3,\n-\t\tMONO = 4\n+\t\tMONO = 4,\n+\t\tNONE = 5\n \t};\n \n \tenum class Packing : uint16_t {\ndiff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 3dab91fc..89fe10ed 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -49,6 +49,9 @@ namespace libcamera {\n * \\brief R then G on the first row, G then B on the second row.\n * \\var BayerFormat::MONO\n * \\brief Monochrome image data, there is no colour filter array.\n+ * \\var BayerFormat::NONE\n+ * \\brief Bayer-formatted data but without a specific order, which will have to\n+ * be discerned through other means.\n */\n \n /**\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex 32989c19..232a8525 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -641,6 +641,12 @@ int CameraSensorLegacy::initProperties()\n \t\tcase BayerFormat::MONO:\n \t\t\tcfa = properties::draft::MONO;\n \t\t\tbreak;\n+\t\tcase BayerFormat::NONE:\n+\t\t\tLOG(CameraSensor, Warning)\n+\t\t\t\t<< \"Sensor declares no CFA pattern. This is extremely unlikely \"\n+\t\t\t\t<< \"and should be investigated as a likely error.\";\n+\t\t\tcfa = properties::draft::MONO;\n+\t\t\tbreak;\n \t\t}\n \n \t\tproperties_.set(properties::draft::ColorFilterArrangement, cfa);\n","prefixes":["03/10"]}