{"id":23894,"url":"https://patchwork.libcamera.org/api/1.1/patches/23894/?format=json","web_url":"https://patchwork.libcamera.org/patch/23894/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250722083441.1716976-1-barnabas.pocze@ideasonboard.com>","date":"2025-07-22T08:34:41","name":"[v1] utils: codegen: proxy: Check `ipc_` instead of `isolate_`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7de93bd228dc9510769f56ae50396538cacf3cd9","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23894/mbox/","series":[{"id":5309,"url":"https://patchwork.libcamera.org/api/1.1/series/5309/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5309","date":"2025-07-22T08:34:41","name":"[v1] utils: codegen: proxy: Check `ipc_` instead of `isolate_`","version":1,"mbox":"https://patchwork.libcamera.org/series/5309/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23894/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23894/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CDB0C3237\n\tfor ;\n\tTue, 22 Jul 2025 08:34:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F5776901E;\n\tTue, 22 Jul 2025 10:34:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B920668FAC\n\tfor ;\n\tTue, 22 Jul 2025 10:34:44 +0200 (CEST)","from pb-laptop.local (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11FDE79CC\n\tfor ;\n\tTue, 22 Jul 2025 10:34:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R9Mmyvyx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753173247;\n\tbh=krKfc960Wd+diumkNR5KYOjW+LnGBBcXBJwp7uVlfII=;\n\th=From:To:Subject:Date:From;\n\tb=R9MmyvyxaaFuexrdU+Sl7FeZRZNOqurWP+yOxpZypmjbcfmXCt4A8YpzAZXIk+P36\n\tFaySmK1VqPoAobC+ufj2h3sW9z+BKGebZPcvuARcT0CEzv1riuyxUg9zwMn0tKtl7o\n\tbzd/imkbepJKF7Fp4TdLex/z5kSukr1Swc7GqIGg=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] utils: codegen: proxy: Check `ipc_` instead of `isolate_`","Date":"Tue, 22 Jul 2025 10:34:41 +0200","Message-ID":"<20250722083441.1716976-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Only try to send the \"Exit\" message if the `IPCPipeUnixSocket` object\nexists. If the constructor fails, then `ipc_` might not be initialized,\nwhich would lead to a nullptr dereference. This can still result in an\n`ipc_->sendAsync()` call even if `ipc_` is unconnected, but that only\nreports an error, and is still better than the status quo.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=276\nSigned-off-by: Barnabás Pőcze \n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex 9a3aadbd2..ba740a0de 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -96,7 +96,7 @@ namespace {{ns}} {\n \n {{proxy_name}}::~{{proxy_name}}()\n {\n-\tif (isolate_) {\n+\tif (ipc_) {\n \t\tIPCMessage::Header header =\n \t\t\t{ static_cast({{cmd_enum_name}}::Exit), seq_++ };\n \t\tIPCMessage msg(header);\n","prefixes":["v1"]}