{"id":23892,"url":"https://patchwork.libcamera.org/api/1.1/patches/23892/?format=json","web_url":"https://patchwork.libcamera.org/patch/23892/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250721120126.1563367-1-barnabas.pocze@ideasonboard.com>","date":"2025-07-21T12:01:26","name":"[v1] libcamera: camera: Do not call `generateConfiguration()` synchronously","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"595503a5507d4268e614030c85c1f40ad6e01b92","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23892/mbox/","series":[{"id":5307,"url":"https://patchwork.libcamera.org/api/1.1/series/5307/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5307","date":"2025-07-21T12:01:26","name":"[v1] libcamera: camera: Do not call `generateConfiguration()` synchronously","version":1,"mbox":"https://patchwork.libcamera.org/series/5307/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23892/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23892/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2406DC3237\n\tfor ;\n\tMon, 21 Jul 2025 12:01:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E62568FE5;\n\tMon, 21 Jul 2025 14:01:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54B5F68FB1\n\tfor ;\n\tMon, 21 Jul 2025 14:01:34 +0200 (CEST)","from pb-laptop.local (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCB8311EB\n\tfor ;\n\tMon, 21 Jul 2025 14:00:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"stSl7sGd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753099255;\n\tbh=fd05x34Zs3cMSv0tnVtYt4WWAjUpAg4r2JFeWU6hGmo=;\n\th=From:To:Subject:Date:From;\n\tb=stSl7sGd9cEKI4HIgeCzN8ZGGJREBXVpVUqHQvreKaxRvnWabcfoXo9l92OO0Oi0A\n\tYv3AKUYpja9TqyBaG/W16ltujJiemEmzS7VLnsc3QMJScerCAAUr/MInOYnTWKSQpI\n\tFKYGKbwWVXoVFgGIc65tq8cNygRLSVj0tuuqVJ7I=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: camera: Do not call `generateConfiguration()`\n\tsynchronously","Date":"Mon, 21 Jul 2025 14:01:26 +0200","Message-ID":"<20250721120126.1563367-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Most pipeline handler methods are dispatched in the internal `CameraManager`\nthread. `PipelineHandler::generateConfiguration()` was called directly,\nhowever, which likely goes against the expectations, so call it on the\ninternal thread.\n\nThis could not be done before 14618cdd0c80a4 (\"libcamera: base: bound_method: Move return value\")\nbecause the function returns `std::unique_ptr`, and that type cannot\nbe copied.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/camera.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 5efeadd53..423c5f3aa 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -1206,7 +1206,8 @@ std::unique_ptr Camera::generateConfiguration(Span config =\n-\t\td->pipe_->generateConfiguration(this, roles);\n+\t\td->pipe_->invokeMethod(&PipelineHandler::generateConfiguration,\n+\t\t\t\t ConnectionTypeBlocking, this, roles);\n \tif (!config) {\n \t\tLOG(Camera, Debug)\n \t\t\t<< \"Pipeline handler failed to generate configuration\";\n","prefixes":["v1"]}