{"id":23869,"url":"https://patchwork.libcamera.org/api/1.1/patches/23869/?format=json","web_url":"https://patchwork.libcamera.org/patch/23869/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250721104622.1550908-2-barnabas.pocze@ideasonboard.com>","date":"2025-07-21T10:46:01","name":"[RFC,v2,01/22] libcamera: controls: Strings are arrays","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1090c2f667cdb1e72bad16de48820df1b0ca5bf6","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23869/mbox/","series":[{"id":5305,"url":"https://patchwork.libcamera.org/api/1.1/series/5305/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5305","date":"2025-07-21T10:46:00","name":"libcamera: Add `MetadataList`","version":2,"mbox":"https://patchwork.libcamera.org/series/5305/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23869/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23869/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FC53C3237\n\tfor ;\n\tMon, 21 Jul 2025 10:46:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D49F568FE3;\n\tMon, 21 Jul 2025 12:46:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA30068FC2\n\tfor ;\n\tMon, 21 Jul 2025 12:46:26 +0200 (CEST)","from pb-laptop.local (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB0E07940;\n\tMon, 21 Jul 2025 12:45:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZjmIrjXw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753094750;\n\tbh=fd1Qlpn4U2Fo+n04ByoT//Suc9Fg2Oaqyuo86OxTfQc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZjmIrjXw9PzDMMgHUSW1a43fn/7+QqQwhzL+LwlV7MNLsQo7qEI9LmjX/E/BxSm5x\n\tOnoRgghvr56IsZVXMBwssjYPQh1XKxno2ncBi64+sU5JrnI/ys6UqTWlfeGwhNvJje\n\tW6GqGray86uSm0JQCUtT7c7zlrFflCjUbtSmO+Cg=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[RFC PATCH v2 01/22] libcamera: controls: Strings are arrays","Date":"Mon, 21 Jul 2025 12:46:01 +0200","Message-ID":"<20250721104622.1550908-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20250721104622.1550908-1-barnabas.pocze@ideasonboard.com>","References":"<20250721104622.1550908-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`ControlId::isArray()` and `ControlValue::isArray()` disagree\nin the case of strings. Fix it by setting the static size of a\nstring to `libcamera::dynamic_extent` to denote a dynamically\nsized array-like value.\n\nOne unfortunate side effect of this change is that if there were\nstring controls (there are none at the moment), then `cam` would\ndisplay them with an extra `Size: n` annotation.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=255\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 2ae4ec3d4..b170e30cb 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -98,7 +98,7 @@ struct control_type {\n template<>\n struct control_type {\n \tstatic constexpr ControlType value = ControlTypeString;\n-\tstatic constexpr std::size_t size = 0;\n+\tstatic constexpr std::size_t size = libcamera::dynamic_extent;\n };\n \n template<>\n","prefixes":["RFC","v2","01/22"]}