{"id":23855,"url":"https://patchwork.libcamera.org/api/1.1/patches/23855/?format=json","web_url":"https://patchwork.libcamera.org/patch/23855/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250718144456.58625-2-mzamazal@redhat.com>","date":"2025-07-18T14:44:56","name":"[2/2] libcamera: software_isp: Reduce statistics image area","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"12a4727d6e61e8928489b438bd820d4b2e1ccdd2","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23855/mbox/","series":[{"id":5301,"url":"https://patchwork.libcamera.org/api/1.1/series/5301/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5301","date":"2025-07-18T14:44:55","name":"[1/2] libcamera: geometry: Add Rectangle::croppedBy","version":1,"mbox":"https://patchwork.libcamera.org/series/5301/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23855/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23855/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39CECBE175\n\tfor ;\n\tFri, 18 Jul 2025 14:45:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5A6A68FB4;\n\tFri, 18 Jul 2025 16:45:11 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 578576150F\n\tfor ;\n\tFri, 18 Jul 2025 16:45:09 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-299-iHATKgruO7a26qk7BEgjpg-1;\n\tFri, 18 Jul 2025 10:45:04 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 1A1121800447; Fri, 18 Jul 2025 14:45:04 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.221])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8688C1801712; Fri, 18 Jul 2025 14:45:02 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cqFP/CIE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1752849908;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=vavI5ipw1nzH1uvaA64T7bVHg4u4UPlVtb2Tsmj1Mhw=;\n\tb=cqFP/CIE4wSXwJ/JtHXWJ+oO+7S30HmWGSONJcCKpy2AyyPd3q+QRXZuqPs6u5ARAOJJYx\n\t/7zDidZ60sN+ssruPuuRUeJFbBqwlvm0yRPNXIRZF2BWgjT9v17uQbd99zCZw0FhV0GlX3\n\tMbkklDudxw1w5DP4/g8yvZYMRNoUDtM=","X-MC-Unique":"iHATKgruO7a26qk7BEgjpg-1","X-Mimecast-MFC-AGG-ID":"iHATKgruO7a26qk7BEgjpg_1752849904","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tBryan O'Donoghue ","Subject":"[PATCH 2/2] libcamera: software_isp: Reduce statistics image area","Date":"Fri, 18 Jul 2025 16:44:56 +0200","Message-ID":"<20250718144456.58625-2-mzamazal@redhat.com>","In-Reply-To":"<20250718144456.58625-1-mzamazal@redhat.com>","References":"<20250718144456.58625-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"RJwoks73POEI8ZLiyvxDAjeKaDDhg0o3sHU7VRi1nlE_1752849904","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The statistics in software ISP is computed basically over the whole\nimage area, although only on part of the pixels. It is not necessary to\ncover the whole image area, it's sufficient to compute the statistics\nlet's say over the central area of 2/3 of the image width and height,\nwhich should be both sufficient and faster. The speedup is not that\nimportant with the CPU implementation but it may save CPU work\nmore noticeably with GPU debayering implementation.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/debayer_egl.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 9ec966608..534e36050 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -393,8 +393,11 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \twindow_.width = outputCfg.size.width;\n \twindow_.height = outputCfg.size.height;\n \n-\t/* Don't pass x,y since process() already adjusts src before passing it */\n-\tstats_->setWindow(Rectangle(window_.size()));\n+\t/*\n+\t * Don't pass x,y since process() already adjusts src before passing it.\n+\t * But reduce the width and height by 2/3 for speedup.\n+\t */\n+\tstats_->setWindow(Rectangle(window_.size()).croppedBy(2, 3));\n \n \tLOG(Debayer, Debug) << \"Input width \" << inputCfg.size.width << \" height \" << inputCfg.size.height;\n \tLOG(Debayer, Debug) << \"Output width \" << outputCfg.size.width << \" height \" << outputCfg.size.height;\n","prefixes":["2/2"]}