{"id":23832,"url":"https://patchwork.libcamera.org/api/1.1/patches/23832/?format=json","web_url":"https://patchwork.libcamera.org/patch/23832/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250716204625.3221592-1-ballway@chromium.org>","date":"2025-07-16T20:46:20","name":"libcamera: android: Add optional mirrored value for config","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"99632e70ce681c8efa49509e1c0e8c6e625a039e","submitter":{"id":236,"url":"https://patchwork.libcamera.org/api/1.1/people/236/?format=json","name":"Allen Ballway","email":"ballway@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23832/mbox/","series":[{"id":5292,"url":"https://patchwork.libcamera.org/api/1.1/series/5292/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5292","date":"2025-07-16T20:46:20","name":"libcamera: android: Add optional mirrored value for config","version":1,"mbox":"https://patchwork.libcamera.org/series/5292/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23832/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23832/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D5D0C3237\n\tfor ;\n\tWed, 16 Jul 2025 21:03:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CB5568F75;\n\tWed, 16 Jul 2025 23:03:33 +0200 (CEST)","from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n\t[IPv6:2607:f8b0:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7116568F70\n\tfor ;\n\tWed, 16 Jul 2025 22:46:33 +0200 (CEST)","by mail-pf1-x42a.google.com with SMTP id\n\td2e1a72fcca58-748e63d4b05so242628b3a.2\n\tfor ;\n\tWed, 16 Jul 2025 13:46:33 -0700 (PDT)","from ballway23.lan ([136.27.48.153])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-74eb9f8dbf1sm14207521b3a.152.2025.07.16.13.46.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 16 Jul 2025 13:46:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"E1Ch5RcT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1752698791; x=1753303591;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=R+0tIS4niq/b/UNCOC/4RrBFsISOXx3f38P7cGXLamY=;\n\tb=E1Ch5RcT+nAw74N5yhDyXebgIKIhnXhSlxJmd6g8b/Ko30UcWTULALIaCmwySCsi4Z\n\tA+tWeDohSP43zAzM75kkiJ9BeVRYLmnAStrAmqSmcrMAQjxlASPdN6c/DD6AYTT/1mi1\n\tRMeuyVOfZTXD29b3NIU0Aefmbe+4H/RFb3rgQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1752698791; x=1753303591;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=R+0tIS4niq/b/UNCOC/4RrBFsISOXx3f38P7cGXLamY=;\n\tb=Kkth8mRfbyewiI8W6aM+dzO7une2AKXTLhSPdzTGDhp9/svER7Hs7PpjEi5Ak6xHJT\n\tkCocsUULLt5hWIKAarJHGvtfhPtb8LIpd6z5l14M3mOPDlEbOsqPGAxvldV360nAdKb6\n\tbbnKekncGUf7kgUK7HpVwku+DceIiyMAZcCziFBYzygQ7o6zT5EPQ0g5CgSRHJYMpJjG\n\teN0gXf2Uq1kxlGsV3s5nlu5DCaMgzFjVtbE4R5FHxH3aQ7UAoofSgVx4FSBjZA/GWf3J\n\tBbcEAIFRouVyXXlJf1RlZ6AjIq7lgN04t88SwuWimvpTGYwJF3PDddj5KAPQC70jzdso\n\tEyiA==","X-Gm-Message-State":"AOJu0YzoigtkUE7zphPUHGi/Ooq6FlHjPhWCBNpPk2cD7YqL74dbgfMb\n\tFcSLwVCTVBtSu1Pg6X3yOwFl1qDeHx0GPc0oIbBUerF27V/KFi/7v6W8Uk1yj6VCZ9E+X+Mv6eX\n\tZ/VI=","X-Gm-Gg":"ASbGncs7OaiW1re55jJ9TiiZCgwHiXfRK9QfzZxSzm+0H8daJtSKaB76+EA/k/zdmdK\n\tQ5ed1Mh5ABZ+qE4gjNq6L3b6eF/t4lDjEuptxCx7YAugDF+wUjBalHSJZAboSQEE4wqcSEhk9w+\n\t8vGdQDm5LoxpbHNg8r17uc+JIB7+daEfgYdpKfohGSvCD1KAqJLxYZq/u9dk5X60U52sXI9L3iS\n\tJ54DfwMw85oyo3wZTrMit6V+85DuGYlyIgxO8bNLzmSud/QtHYx3+3FLgz/5TuFH7V2jk4sWF0W\n\tOyn2eV1s5jKmuq5EKUBzEVqZ67fFx3E7Q5g2P6CZmqEkeDQdJZCf2WF3X9e6VOJPgGE/TH2oZ4P\n\tSzFUBEu2hIyF5ES51hKO5S9Ce","X-Google-Smtp-Source":"AGHT+IHSfTJmdWVKXBPcZmVi/U9uILNdHbWrug9jK8YHttzJ3QHEZlIe685u+cgDmTYjLiQK1ng7zg==","X-Received":"by 2002:a05:6a00:2d08:b0:74c:efae:ffae with SMTP id\n\td2e1a72fcca58-75722376ce1mr4371993b3a.5.1752698791546; \n\tWed, 16 Jul 2025 13:46:31 -0700 (PDT)","From":"Allen Ballway ","To":"libcamera-devel@lists.libcamera.org","Cc":"hanlinchen@chromium.org,\n\tAllen Ballway ","Subject":"[PATCH] libcamera: android: Add optional mirrored value for config","Date":"Wed, 16 Jul 2025 13:46:20 -0700","Message-ID":"<20250716204625.3221592-1-ballway@chromium.org>","X-Mailer":"git-send-email 2.50.0.727.gbf7dc18ff4-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Wed, 16 Jul 2025 23:03:32 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Adds an optional `mirrored` value to the HAL config, which is used to modify\nthe `orientation` of the camera config. No rotation is used, so it can\nonly set the orientation to `Orientation::Rotate0Mirror`.\n\nThis enables sensors which are incorrectly mirrored to be corrected.\n\nSigned-off-by: Allen Ballway \n---\n src/android/camera_device.cpp | 6 ++++++\n src/android/camera_device.h | 1 +\n src/android/camera_hal_config.cpp | 14 ++++++++++++++\n src/android/camera_hal_config.h | 1 +\n 4 files changed, 22 insertions(+)\n\n--\n2.50.0.727.gbf7dc18ff4-goog","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 80ff248c2..b20e9f3db 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -377,6 +377,7 @@ int CameraDevice::initialize(const CameraConfigData *cameraConfigData)\n \t\torientation_ = 0;\n \t}\n\n+\tmirrored_ = cameraConfigData && cameraConfigData->mirrored;\n \treturn capabilities_.initialize(camera_, orientation_, facing_);\n }\n\n@@ -547,6 +548,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\treturn -EINVAL;\n \t}\n\n+\t// Rotation is unsupported, so if mirrored just set orientation.\n+\tif (mirrored_) {\n+\t\tconfig->orientation = Orientation::Rotate0Mirror;\n+\t}\n+\n \t/*\n \t * Clear and remove any existing configuration from previous calls, and\n \t * ensure the required entries are available without further\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 194ca3030..d304a1285 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -126,6 +126,7 @@ private:\n\n \tint facing_;\n \tint orientation_;\n+\tint mirrored_;\n\n \tCameraMetadata lastSettings_;\n };\ndiff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 7ef451ef8..a2beba5d3 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -33,6 +33,7 @@ private:\n \tint parseCameraConfigData(const std::string &cameraId, const YamlObject &);\n \tint parseLocation(const YamlObject &, CameraConfigData &cameraConfigData);\n \tint parseRotation(const YamlObject &, CameraConfigData &cameraConfigData);\n+\tint parseMirrored(const YamlObject &, CameraConfigData &cameraConfigData);\n\n \tstd::map *cameras_;\n };\n@@ -106,6 +107,9 @@ int CameraHalConfig::Private::parseCameraConfigData(const std::string &cameraId,\n \tif (parseRotation(cameraObject, cameraConfigData))\n \t\treturn -EINVAL;\n\n+\t/* Parse optional property \"mirrored\" */\n+\tparseMirrored(cameraObject, cameraConfigData);\n+\n \treturn 0;\n }\n\n@@ -145,6 +149,16 @@ int CameraHalConfig::Private::parseRotation(const YamlObject &cameraObject,\n \treturn 0;\n }\n\n+int CameraHalConfig::Private::parseMirrored(const YamlObject &cameraObject,\n+\t\t\t\t\t CameraConfigData &cameraConfigData)\n+{\n+\tif (!cameraObject.contains(\"mirrored\"))\n+\t\treturn -EINVAL;\n+\n+\tcameraConfigData.mirrored = cameraObject[\"mirrored\"].get(false);\n+\treturn 0;\n+}\n+\n CameraHalConfig::CameraHalConfig()\n \t: Extensible(std::make_unique()), exists_(false), valid_(false)\n {\ndiff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h\nindex a4bedb6e6..a96190470 100644\n--- a/src/android/camera_hal_config.h\n+++ b/src/android/camera_hal_config.h\n@@ -15,6 +15,7 @@\n struct CameraConfigData {\n \tint facing = -1;\n \tint rotation = -1;\n+\tbool mirrored = false;\n };\n\n class CameraHalConfig final : public libcamera::Extensible\n","prefixes":[]}