{"id":23806,"url":"https://patchwork.libcamera.org/api/1.1/patches/23806/?format=json","web_url":"https://patchwork.libcamera.org/patch/23806/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250715023013.16435-1-uajain@igalia.com>","date":"2025-07-15T02:30:13","name":"libcamera: pipeline: Always generate valid camera configurations","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"b748cc355bf807e4c54e49f79aadbbb1ab7bb92a","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/1.1/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23806/mbox/","series":[{"id":5286,"url":"https://patchwork.libcamera.org/api/1.1/series/5286/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5286","date":"2025-07-15T02:30:13","name":"libcamera: pipeline: Always generate valid camera configurations","version":1,"mbox":"https://patchwork.libcamera.org/series/5286/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23806/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23806/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EC09C3237\n\tfor ;\n\tTue, 15 Jul 2025 02:30:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1251868F51;\n\tTue, 15 Jul 2025 04:30:10 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EC176150E\n\tfor ;\n\tTue, 15 Jul 2025 04:30:07 +0200 (CEST)","from [49.36.69.57] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ubVQj-00Geqv-Nl; Tue, 15 Jul 2025 04:30:06 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Z9YMERTE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=TQ7UORyXH2fv777JiE6oKZSfRGLyw1dEGXMiVklfqkw=;\n\tb=Z9YMERTEgqg9p1RxC1U1/UhRX+\n\tI1TmqgvtjgMtOKRlPEjWE378e46Bleua94gJdHeejDtLit83wQ/Zk4av1PoI1JxN1TfXkUh1hA3/B\n\taePkPE5CWz3LYDrTEzTpjEP5KB1lPGBwS5cB8ZCYo3M5gPAH0GgRxOStfNYbpoHKPWSqH7ZwI48Fu\n\tuKT4RjGbH50HHcNe4UNw55V130ObE35nYNJFO3N95NCjE7WlyHLragkOR09DPaDBQoTiuAR4MAogX\n\tISMFW3SAYx/hYv8ya75hzQm6UF6V+q/mkwsh9h7ENbVJqu/BVJ+h5eVmkJGrxFU31PVxfEwnh3SUa\n\tlpWfmkaQ==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH] libcamera: pipeline: Always generate valid camera\n\tconfigurations","Date":"Tue, 15 Jul 2025 08:00:13 +0530","Message-ID":"<20250715023013.16435-1-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"PipelineHandler::generateConfiguration() documentation states the\nfollowing:\n\n * \\return A valid CameraConfiguration if the requested roles can be\n * satisfied, or a null pointer otherwise.\n */\n\nHence, always check the return status of config->validate(), during\ngenerateConfiguration() call in each pipeline handler.\n\nSigned-off-by: Umang Jain \n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 3 ++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 ++-\n src/libcamera/pipeline/vimc/vimc.cpp | 3 ++-\n 5 files changed, 10 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex f4014b95..c96fefa4 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -798,7 +798,8 @@ PipelineHandlerISI::generateConfiguration(Camera *camera,\n \t\tconfig->addConfiguration(cfg);\n \t}\n \n-\tconfig->validate();\n+\tif (config->validate() == CameraConfiguration::Invalid)\n+\t\treturn nullptr;\n \n \treturn config;\n }\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a74..fca1c74e 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -787,7 +787,8 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\tconfig->addConfiguration(cfg);\n \t}\n \n-\tconfig->validate();\n+\tif (config->validate() == CameraConfiguration::Invalid)\n+\t\treturn nullptr;\n \n \treturn config;\n }\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex efb07051..f994106e 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1322,7 +1322,8 @@ SimplePipelineHandler::generateConfiguration(Camera *camera, SpanaddConfiguration(cfg);\n \t}\n \n-\tconfig->validate();\n+\tif (config->validate() == CameraConfiguration::Invalid)\n+\t\treturn nullptr;\n \n \treturn config;\n }\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 4b5816df..9ed85f3b 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -250,7 +250,8 @@ PipelineHandlerUVC::generateConfiguration(Camera *camera,\n \n \tconfig->addConfiguration(cfg);\n \n-\tconfig->validate();\n+\tif (config->validate() == CameraConfiguration::Invalid)\n+\t\treturn nullptr;\n \n \treturn config;\n }\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 07273bd2..56719fa3 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -245,7 +245,8 @@ PipelineHandlerVimc::generateConfiguration(Camera *camera,\n \n \tconfig->addConfiguration(cfg);\n \n-\tconfig->validate();\n+\tif (config->validate() == CameraConfiguration::Invalid)\n+\t\treturn nullptr;\n \n \treturn config;\n }\n","prefixes":[]}