{"id":23755,"url":"https://patchwork.libcamera.org/api/1.1/patches/23755/?format=json","web_url":"https://patchwork.libcamera.org/patch/23755/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250707085520.39777-7-stefan.klug@ideasonboard.com>","date":"2025-07-07T08:55:09","name":"[v3,6/9] pipeline: rkisp1: Add error log when parameter queuing fails","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9c86de3ce4c5050a0f99bbcb6733be129f414363","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23755/mbox/","series":[{"id":5273,"url":"https://patchwork.libcamera.org/api/1.1/series/5273/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5273","date":"2025-07-07T08:55:03","name":"Wdr preparations","version":3,"mbox":"https://patchwork.libcamera.org/series/5273/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23755/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23755/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA49BC3237\n\tfor ;\n\tMon, 7 Jul 2025 08:55:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B7C068EA4;\n\tMon, 7 Jul 2025 10:55:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC1DE68E8A\n\tfor ;\n\tMon, 7 Jul 2025 10:55:51 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c79f:85df:e7f5:4c31])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5544E190D; \n\tMon, 7 Jul 2025 10:55:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OO4C9ELG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751878525;\n\tbh=pSRWs5of3Y5tIEYObKitIetZEo4u3lD+WU/iyyCe/98=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OO4C9ELGYRFSz8x0sYtzNe7UuVE/kQfRF6XNhEC+b59ChBxAb2rJJHUVpXiARPryt\n\tgtx0sDdQe7qu6chhiWUpbIzR2V6HfVPmIEpmOj0L212JtMPusIdSkgOUF8N6/5QeVt\n\tdoaZ0YagIm+XiUxHRpaA6YwoJ/Hlb/NpcW4TKRzY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v3 6/9] pipeline: rkisp1: Add error log when parameter\n\tqueuing fails","Date":"Mon, 7 Jul 2025 10:55:09 +0200","Message-ID":"<20250707085520.39777-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>","References":"<20250707085520.39777-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a error statement when quieing of the parameter buffer fails for\nwhatever reason.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n\n---\n\nChanges in v3:\n- Collected tags\n- Removed hint regarding unsupported parameter types as this will be\n handled using the now upstreamed RKISP1_CID_SUPPORTED_PARAMS_BLOCKS.\n\nChanges in v2:\n- Also print the error code in case of failure\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a7490a6..d5bb8aced3c8 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -411,7 +411,14 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\treturn;\n \n \tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n-\tpipe->param_->queueBuffer(info->paramBuffer);\n+\n+\tint ret = pipe->param_->queueBuffer(info->paramBuffer);\n+\tif (ret < 0) {\n+\t\tLOG(RkISP1, Error) << \"Failed to queue parameter buffer: \"\n+\t\t\t\t << strerror(-ret);\n+\t\treturn;\n+\t}\n+\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n \tif (info->mainPathBuffer)\n","prefixes":["v3","6/9"]}