{"id":23746,"url":"https://patchwork.libcamera.org/api/1.1/patches/23746/?format=json","web_url":"https://patchwork.libcamera.org/patch/23746/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250707075400.9079-4-stefan.klug@ideasonboard.com>","date":"2025-07-07T07:53:37","name":"[v2,3/5] pipeline: rkisp1: Limit the maximum number of buffers queued in","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"84dc1eebd12557dcc5dbe669e4e8e8ab250d9698","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23746/mbox/","series":[{"id":5272,"url":"https://patchwork.libcamera.org/api/1.1/series/5272/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5272","date":"2025-07-07T07:53:34","name":"rkisp1: Allow usage of more than 4 buffers","version":2,"mbox":"https://patchwork.libcamera.org/series/5272/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23746/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23746/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 755CCC3237\n\tfor ;\n\tMon, 7 Jul 2025 07:54:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E69E68E8C;\n\tMon, 7 Jul 2025 09:54:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5447068E81\n\tfor ;\n\tMon, 7 Jul 2025 09:54:21 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c79f:85df:e7f5:4c31])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B08BD526;\n\tMon, 7 Jul 2025 09:53:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GPnrQ+0O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751874834;\n\tbh=+uVycowaiQOfCa898u9FWdwTkf07+tJWQlC/ayNmqOY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GPnrQ+0OucW+GrHkcOR1d2KpOZmhjbqbuJ4qfzlBL4Syq9exXClDiLtuneLsoAu5o\n\tLAtAcXezT9dfQB7WxS4b07FOHJttZzrQhwCAGRjdPv7q9bkR872LxxoZWdbJ8uGYic\n\tl7SZGZvZtFV0cCEJ8yemW+F2zyxZ1jNlZJVyBaVo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 3/5] pipeline: rkisp1: Limit the maximum number of buffers\n\tqueued in","Date":"Mon, 7 Jul 2025 09:53:37 +0200","Message-ID":"<20250707075400.9079-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250707075400.9079-1-stefan.klug@ideasonboard.com>","References":"<20250707075400.9079-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To keep the regulation of the algorithms as short as possible and to\nallow more buffers to be created than the v4l2 device allows to be queued,\nlimit the amount of buffers that get queued into the device to the pipeline depth.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v1:\n- Replaced function overload with constructor param\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a7490a6..fff42359cbff 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -155,6 +155,12 @@ private:\n \tTransform combinedTransform_;\n };\n \n+namespace {\n+\n+const unsigned int kPipelineDepth = 4;\n+\n+} // namespace\n+\n class PipelineHandlerRkISP1 : public PipelineHandler\n {\n public:\n@@ -684,7 +690,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n */\n \n PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n-\t: PipelineHandler(manager), hasSelfPath_(true), useDewarper_(false)\n+\t: PipelineHandler(manager, kPipelineDepth), hasSelfPath_(true), useDewarper_(false)\n {\n }\n \n","prefixes":["v2","3/5"]}