{"id":237,"url":"https://patchwork.libcamera.org/api/1.1/patches/237/?format=json","web_url":"https://patchwork.libcamera.org/patch/237/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190115151849.1547-6-laurent.pinchart@ideasonboard.com>","date":"2019-01-15T15:18:46","name":"[libcamera-devel,v2,5/8] libcamera: event_dispatcher_poll: Constify argument to processNotifiers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5a3f0efd31fd0a5fba666298cad6a4a8915720bd","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/237/mbox/","series":[{"id":81,"url":"https://patchwork.libcamera.org/api/1.1/series/81/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=81","date":"2019-01-15T15:18:41","name":"Pipeline handler refactoring and assorted improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/81/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/237/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/237/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B92CD60C8A\n\tfor ;\n\tTue, 15 Jan 2019 16:18:54 +0100 (CET)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3788F55C\n\tfor ;\n\tTue, 15 Jan 2019 16:18:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547565534;\n\tbh=86w73yrQP8oVbkVs6Ize57x9ATcWJzgN7QUsWxdYHzg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BV0ZTb0Dy8JswujkQ+nSoCic6cawwdr/mHn23pCEf3q9iv3d1TnbwCMX57HHpv6Ey\n\tNlFmlWoXhJ1mBMSSOxEx1FWElpLiqVLorlsZ6P8ISD3cJzcuYjBfhROcsI/ShyEuxW\n\tG3PD5m9UQzspJJdrKAhfM3CHFath2zlDuh6mkK+U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Jan 2019 17:18:46 +0200","Message-Id":"<20190115151849.1547-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>","References":"<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/8] libcamera: event_dispatcher_poll:\n\tConstify argument to processNotifiers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 15:18:55 -0000"},"content":"The EventDispatcherPoll::processNotifiers() function doesn't modify the\nargument it receives, make it const.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/event_dispatcher_poll.cpp | 2 +-\n src/libcamera/include/event_dispatcher_poll.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\nindex a497a7fe9177..69edfcbf2725 100644\n--- a/src/libcamera/event_dispatcher_poll.cpp\n+++ b/src/libcamera/event_dispatcher_poll.cpp\n@@ -173,7 +173,7 @@ short EventDispatcherPoll::EventNotifierSetPoll::events() const\n \treturn events;\n }\n \n-void EventDispatcherPoll::processNotifiers(std::vector &pollfds)\n+void EventDispatcherPoll::processNotifiers(const std::vector &pollfds)\n {\n \tstatic const struct {\n \t\tEventNotifier::Type type;\ndiff --git a/src/libcamera/include/event_dispatcher_poll.h b/src/libcamera/include/event_dispatcher_poll.h\nindex 30fd58506d6b..a41926e11a11 100644\n--- a/src/libcamera/include/event_dispatcher_poll.h\n+++ b/src/libcamera/include/event_dispatcher_poll.h\n@@ -41,7 +41,7 @@ private:\n \tstd::map notifiers_;\n \tstd::list timers_;\n \n-\tvoid processNotifiers(std::vector &pollfds);\n+\tvoid processNotifiers(const std::vector &pollfds);\n \tvoid processTimers();\n };\n \n","prefixes":["libcamera-devel","v2","5/8"]}