{"id":23669,"url":"https://patchwork.libcamera.org/api/1.1/patches/23669/?format=json","web_url":"https://patchwork.libcamera.org/patch/23669/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250627074208.49872-3-uajain@igalia.com>","date":"2025-06-27T07:42:08","name":"[2/2] libcamera: gstreamer: Report mounting-rotation of camera sensor","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"fea6a35692c258b65797b187cdf24037124f987e","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/1.1/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23669/mbox/","series":[{"id":5253,"url":"https://patchwork.libcamera.org/api/1.1/series/5253/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5253","date":"2025-06-27T07:42:07","name":"gstreamer: Report mounting-rotation of camera sensor","version":1,"mbox":"https://patchwork.libcamera.org/series/5253/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23669/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23669/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E28B3C3237\n\tfor ;\n\tFri, 27 Jun 2025 07:42:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C7B368DFC;\n\tFri, 27 Jun 2025 09:42:15 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CC2068DF6\n\tfor ;\n\tFri, 27 Jun 2025 09:42:09 +0200 (CEST)","from [49.36.69.141] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uV3iq-009IWh-Az; Fri, 27 Jun 2025 09:42:08 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Ydvda+/2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=yAGDdktLSnopHQCFyDN/BK/qWVUnJYrVXmxRyRoC2R0=;\n\tb=Ydvda+/22Km4PnROd4h/LJm6pV\n\tTrRnkElZ8JbPU0kwR/+xxSKljafd6JuIEQ5lGQA0U2+cHPP9MFGHN0qBB3YN6X14mGuKlm7GecZF3\n\tbPZ3pMPg3iCQ/5Tjs7aLS9wDuKFIv0Z16Pm193F1jkMeQsCDxZNFLcgVT/DcDCSG5MjzFlgYLRC85\n\tXEugN/fZb/eU7nBzoLWGkl0+vtL2M70qZmGNyfch4zQdq2m7CkEDx4SHM8A/RkfNJ0JMhn/jduSIt\n\tOdtIkqlrBJzLW3cP/Vhu4ug97PehMi1PEPjtl/MmkthQ7Gh3eBKxY17qHiUof8OuYGnFkvikDzQ+F\n\trIV1yXbA==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Giacomo Cappellini ,\n\tNicolas Dufresne , Umang Jain ","Subject":"[PATCH 2/2] libcamera: gstreamer: Report mounting-rotation of camera\n\tsensor","Date":"Fri, 27 Jun 2025 13:12:08 +0530","Message-ID":"<20250627074208.49872-3-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.0","In-Reply-To":"<20250627074208.49872-1-uajain@igalia.com>","References":"<20250627074208.49872-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report mounting-rotation of the camera sensor by reading the\nproperty::Rotation property from libcamera. This is reported\nin GstDevice properties for libcamerasrc element.\n\nSigned-off-by: Umang Jain \n---\n src/gstreamer/gstlibcameraprovider.cpp | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 5da96ea3..806a149a 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -12,6 +12,7 @@\n \n #include \n #include \n+#include \n \n #include \"gstlibcamerasrc.h\"\n #include \"gstlibcamera-utils.h\"\n@@ -131,6 +132,8 @@ gst_libcamera_device_new(const std::shared_ptr &camera)\n \tstatic const std::array roles{ StreamRole::VideoRecording };\n \tg_autoptr(GstCaps) caps = gst_caps_new_empty();\n \tconst gchar *name = camera->id().c_str();\n+\tstd::string rotation_str;\n+\tbool success;\n \n \tstd::unique_ptr config = camera->generateConfiguration(roles);\n \tif (!config || config->size() != roles.size()) {\n@@ -144,12 +147,23 @@ gst_libcamera_device_new(const std::shared_ptr &camera)\n \t\t\tgst_caps_append(caps, sub_caps);\n \t}\n \n+\tconst int32_t rotation = camera->properties().get(properties::Rotation).value_or(0);\n+\tOrientation mountingOrientation = orientationFromRotation(rotation, &success);\n+\trotation_str = success ? orientationToString(mountingOrientation)\n+\t\t\t : std::to_string(rotation);\n+\n+\tg_autoptr(GstStructure) props =\n+\t\tgst_structure_new(\"camera-properties\",\n+\t\t\t\t \"mounting-rotation\", G_TYPE_STRING, rotation_str.c_str(),\n+\t\t\t\t nullptr);\n+\n \treturn GST_DEVICE(g_object_new(GST_TYPE_LIBCAMERA_DEVICE,\n \t\t\t\t /* \\todo Use a unique identifier instead of camera name. */\n \t\t\t\t \"name\", name,\n \t\t\t\t \"display-name\", name,\n \t\t\t\t \"caps\", caps,\n \t\t\t\t \"device-class\", \"Source/Video\",\n+\t\t\t\t \"properties\", props,\n \t\t\t\t nullptr));\n }\n \n","prefixes":["2/2"]}