{"id":23611,"url":"https://patchwork.libcamera.org/api/1.1/patches/23611/?format=json","web_url":"https://patchwork.libcamera.org/patch/23611/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250620124452.557855-4-naush@raspberrypi.com>","date":"2025-06-20T12:42:24","name":"[v1,3/8] ipa: rpi: controller: AutoFocus weighting tweak","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8122476753d5a04ce9a54ad5f1a2cdea352ebe8d","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23611/mbox/","series":[{"id":5235,"url":"https://patchwork.libcamera.org/api/1.1/series/5235/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5235","date":"2025-06-20T12:42:21","name":"Raspberry Pi: AF improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5235/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23611/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23611/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6590BDE6B\n\tfor ;\n\tFri, 20 Jun 2025 12:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B8BC68DF8;\n\tFri, 20 Jun 2025 14:45:07 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D217B68DE9\n\tfor ;\n\tFri, 20 Jun 2025 14:44:59 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-4530e6f4db4so721425e9.2\n\tfor ;\n\tFri, 20 Jun 2025 05:44:59 -0700 (PDT)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45361461375sm41561525e9.14.2025.06.20.05.44.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 Jun 2025 05:44:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HfV76mwc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1750423499; x=1751028299;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7EfgoST468pTOcCeNOjVH8kfATETd/PEr3m+VpAYBV0=;\n\tb=HfV76mwcaIwsMl9JkkXdZBGkpqDvNwaHlnOEF5d1+jO+gkwRUF0BTg6+G5nUYpad0+\n\t1kOPp2KAKNCmDC3iUxIckHzWUq779knnvyRxDPO6ownfGIFs7D+j+weDppqmoNyV61lK\n\tmLkhOAzII6wI15IYc3LatdWDrFw/yeU8Gnns4zROgPG2HfxeDubZNuyqSz9QOCPmELKR\n\tBgOIOUvzEBeiffiEGb+aJhJ3Io1f4VAHgSVt22RXgiJHSi5PZ8gBTJ6t8pwPOuFkcxkG\n\t4dT6zIDr/LFOG6jaSzAS9uuZQM3UyHZNhd5IEV0ZHCSUh8Lv4+VIQNSgqDYKOasU9cCE\n\tK2mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1750423499; x=1751028299;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7EfgoST468pTOcCeNOjVH8kfATETd/PEr3m+VpAYBV0=;\n\tb=ADnguLDiRCGLjorg6cCqWxm8mIQYoSzMxWWBWB76K94l3sfyCqgnAOP65DlzStwlTd\n\tUCx1WQcXDMwsaIBajRs+kDGZ5KHbYEimpcf+Qq3Y4J8ostqPyCPXkCRt5A7r0NaxoT/t\n\tFoFHhlU1hPq2tPmNZXFea+SI97s1nziRIcZXTaCWRjLWVxrn8qsseIKrXvbRXmYn1AIB\n\tkdS+mVhgrhnLetjCG2NBiNImLUPs+hpDxCdVA3sI96xIHSsgDf4pq/NxMQUt02/g8+co\n\tlNk0RhsfeHBZ+Amvmm7rgUOtzLoUQSwJmuSAY6l/i3DX4zJDwRToWuJkt1AyWGVPVxnk\n\tiMTg==","X-Gm-Message-State":"AOJu0YwlqrrvjUjiz+dG4qgBJFun727MNkHjk9AkWltsK444PJ+g/VkZ\n\tAJDW7/xkrsSfs2wlYiZaTYm2aG6jr2mBFZehvQUTpojRqpMFnucjDUwfv4twTk7Xob5GGPKEGMO\n\t1R4XD","X-Gm-Gg":"ASbGnctr7/i8DAi18IPP9XRiPE0VSpgQ5kiM6cFMzxEx5nJWWr8E4lREnEmmfnBnWso\n\tkIAN3j+LS2IMV40coY0wfC9qZsM/e0qzT1jnyY14TtT9KVoLa5jdmKmrUhlRJVhlSNTB9Ge7R/C\n\tv9WvktVRqnS7HVWkQASwdAJZ5xlKubGWIfQwVwhwvUwQXrfGkOnCrSHRO9Ny/KqlaUC/6c4NxRb\n\tG+RoknWyoOWJoFjuqDnqtJ3uXqlm2Vo/o3buwGv2pZ6nd6WRtv1Mn7gbiNoHbX3XoIGlxNOPxo9\n\tZY2ECw1n1HBG4dXVEqxWYivr9SNOzxKTTqCGFTmJ62exmNvJL3vFEi/vYSXmzF+0CNU2WBQyMJq\n\tR/4860A==","X-Google-Smtp-Source":"AGHT+IF9wwYwGwYNbkAajQ1zS+nRolfRzaKEe6S2d2c3N6e7wmajiq4JO2r4PHKFVbnQDaf+tS/5Ig==","X-Received":"by 2002:a05:600c:c042:b0:451:df07:f41e with SMTP id\n\t5b1f17b1804b1-45367307cd9mr3191595e9.1.1750423499015; \n\tFri, 20 Jun 2025 05:44:59 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nick Hollinghurst ,\n\tNaushir Patuck ","Subject":"[PATCH v1 3/8] ipa: rpi: controller: AutoFocus weighting tweak","Date":"Fri, 20 Jun 2025 13:42:24 +0100","Message-ID":"<20250620124452.557855-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250620124452.557855-1-naush@raspberrypi.com>","References":"<20250620124452.557855-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nick Hollinghurst \n\nIn getPhase(), stop using different weights for sumWc and sumWcp.\nThis should improve linearity e.g. in earlyTerminationByPhase().\nPhases are slightly larger but confidence values slightly reduced.\n\nSigned-off-by: Nick Hollinghurst \nSigned-off-by: Naushir Patuck \nReviewed-by: Naushir Patuck \n---\n src/ipa/rpi/controller/rpi/af.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/af.cpp b/src/ipa/rpi/controller/rpi/af.cpp\nindex 8df614ed7b6b..5304f54ca967 100644\n--- a/src/ipa/rpi/controller/rpi/af.cpp\n+++ b/src/ipa/rpi/controller/rpi/af.cpp\n@@ -328,9 +328,8 @@ bool Af::getPhase(PdafRegions const ®ions, double &phase, double &conf)\n \t\t\tif (c >= cfg_.confThresh) {\n \t\t\t\tif (c > cfg_.confClip)\n \t\t\t\t\tc = cfg_.confClip;\n-\t\t\t\tc -= (cfg_.confThresh >> 2);\n+\t\t\t\tc -= (cfg_.confThresh >> 1);\n \t\t\t\tsumWc += w * c;\n-\t\t\t\tc -= (cfg_.confThresh >> 2);\n \t\t\t\tsumWcp += (int64_t)(w * c) * (int64_t)data.phase;\n \t\t\t}\n \t\t}\n","prefixes":["v1","3/8"]}