{"id":23562,"url":"https://patchwork.libcamera.org/api/1.1/patches/23562/?format=json","web_url":"https://patchwork.libcamera.org/patch/23562/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","date":"2025-06-13T14:37:19","name":"[v1] apps: common: image: Fix assertion","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"77fc44e7a2747cfa4572da0a9a03651f1115660f","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23562/mbox/","series":[{"id":5219,"url":"https://patchwork.libcamera.org/api/1.1/series/5219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5219","date":"2025-06-13T14:37:19","name":"[v1] apps: common: image: Fix assertion","version":1,"mbox":"https://patchwork.libcamera.org/series/5219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23562/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23562/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A24A2BDE6B\n\tfor ;\n\tFri, 13 Jun 2025 14:37:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D2968DBE;\n\tFri, 13 Jun 2025 16:37:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD86668DB4\n\tfor ;\n\tFri, 13 Jun 2025 16:37:22 +0200 (CEST)","from pb-laptop.local (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DB0BED\n\tfor ;\n\tFri, 13 Jun 2025 16:37:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Me8D864H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749825433;\n\tbh=Z2bqb7uXmHIDN9oo4SUmy/nJK0knNTeRQZlE681uTKA=;\n\th=From:To:Subject:Date:From;\n\tb=Me8D864HYDYLVOOse6sApDEEAJKHDsmQDMZBxyc41p6JqYijaFVzLt+CZbJSXDc+B\n\tO8dystiIs72TXDnPzMQYNZ0GPJD4fe2nlRZk/y6fsB2gBYmexsfwWObRYzNsNrQsxz\n\tFbVH4s2zDQhSaoyaAJ7iH/7BPxVYInnoumIwv9fg=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] apps: common: image: Fix assertion","Date":"Fri, 13 Jun 2025 16:37:19 +0200","Message-ID":"<20250613143719.1131707-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`plane` must be strictly less than the vector's size,\nit cannot be equal to it.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/common/image.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/common/image.cpp b/src/apps/common/image.cpp\nindex a2a0f58f3..9a67238aa 100644\n--- a/src/apps/common/image.cpp\n+++ b/src/apps/common/image.cpp\n@@ -98,12 +98,12 @@ unsigned int Image::numPlanes() const\n \n Span Image::data(unsigned int plane)\n {\n-\tassert(plane <= planes_.size());\n+\tassert(plane < planes_.size());\n \treturn planes_[plane];\n }\n \n Span Image::data(unsigned int plane) const\n {\n-\tassert(plane <= planes_.size());\n+\tassert(plane < planes_.size());\n \treturn planes_[plane];\n }\n","prefixes":["v1"]}