{"id":23537,"url":"https://patchwork.libcamera.org/api/1.1/patches/23537/?format=json","web_url":"https://patchwork.libcamera.org/patch/23537/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611013245.133785-32-bryan.odonoghue@linaro.org>","date":"2025-06-11T01:32:41","name":"[31/35] libcamera: shaders: Extend bayer shaders to support swapping R and B on output","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c2b0388f24b2d1f17f8c3ee9c8d91441a4acc897","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23537/mbox/","series":[{"id":5212,"url":"https://patchwork.libcamera.org/api/1.1/series/5212/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5212","date":"2025-06-11T01:32:10","name":"Add GLES 2.0 GPUISP to libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5212/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23537/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23537/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DEE8CC3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:34:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56E7C68DCA;\n\tWed, 11 Jun 2025 03:34:31 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 690A368DFA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:34:28 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-43edecbfb46so51413495e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:34:28 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OpQN7zJ6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605668; x=1750210468;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=3H9DGvojUoUk5Y3iEb9uuLwH3EKoTXsq6B1yGjTZ7oo=;\n\tb=OpQN7zJ6oIxWpsFXX8QtyOyNy/CUsN9lHBuFyoxt6t9mDsE1ApaOBWF/+prLbuaUiB\n\twYkd/PjJdnxE+b2QIB4Axcx5dEw7QVxpOj8u5ElV6lrELXsHqZeWPcOawsyF6BLB8khU\n\tBKY4lg+KcuC4qTtsdXZNxs0hycig3NUkKLPJwsRHYRphWGmPpMz6MRjZwiNa3v3nc9R2\n\tVFQcPfQdNlqqtD1J6REuyCuyqPhgQNkI5tPI4Oi/3prYSYgi8ibLLulU/yu+31PwjC5r\n\tl4ILxPjF9uEGRRKEQH7OnDR1+wnwC/yfKv7ACdwxIHxtjM4IKvqDaF3DfkQOIo36C/05\n\tlA4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605668; x=1750210468;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=3H9DGvojUoUk5Y3iEb9uuLwH3EKoTXsq6B1yGjTZ7oo=;\n\tb=DO0mnUgJGt50jIVicvm/a8FnZCyPNywotmKZOx3S2P3Cw2hAnCtQ99+LF+6Ww7Tb3/\n\t1PZ2fXFPcBIKx0VZKaSbX+TjLB2q4HkoVzA6KjxeiTU9UuxM0e2QW7n1HigNaYnqoaxO\n\tiSEuo9oJCgMABGwVw2TnrEOTU1GTX/W6F8FpWbdbON6HhY74+Yzz7vnw0Fm0e1oXZcJZ\n\tS1ZPjkUObjaa2i4wVDdJ943fDMt21zkm8suotJNE6qRGBToH57Wr9viV2k7Wcp+WMNpO\n\tdKuu1cdg3JCcyVDDsLr6PuHSe0UTF6Jo5oNJdtnTzHY/xeRtgQRowRXVloupmkzFc53N\n\t4cgg==","X-Gm-Message-State":"AOJu0Yw8HfjmyGyvL1K0xUH4O4WNoqUe+tXIGMbeC/kJd+vK2fecg13q\n\tnDoSq3aWx9GocXolQlOCIt5WFYxdpadtYobEgHx16B59kuz6zrcvFnTXoOCMKKWkQqn+2pGuObE\n\tA3NmqMM4=","X-Gm-Gg":"ASbGncsMvddBYzEFHw9KWN9cGPHZreLAQuV8TDJTJ2f4v1R2u7/CrcVNTCUnaP34ERv\n\tWFtT0XE4FhOoNveXG/SLdJJzNzLjx1ouedWBfQv1fOy9Uwh4PguhOB2e6Z6R5Bk9+vkAviYccrC\n\tq3cRq/KCmWWe2kN3q9ppKy9we0hL1ldWnRj+VJkVIdMeeDvKQ0BBkLahR8FrHuFyspZqJ5VsMdV\n\tCrwvBWmveLFWNmj+DlD6wwp+2QoqDL4DBp1dhbtqEcP86u/rZ5PA7dBC13utwsEr7+bpzvEBvab\n\tVnwOkVrrjWoKE1ISqMJkV+UqegIim84jgL+2gGnKInO++L4Ql0tSCOtPQiWAByBRCpdgD47qzsr\n\ttH4QwsjP6P+CNVMoMpHBQPpKlwb6s/ICmYTj4HJMkpQ==","X-Google-Smtp-Source":"AGHT+IELh4LjuV6Y6UU0QJ5FVZOa8NqfSBPQSUHfJRNQNJY/uDLfeYZlOMMqs53qRcX1Dl5gXmbylg==","X-Received":"by 2002:a05:600c:4f41:b0:453:6ca:16a6 with SMTP id\n\t5b1f17b1804b1-45324edf307mr7946645e9.10.1749605667801; \n\tTue, 10 Jun 2025 18:34:27 -0700 (PDT)","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","Subject":"[PATCH 31/35] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output","Date":"Wed, 11 Jun 2025 02:32:41 +0100","Message-ID":"<20250611013245.133785-32-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++\n include/libcamera/internal/shaders/bayer_8.frag         | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex 90bd6457..c0632eb1 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -268,5 +268,9 @@ void main(void)\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_8.frag\nindex 5955c2ea..74ce1509 100644\n--- a/include/libcamera/internal/shaders/bayer_8.frag\n+++ b/include/libcamera/internal/shaders/bayer_8.frag\n@@ -163,5 +163,9 @@ void main(void) {\n \trgb.b = texture2D(red_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n-    gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+\tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n","prefixes":["31/35"]}