{"id":23533,"url":"https://patchwork.libcamera.org/api/1.1/patches/23533/?format=json","web_url":"https://patchwork.libcamera.org/patch/23533/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611013245.133785-28-bryan.odonoghue@linaro.org>","date":"2025-06-11T01:32:37","name":"[27/35] libcamera: software_isp: debayer_egl: Convert from identity CCM to CCM calculated by SoftIPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3d78fbde53034e454346d59106c80232b7d57532","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23533/mbox/","series":[{"id":5212,"url":"https://patchwork.libcamera.org/api/1.1/series/5212/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5212","date":"2025-06-11T01:32:10","name":"Add GLES 2.0 GPUISP to libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5212/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23533/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23533/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24D16BDE6B\n\tfor ;\n\tWed, 11 Jun 2025 01:34:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9395968DF4;\n\tWed, 11 Jun 2025 03:34:19 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33F9768DBD\n\tfor ;\n\tWed, 11 Jun 2025 03:34:16 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-450cb2ddd46so36245245e9.2\n\tfor ;\n\tTue, 10 Jun 2025 18:34:16 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"VegyqQd4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605655; x=1750210455;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Y+rhqXuB1F9aT3Pl3A23g+gsKVe9C5G7edD32dZ1KTo=;\n\tb=VegyqQd4MAZpSIt+CFVsIHEfxr1IfvBaOleCgG76DbDWQJF2nXJT5P8jdwQkSYhYaA\n\t2Kk+mmu3jCio9lcGSgltWXKD6wF+/ShX1ClqtXI1fy2Pj7Rf+R095v5QR3MNSKTRf2sB\n\tLtmFcSRCrPKphZgXYBIx8poE1/Yd0H078vhNRIv2n3gMZfzcvL3+4jJyH6i/ychezjEL\n\tFsGG0dF2WSjMLbNY/i41yMIMYOpKsIkMtpSVBzLw5RoYv9ATCmYzY1iJo9TY0869E9zf\n\tiqlu0D7vGCSWu+v5/0llKqt6ffhbOMXcpLsWvt8Q+k6zJz/n6XUFMRuZGDXV9xqpol+8\n\tiZiQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605655; x=1750210455;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Y+rhqXuB1F9aT3Pl3A23g+gsKVe9C5G7edD32dZ1KTo=;\n\tb=qktWHcMeJ2aQyN5bD68PU8lPeYQQP109MXkUYzDMOV26t0bT86NDsCFw09qi1egSJB\n\t4qdX/+okjucMoIDq6oQIdgjAEQxlmplbk0GDZvUGUjONiGLTZ04h+6dxvKauo19xQ8xw\n\tEK8r1al16hfnandKTvCwcyoTRxFqObIz3FkP9LleAAEBqDw5z4ZktFd+X+FqeYGvZtgY\n\tE9ScN0KGEQyK19Cg+hEO8Iwb+8DHMhnNMBmEpEgLzrJjzCgQRepU6SbCjzUUTcPK8pEb\n\tDqk1bPgxVz+90okyO4H3DtcGvyk1GpY5tuC+hSGL3AOqw8RkT/ZcpZ2nk6v6CmpDdlSV\n\tiERQ==","X-Gm-Message-State":"AOJu0Yx9ITe09AP4HH/dRmot67sstYXy7r9mlBYUb4DNqJ+RhqIFFab4\n\tfnt+UbBCMPd8sCmXl/BInwcNT1XKkjbzQfH8HLapJyDU/0EfKaGffQRQNh2X4xnEnsIpbI8vbDM\n\tK1R5MPiE=","X-Gm-Gg":"ASbGnctPqZ8Diw1YLf/poBXn+c6fVtpZjBALK9T5ccZS/nvroyf8UgucHvJMWGe7TWb\n\tp4h07Lt7pLnfS7de2UQYplKwJe7eBSg1yHIru9RHnpWsu5ax+NCdHvDI7vUWCm9tEwRCwycaUyb\n\tjAVNnBzALMtkkU3WbJ1bV2tBsi8j5MjMEd18BAjcD6+xlFPvfHMfg4D8uwhwn+8+dGPJQaqoDzy\n\tQhBLfQXTvdhBsBCojrXboS201pi1tNVECXRdt+Mj4KtvOC7wB9ydmuYzYCNxuFS5s9QrIOH+a8/\n\tqefUJ1vWDvVZVKic7T3m1XvD2FSggvZuGuyf0YBiux9PTlMCHhJgDHAlhJdvivlfHITa9/6HiaP\n\tmnlZI8kEscy4XdJX8HEN3MEqxHRXx8D2DVNs0WcLBhg==","X-Google-Smtp-Source":"AGHT+IFltwPxkkKbGEd3eZMG1+KWhnD+YsKhPkr40/sW/fULcqx4Z/8yWVH3E4tdgsj2riTkTP/XLg==","X-Received":"by 2002:a05:6000:2087:b0:3a5:52cc:346e with SMTP id\n\tffacd0b85a97d-3a55868917fmr783441f8f.6.1749605655527; \n\tTue, 10 Jun 2025 18:34:15 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","Subject":"[PATCH 27/35] libcamera: software_isp: debayer_egl: Convert from\n\tidentity CCM to CCM calculated by SoftIPA","Date":"Wed, 11 Jun 2025 02:32:37 +0100","Message-ID":"<20250611013245.133785-28-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer_egl.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 824cd6d3..b30d2107 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -293,7 +293,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \tinputConfig_.stride = inputCfg.stride;\n \twidth_ = inputCfg.size.width;\n \theight_ = inputCfg.size.height;\n-\tccmEnabled_ = ccmEnabled = true;\n+\tccmEnabled_ = ccmEnabled;\n \n \tif (outputCfgs.size() != 1) {\n \t\tLOG(Debayer, Error)\n@@ -511,10 +511,10 @@ void DebayerEGL::debayerGPU(MappedFrameBuffer &in, MappedFrameBuffer &out, Debay\n \n \t// Populate bayer parameters\n \tif (ccmEnabled_) {\n-\t\tGLfloat ccm[] = {\n-\t\t\t1, 0, 0,\n-\t\t\t0, 1, 0,\n-\t\t\t0, 0, 1,\n+\t\tGLfloat ccm[9] = {\n+\t\t\tparams.ccm[0][0], params.ccm[0][1], params.ccm[0][2],\n+\t\t\tparams.ccm[1][0], params.ccm[1][1], params.ccm[1][2],\n+\t\t\tparams.ccm[2][0], params.ccm[2][1], params.ccm[2][2],\n \t\t};\n \t\tglUniformMatrix3fv(ccmUniformDataIn_, 1, GL_FALSE, ccm);\n \t} else {\n","prefixes":["27/35"]}