{"id":23529,"url":"https://patchwork.libcamera.org/api/1.1/patches/23529/?format=json","web_url":"https://patchwork.libcamera.org/patch/23529/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250611013245.133785-24-bryan.odonoghue@linaro.org>","date":"2025-06-11T01:32:33","name":"[23/35] libcamera: software_isp: debayer_egl: Add an eGL debayer class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5d9f851c5d65fa06fcba9516adb5bc07cefa036b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23529/mbox/","series":[{"id":5212,"url":"https://patchwork.libcamera.org/api/1.1/series/5212/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5212","date":"2025-06-11T01:32:10","name":"Add GLES 2.0 GPUISP to libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5212/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23529/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23529/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C44FC3327\n\tfor ;\n\tWed, 11 Jun 2025 01:34:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1136E68DE8;\n\tWed, 11 Jun 2025 03:34:10 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8F1668DDC\n\tfor ;\n\tWed, 11 Jun 2025 03:34:05 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-451d6ade159so52325025e9.1\n\tfor ;\n\tTue, 10 Jun 2025 18:34:05 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XviWcG+t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605645; x=1750210445;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=cbeLiX9T9eWhRxg9hz31JNa42SKGxGnkWbDuxjfPeW8=;\n\tb=XviWcG+tlCKJMh6n7/V+rDmE9FBRQU61q2JIlcst3R/0/spsUuHDxJqfOSaklWN7Z0\n\tAMWWFEea4jytnKnPu5wSoIzUqIPSe94UIo8YfbPpD2ZddX3KMT+W+bNPdo4x0jZ0ClMJ\n\thSAKnIwS00W2TmG2GbhG016PNzaiAhPF0QdEFQSmD0AWGFmBn1EMyoRPrAl9PFtzaQq9\n\te7i0E1ZOlJlERnlZvJgnOvySRSATo5IzCJ2Jf6+vS2clnb9aN/WNxi6yYCb/s9a5bQi3\n\tjj/AnQWNF5450IKFrXAT7SHMrFERQIt+Z7kBB9u5IYymnhe0ntlIdcnT6z+kl9fPB+ce\n\tSeWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605645; x=1750210445;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cbeLiX9T9eWhRxg9hz31JNa42SKGxGnkWbDuxjfPeW8=;\n\tb=IoVEvpxMUGsSTgoqBMKRMSdTWkjxq2JldkvKsP+79Q+akNeAnv+R2QhavvPNeilm3J\n\tF8U7yrMf4ubVYT7QqcGr0DlWD32ONWETr+Xd5d5qlGvHdkekYV+joEnPAMYcuJhnsv16\n\t/UT4zxiLirji76c75xSazMoZdaV+14CmxVTRs601sRjfzsBsBWXjlUJHsmDwUI6tmob8\n\tXS+jkGzyTnztromOUtIqspVoJXVMoecjX4LUir8SAGwuJBmghpUqXD4ffCHBtBeViJfK\n\tuYoOz/ZUtjECMGAM4PYKuy58ysIJrn3zzxetTH9cMPGPIZGk9bSrEO9gRbFnTMqO5wDb\n\t8/gg==","X-Gm-Message-State":"AOJu0Ywo71bQgzPS0zrwsQfvkVuffk/KCvvP6lEM5WSb1HzsfwskhKsf\n\tISndxctLeFsx0En9PQkQ34/do1iT5+WRXYxJWthBeRHQgkDteYAjRG07rXa36/J2kqTYwg6SCoI\n\tOdggRkoA=","X-Gm-Gg":"ASbGncuBWWW86VP/y+QFLzSCQrzyjUxVBdLm7t/vmdPqF619Jn1ZyYRSRC5tPGy9Wwu\n\tLw/ttFFHgmHJ34EA2MPBDM4mEuJ1OdXw9J7AsT6szrqFq0379HgDOqsTb026xny0fi+p0wn8KUd\n\tyKnIR6tRH6ABFBLfZExriFh3Ub4LGAvEyB+PaDS8taADDweGKPh2wZ4PnxGAI2qWn+Ecij9ZvQP\n\tbWXTDf7s4ApjWf5iXuuvwfkDQ0ejPoevifWAPBNQFhMi//EWtquArV2rCClhQZYhLdI8LcoUgY2\n\tFve+hfsSq48QgYvVwMltWaTrBWbHpXpiPfiqFPrXO4gjHJpqZrSDZyJ7hBW1bKmm0Z5SIanqKqo\n\ttSTzO2CSubQ01R9ZU+w6//Cv5VNcvRx+OF2p2hPg9qg==","X-Google-Smtp-Source":"AGHT+IGmuXq2a199kSr/EN0+RFjLmqzX6THHny4qqEuwdRT71SNSoMaCl6TGWmoQ6WxH+yqDNvrFLw==","X-Received":"by 2002:a05:600c:35c9:b0:440:61eb:2ce5 with SMTP id\n\t5b1f17b1804b1-453248c7edfmr9793225e9.17.1749605644845; \n\tTue, 10 Jun 2025 18:34:04 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","Subject":"[PATCH 23/35] libcamera: software_isp: debayer_egl: Add an eGL\n\tdebayer class","Date":"Wed, 11 Jun 2025 02:32:33 +0100","Message-ID":"<20250611013245.133785-24-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","References":"<20250611013245.133785-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a class to run the existing glsl debayer shaders on a GBM surface.\n\nSigned-off-by: Bryan O'Donoghue \n\nlibcamera: software_isp: debayer_egl: Extend logic to enable application of softISP RGB debayer params\n\nThe existing SoftISP calculates RGB gain values as a lookup table of 256\nvalues which shifts for each frame depending on the required correction.\n\nWe can pass the required tables into the debayer shaders as textures, one\ntexture for R, G and B respectively.\n\nThe debayer shader will do its debayer interpolation and then if the\nappropriate define is specified use the calculated R, G and B values as\nindexes into our bayer colour gain table.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/egl.cpp | 4 +-\n src/libcamera/software_isp/debayer_egl.cpp | 587 +++++++++++++++++++++\n src/libcamera/software_isp/debayer_egl.h | 164 ++++++\n src/libcamera/software_isp/meson.build | 8 +\n 4 files changed, 761 insertions(+), 2 deletions(-)\n create mode 100644 src/libcamera/software_isp/debayer_egl.cpp\n create mode 100644 src/libcamera/software_isp/debayer_egl.h","diff":"diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 89ece148..c6b0f9a5 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -82,13 +82,13 @@ void eGL::destroyDMABufTexture(eGLImage *eglImage)\n \n //\n // Generate a 2D texture from an input buffer directly\n-void eGL::createTexture2D(eGLImage *eglImage, uint32_t width, uint32_t height, void *data)\n+void eGL::createTexture2D(eGLImage *eglImage, GLint format, uint32_t width, uint32_t height, void *data)\n {\n \tglActiveTexture(eglImage->texture_unit_);\n \tglBindTexture(GL_TEXTURE_2D, eglImage->texture_);\n \n \t// Generate texture, bind, associate image to texture, configure, unbind\n-\tglTexImage2D(GL_TEXTURE_2D, 0, GL_LUMINANCE, width, height, 0, GL_LUMINANCE, GL_UNSIGNED_BYTE, data);\n+\tglTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, format, GL_UNSIGNED_BYTE, data);\n \n \t// Nearest filtering\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nnew file mode 100644\nindex 00000000..3fb15511\n--- /dev/null\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -0,0 +1,587 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * debayer_cpu.cpp - EGL based debayering class\n+ */\n+\n+#include \n+#include \n+#include \n+\n+#include \n+\n+#include \"libcamera/internal/glsl_shaders.h\"\n+#include \"debayer_egl.h\"\n+\n+namespace libcamera {\n+\n+DebayerEGL::DebayerEGL(std::unique_ptr stats)\n+\t: Debayer(), stats_(std::move(stats))\n+{\n+\teglImageBayerIn_ = eglImageRedLookup_ = eglImageBlueLookup_ = eglImageGreenLookup_ = NULL;\n+}\n+\n+DebayerEGL::~DebayerEGL()\n+{\n+\tif (eglImageBlueLookup_)\n+\t\tdelete eglImageBlueLookup_;\n+\n+\tif (eglImageGreenLookup_)\n+\t\tdelete eglImageGreenLookup_;\n+\n+\tif (eglImageRedLookup_)\n+\t\tdelete eglImageRedLookup_;\n+\n+\tif (eglImageBayerIn_)\n+\t\tdelete eglImageBayerIn_;\n+}\n+\n+int DebayerEGL::getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config)\n+{\n+\tBayerFormat bayerFormat =\n+\t\tBayerFormat::fromPixelFormat(inputFormat);\n+\n+\tif ((bayerFormat.bitDepth == 8 || bayerFormat.bitDepth == 10) &&\n+\t bayerFormat.packing == BayerFormat::Packing::None &&\n+\t isStandardBayerOrder(bayerFormat.order)) {\n+\t\tconfig.bpp = (bayerFormat.bitDepth + 7) & ~7;\n+\t\tconfig.patternSize.width = 2;\n+\t\tconfig.patternSize.height = 2;\n+\t\tconfig.outputFormats = std::vector({ formats::XRGB8888,\n+\t\t\t\t\t\t\t\t formats::ARGB8888,\n+\t\t\t\t\t\t\t\t formats::XBGR8888,\n+\t\t\t\t\t\t\t\t formats::ABGR8888 });\n+\t\treturn 0;\n+\t}\n+\n+\tif (bayerFormat.bitDepth == 10 &&\n+\t bayerFormat.packing == BayerFormat::Packing::CSI2 &&\n+\t isStandardBayerOrder(bayerFormat.order)) {\n+\t\tconfig.bpp = 10;\n+\t\tconfig.patternSize.width = 4; /* 5 bytes per *4* pixels */\n+\t\tconfig.patternSize.height = 2;\n+\t\tconfig.outputFormats = std::vector({ formats::XRGB8888,\n+\t\t\t\t\t\t\t\t formats::ARGB8888,\n+\t\t\t\t\t\t\t\t formats::XBGR8888,\n+\t\t\t\t\t\t\t\t formats::ABGR8888 });\n+\t\treturn 0;\n+\t}\n+\n+\tLOG(Debayer, Info)\n+\t\t<< \"Unsupported input format \" << inputFormat.toString();\n+\treturn -EINVAL;\n+}\n+\n+int DebayerEGL::getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config)\n+{\n+\tif (outputFormat == formats::XRGB8888 || outputFormat == formats::ARGB8888 ||\n+\t outputFormat == formats::XBGR8888 || outputFormat == formats::ABGR8888) {\n+\t\tconfig.bpp = 32;\n+\t\treturn 0;\n+\t}\n+\n+\tLOG(Debayer, Error)\n+\t\t<< \"Unsupported output format \" << outputFormat.toString();\n+\n+\treturn -EINVAL;\n+}\n+\n+int DebayerEGL::getShaderVariableLocations(void)\n+{\n+\tattributeVertex_ = glGetAttribLocation(programId_, \"vertexIn\");\n+\tattributeTexture_ = glGetAttribLocation(programId_, \"textureIn\");\n+\n+\ttextureUniformBayerDataIn_ = glGetUniformLocation(programId_, \"tex_y\");\n+\ttextureUniformRedLookupDataIn_ = glGetUniformLocation(programId_, \"red_param\");\n+\ttextureUniformGreenLookupDataIn_ = glGetUniformLocation(programId_, \"green_param\");\n+\ttextureUniformBlueLookupDataIn_ = glGetUniformLocation(programId_, \"blue_param\");\n+\n+\ttextureUniformStep_ = glGetUniformLocation(programId_, \"tex_step\");\n+\ttextureUniformSize_ = glGetUniformLocation(programId_, \"tex_size\");\n+\ttextureUniformStrideFactor_ = glGetUniformLocation(programId_, \"stride_factor\");\n+\ttextureUniformBayerFirstRed_ = glGetUniformLocation(programId_, \"tex_bayer_first_red\");\n+\ttextureUniformProjMatrix_ = glGetUniformLocation(programId_, \"proj_matrix\");\n+\n+\tLOG(Debayer, Debug) << \"vertexIn \" << attributeVertex_ << \" textureIn \" << attributeTexture_\n+\t\t\t << \" tex_y \" << textureUniformBayerDataIn_\n+\t\t\t << \" red_param \" << textureUniformRedLookupDataIn_\n+\t\t\t << \" green_param \" << textureUniformGreenLookupDataIn_\n+\t\t\t << \" blue_param \" << textureUniformBlueLookupDataIn_\n+\t\t\t << \" tex_step \" << textureUniformStep_\n+\t\t\t << \" tex_size \" << textureUniformSize_\n+\t\t\t << \" stride_factor \" << textureUniformStrideFactor_\n+\t\t\t << \" tex_bayer_first_red \" << textureUniformBayerFirstRed_\n+\t\t\t << \" proj_matrix \" << textureUniformProjMatrix_;\n+\treturn 0;\n+}\n+\n+int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat)\n+{\n+\tstd::vector shaderEnv;\n+\tunsigned int fragmentShaderDataLen;\n+\tunsigned char *fragmentShaderData;\n+\tunsigned int vertexShaderDataLen;\n+\tunsigned char *vertexShaderData;\n+\tGLenum err;\n+\n+\t// Target gles 100 glsl requires \"#version x\" as first directive in shader\n+\tegl_.pushEnv(shaderEnv, \"#version 100\");\n+\n+\t// Specify GL_OES_EGL_image_external\n+\tegl_.pushEnv(shaderEnv, \"#extension GL_OES_EGL_image_external: enable\");\n+\n+\t// Tell shaders how to re-order output taking account of how the\n+\t// pixels are actually stored by GBM\n+\tswitch (outputFormat) {\n+\tcase formats::ARGB8888:\n+\tcase formats::XRGB8888:\n+\t\tbreak;\n+\tcase formats::ABGR8888:\n+\tcase formats::XBGR8888:\n+\t\tegl_.pushEnv(shaderEnv, \"#define SWAP_BLUE\");\n+\t\tbreak;\n+\tdefault:\n+\t\tgoto invalid_fmt;\n+\t}\n+\n+\t// Pixel location parameters\n+\tswitch (inputFormat) {\n+\tcase libcamera::formats::SBGGR8:\n+\tcase libcamera::formats::SBGGR10_CSI2P:\n+\tcase libcamera::formats::SBGGR12_CSI2P:\n+\t\tfirstRed_x_ = 1.0;\n+\t\tfirstRed_y_ = 1.0;\n+\t\tbreak;\n+\tcase libcamera::formats::SGBRG8:\n+\tcase libcamera::formats::SGBRG10_CSI2P:\n+\tcase libcamera::formats::SGBRG12_CSI2P:\n+\t\tfirstRed_x_ = 0.0;\n+\t\tfirstRed_y_ = 1.0;\n+\t\tbreak;\n+\tcase libcamera::formats::SGRBG8:\n+\tcase libcamera::formats::SGRBG10_CSI2P:\n+\tcase libcamera::formats::SGRBG12_CSI2P:\n+\t\tfirstRed_x_ = 1.0;\n+\t\tfirstRed_y_ = 0.0;\n+\t\tbreak;\n+\tcase libcamera::formats::SRGGB8:\n+\tcase libcamera::formats::SRGGB10_CSI2P:\n+\tcase libcamera::formats::SRGGB12_CSI2P:\n+\t\tfirstRed_x_ = 0.0;\n+\t\tfirstRed_y_ = 0.0;\n+\t\tbreak;\n+\tdefault:\n+\t\tgoto invalid_fmt;\n+\t\tbreak;\n+\t};\n+\n+\t// Shader selection\n+\tswitch (inputFormat) {\n+\tcase libcamera::formats::SBGGR8:\n+\tcase libcamera::formats::SGBRG8:\n+\tcase libcamera::formats::SGRBG8:\n+\tcase libcamera::formats::SRGGB8:\n+\t\tfragmentShaderData = bayer_8_frag;\n+\t\tfragmentShaderDataLen = bayer_8_frag_len;\n+\t\tvertexShaderData = bayer_8_vert;\n+\t\tvertexShaderDataLen = bayer_8_vert_len;\n+\t\tbreak;\n+\tcase libcamera::formats::SBGGR10_CSI2P:\n+\tcase libcamera::formats::SGBRG10_CSI2P:\n+\tcase libcamera::formats::SGRBG10_CSI2P:\n+\tcase libcamera::formats::SRGGB10_CSI2P:\n+\t\tegl_.pushEnv(shaderEnv, \"#define RAW10P\");\n+\t\tfragmentShaderData = bayer_1x_packed_frag;\n+\t\tfragmentShaderDataLen = bayer_1x_packed_frag_len;\n+\t\tvertexShaderData = identity_vert;\n+\t\tvertexShaderDataLen = identity_vert_len;\n+\t\tbreak;\n+\tcase libcamera::formats::SBGGR12_CSI2P:\n+\tcase libcamera::formats::SGBRG12_CSI2P:\n+\tcase libcamera::formats::SGRBG12_CSI2P:\n+\tcase libcamera::formats::SRGGB12_CSI2P:\n+\t\tegl_.pushEnv(shaderEnv, \"#define RAW12P\");\n+\t\tfragmentShaderData = bayer_1x_packed_frag;\n+\t\tfragmentShaderDataLen = bayer_1x_packed_frag_len;\n+\t\tvertexShaderData = identity_vert;\n+\t\tvertexShaderDataLen = identity_vert_len;\n+\t\tbreak;\n+\tdefault:\n+\t\tgoto invalid_fmt;\n+\t\tbreak;\n+\t};\n+\n+\t// Flag to shaders that we have parameter gain tables\n+\tegl_.pushEnv(shaderEnv, \"#define APPLY_RGB_PARAMETERS\");\n+\n+\tif (egl_.compileVertexShader(vertexShaderId_, vertexShaderData, vertexShaderDataLen, shaderEnv))\n+\t\tgoto compile_fail;\n+\n+\tif (egl_.compileFragmentShader(fragmentShaderId_, fragmentShaderData, fragmentShaderDataLen, shaderEnv))\n+\t\tgoto compile_fail;\n+\n+\tif (egl_.linkProgram(programId_, vertexShaderId_, fragmentShaderId_))\n+\t\tgoto link_fail;\n+\n+\tegl_.dumpShaderSource(vertexShaderId_);\n+\tegl_.dumpShaderSource(fragmentShaderId_);\n+\n+\t/* Ensure we set the programId_ */\n+\tegl_.useProgram(programId_);\n+\terr = glGetError();\n+\tif (err != GL_NO_ERROR)\n+\t\tgoto program_fail;\n+\n+\tif (getShaderVariableLocations())\n+\t\tgoto parameters_fail;\n+\n+\treturn 0;\n+\n+parameters_fail:\n+\tLOG(Debayer, Error) << \"Program parameters fail\";\n+\treturn -ENODEV;\n+\n+program_fail:\n+\tLOG(Debayer, Error) << \"Use program error \" << err;\n+\treturn -ENODEV;\n+\n+link_fail:\n+\tLOG(Debayer, Error) << \"Linking program fail\";\n+\treturn -ENODEV;\n+\n+compile_fail:\n+\tLOG(Debayer, Error) << \"Compile debayer shaders fail\";\n+\treturn -ENODEV;\n+\n+invalid_fmt:\n+\tLOG(Debayer, Error) << \"Unsupported input output format combination\";\n+\treturn -EINVAL;\n+}\n+\n+int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n+\t\t\t const std::vector> &outputCfgs,\n+\t\t\t bool ccmEnabled)\n+{\n+\tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n+\t\treturn -EINVAL;\n+\n+\tif (stats_->configure(inputCfg) != 0)\n+\t\treturn -EINVAL;\n+\n+\tconst Size &stats_pattern_size = stats_->patternSize();\n+\tif (inputConfig_.patternSize.width != stats_pattern_size.width ||\n+\t inputConfig_.patternSize.height != stats_pattern_size.height) {\n+\t\tLOG(Debayer, Error)\n+\t\t\t<< \"mismatching stats and debayer pattern sizes for \"\n+\t\t\t<< inputCfg.pixelFormat.toString();\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tinputConfig_.stride = inputCfg.stride;\n+\twidth_ = inputCfg.size.width;\n+\theight_ = inputCfg.size.height;\n+\tccmEnabled_ = ccmEnabled = false;\n+\n+\tif (outputCfgs.size() != 1) {\n+\t\tLOG(Debayer, Error)\n+\t\t\t<< \"Unsupported number of output streams: \"\n+\t\t\t<< outputCfgs.size();\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tLOG(Debayer, Info) << \"Input size \" << inputCfg.size << \" stride \" << inputCfg.stride;\n+\n+\tif (gbmSurface_.initSurface(inputCfg.size.width, inputCfg.size.height))\n+\t\treturn -ENODEV;\n+\n+\tif (egl_.initEGLContext(&gbmSurface_))\n+\t\treturn -ENODEV;\n+\n+\tglGetIntegerv(GL_MAX_TEXTURE_IMAGE_UNITS, &maxTextureImageUnits);\n+\tLOG(Debayer, Debug) << \"Fragment shader maximum texture units \" << maxTextureImageUnits;\n+\n+\tif (maxTextureImageUnits < DEBAYER_EGL_MIN_SIMPLE_RGB_GAIN_TEXTURE_UNITS) {\n+\t\tLOG(Debayer, Error) << \"Fragment shader texture unit count \" << maxTextureImageUnits\n+\t\t\t\t << \" required minimum for RGB gain table lookup \" << DEBAYER_EGL_MIN_SIMPLE_RGB_GAIN_TEXTURE_UNITS\n+\t\t\t\t << \" try using an identity CCM \";\n+\t\treturn -ENODEV;\n+\t}\n+\t// Raw bayer input as texture\n+\teglImageBayerIn_ = new eGLImage(width_, height_, 32, GL_TEXTURE0, 0);\n+\tif (!eglImageBayerIn_)\n+\t\treturn -ENOMEM;\n+\n+\t/// RGB correction tables as 2d textures\n+\t// eGL doesn't support glTexImage1D so we do a little hack with 2D to compensate\n+\teglImageRedLookup_ = new eGLImage(DebayerParams::kRGBLookupSize, 1, 32, GL_TEXTURE1, 1);\n+\tif (!eglImageRedLookup_)\n+\t\treturn -ENOMEM;\n+\n+\teglImageGreenLookup_ = new eGLImage(DebayerParams::kRGBLookupSize, 1, 32, GL_TEXTURE2, 2);\n+\tif (!eglImageGreenLookup_)\n+\t\treturn -ENOMEM;\n+\n+\teglImageBlueLookup_ = new eGLImage(DebayerParams::kRGBLookupSize, 1, 32, GL_TEXTURE3, 3);\n+\tif (!eglImageBlueLookup_)\n+\t\treturn -ENOMEM;\n+\n+\t// Create a single BO (calling gbm_surface_lock_front_buffer() again before gbm_surface_release_buffer() would create another BO)\n+\tif (gbmSurface_.mapSurface())\n+\t\treturn -ENODEV;\n+\n+\tStreamConfiguration &outputCfg = outputCfgs[0];\n+\tSizeRange outSizeRange = sizes(inputCfg.pixelFormat, inputCfg.size);\n+\n+\toutputConfig_.stride = gbmSurface_.getStride();\n+\toutputConfig_.frameSize = gbmSurface_.getFrameSize();\n+\n+\tLOG(Debayer, Debug) << \"Overriding stream config stride \"\n+\t\t\t << outputCfg.stride << \" with GBM surface stride \"\n+\t\t\t << outputConfig_.stride;\n+\toutputCfg.stride = outputConfig_.stride;\n+\n+\tif (!outSizeRange.contains(outputCfg.size) || outputConfig_.stride != outputCfg.stride) {\n+\t\tLOG(Debayer, Error)\n+\t\t\t<< \"Invalid output size/stride: \"\n+\t\t\t<< \"\\n \" << outputCfg.size << \" (\" << outSizeRange << \")\"\n+\t\t\t<< \"\\n \" << outputCfg.stride << \" (\" << outputConfig_.stride << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\twindow_.x = ((inputCfg.size.width - outputCfg.size.width) / 2) &\n+\t\t ~(inputConfig_.patternSize.width - 1);\n+\twindow_.y = ((inputCfg.size.height - outputCfg.size.height) / 2) &\n+\t\t ~(inputConfig_.patternSize.height - 1);\n+\twindow_.width = outputCfg.size.width;\n+\twindow_.height = outputCfg.size.height;\n+\n+\t/* Don't pass x,y since process() already adjusts src before passing it */\n+\tstats_->setWindow(Rectangle(window_.size()));\n+\n+\tLOG(Debayer, Debug) << \"Input width \" << inputCfg.size.width << \" height \" << inputCfg.size.height;\n+\tLOG(Debayer, Debug) << \"Output width \" << outputCfg.size.width << \" height \" << outputCfg.size.height;\n+\tLOG(Debayer, Debug) << \"Output stride \" << outputCfg.size.width << \" height \" << outputCfg.size.height;\n+\n+\tif (initBayerShaders(inputCfg.pixelFormat, outputCfg.pixelFormat))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n+Size DebayerEGL::patternSize(PixelFormat inputFormat)\n+{\n+\tDebayerEGL::DebayerInputConfig config;\n+\n+\tif (getInputConfig(inputFormat, config) != 0)\n+\t\treturn {};\n+\n+\treturn config.patternSize;\n+}\n+\n+std::vector DebayerEGL::formats(PixelFormat inputFormat)\n+{\n+\tDebayerEGL::DebayerInputConfig config;\n+\n+\tif (getInputConfig(inputFormat, config) != 0)\n+\t\treturn std::vector();\n+\n+\treturn config.outputFormats;\n+}\n+\n+std::tuple\n+DebayerEGL::strideAndFrameSize(const PixelFormat &outputFormat, const Size &size)\n+{\n+\tDebayerEGL::DebayerOutputConfig config;\n+\n+\tif (getOutputConfig(outputFormat, config) != 0)\n+\t\treturn std::make_tuple(0, 0);\n+\n+\t/* round up to multiple of 8 for 64 bits alignment */\n+\tunsigned int stride = (size.width * config.bpp / 8 + 7) & ~7;\n+\n+\treturn std::make_tuple(stride, stride * size.height);\n+}\n+\n+void DebayerEGL::setShaderVariableValues(void)\n+{\n+\t/*\n+\t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n+\t * are stored in a GL_LUMINANCE texture. The texture width is\n+\t * equal to the stride.\n+\t */\n+\tGLfloat firstRed[] = { firstRed_x_, firstRed_y_ };\n+\tGLfloat imgSize[] = { (GLfloat)width_,\n+\t\t\t (GLfloat)height_ };\n+\tGLfloat Step[] = { 1.0f / (inputConfig_.stride - 1),\n+\t\t\t 1.0f / (height_ - 1) };\n+\tGLfloat Stride = 1.0f;\n+\tGLfloat projIdentityMatrix[] = {\n+\t\t1, 0, 0, 0,\n+\t\t0, 1, 0, 0,\n+\t\t0, 0, 1, 0,\n+\t\t0, 0, 0, 1\n+\t};\n+\n+\t// vertexIn - bayer_8.vert\n+\tglEnableVertexAttribArray(attributeVertex_);\n+\tglVertexAttribPointer(attributeVertex_, 2, GL_FLOAT, GL_TRUE,\n+\t\t\t 2 * sizeof(GLfloat), vcoordinates);\n+\n+\t// textureIn - bayer_8.vert\n+\tglEnableVertexAttribArray(attributeTexture_);\n+\tglVertexAttribPointer(attributeTexture_, 2, GL_FLOAT, GL_TRUE,\n+\t\t\t 2 * sizeof(GLfloat), tcoordinates);\n+\n+\t// Set the sampler2D to the respective texture unit for each texutre\n+\t// To simultaneously sample multiple textures we need to use multiple\n+\t// texture units\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformRedLookupDataIn_, eglImageRedLookup_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformGreenLookupDataIn_, eglImageGreenLookup_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBlueLookupDataIn_, eglImageBlueLookup_->texture_unit_uniform_id_);\n+\n+\t// These values are:\n+\t// firstRed = tex_bayer_first_red - bayer_8.vert\n+\t// imgSize = tex_size - bayer_8.vert\n+\t// step = tex_step - bayer_8.vert\n+\t// Stride = stride_factor identity.vert\n+\t// textureUniformProjMatri = No scaling\n+\tglUniform2fv(textureUniformBayerFirstRed_, 1, firstRed);\n+\tglUniform2fv(textureUniformSize_, 1, imgSize);\n+\tglUniform2fv(textureUniformStep_, 1, Step);\n+\tglUniform1f(textureUniformStrideFactor_, Stride);\n+\tglUniformMatrix4fv(textureUniformProjMatrix_, 1,\n+\t\t\t GL_FALSE, projIdentityMatrix);\n+\n+\tLOG(Debayer, Debug) << \"vertexIn \" << attributeVertex_ << \" textureIn \" << attributeTexture_\n+\t\t\t << \" tex_y \" << textureUniformBayerDataIn_\n+\t\t\t << \" red_param \" << textureUniformRedLookupDataIn_\n+\t\t\t << \" green_param \" << textureUniformGreenLookupDataIn_\n+\t\t\t << \" blue_param \" << textureUniformBlueLookupDataIn_\n+\t\t\t << \" tex_step \" << textureUniformStep_\n+\t\t\t << \" tex_size \" << textureUniformSize_\n+\t\t\t << \" stride_factor \" << textureUniformStrideFactor_\n+\t\t\t << \" tex_bayer_first_red \" << textureUniformBayerFirstRed_;\n+\n+\tLOG (Debayer, Debug) << \"textureUniformY_ = 0 \" <<\n+\t\t\t\t\" firstRed.x \" << firstRed[0] <<\n+\t\t\t\t\" firstRed.y \" << firstRed[1] <<\n+\t\t\t\t\" textureUniformSize_.width \" << imgSize[0] << \" \"\n+\t\t\t\t\" textureUniformSize_.height \" << imgSize[1] <<\n+\t\t\t\t\" textureUniformStep_.x \" << Step[0] <<\n+\t\t\t\t\" textureUniformStep_.y \" << Step[1] <<\n+\t\t\t\t\" textureUniformStrideFactor_ \" << Stride <<\n+\t\t\t\t\" textureUniformProjMatrix_ \" << textureUniformProjMatrix_;\n+\treturn;\n+}\n+\n+void DebayerEGL::debayerGPU(MappedFrameBuffer &in, MappedFrameBuffer &out, DebayerParams ¶ms)\n+{\n+\tLOG(Debayer, Debug)\n+\t\t<< \"Input height \" << height_\n+\t\t<< \" width \" << width_\n+\t\t<< \" fd \" << in.getPlaneFD(0);\n+\n+\t// eGL context switch\n+\tegl_.makeCurrent();\n+\n+\t// Greate a standard texture\n+\t// we will replace this with the DMA version at some point\n+\tegl_.createTexture2D(eglImageBayerIn_, inputConfig_.stride, height_, in.planes()[0].data());\n+\n+\t// Populate bayer parameters\n+\tegl_.createTexture2D(eglImageRedLookup_, DebayerParams::kRGBLookupSize, 1, ¶ms.red);\n+\tegl_.createTexture2D(eglImageGreenLookup_, DebayerParams::kRGBLookupSize, 1, ¶ms.green);\n+\tegl_.createTexture2D(eglImageBlueLookup_, DebayerParams::kRGBLookupSize, 1, ¶ms.blue);\n+\n+\t// Setup the scene\n+\tsetShaderVariableValues();\n+\tglViewport(0, 0, width_, height_);\n+\tglClear(GL_COLOR_BUFFER_BIT);\n+\tglDisable(GL_BLEND);\n+\n+\t// Draw the scene\n+\tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\n+\n+\t// eglclientWaitScynKhr / eglwaitsynckr ?\n+\tegl_.swapBuffers();\n+\n+\t// Copy from the output GBM buffer to our output plane\n+\t// once we get render to texture working the\n+\t// explicit lock ioctl, memcpy and unlock ioctl won't be required\n+\tgbmSurface_.getFrameBufferData(out.planes()[0].data(), out.planes()[0].size());\n+}\n+\n+void DebayerEGL::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n+{\n+\tbench_.startFrame();\n+\n+\tstd::vector dmaSyncers;\n+\n+\tdmaSyncBegin(dmaSyncers, input, output);\n+\n+\tsetParams(params);\n+\n+\t/* Copy metadata from the input buffer */\n+\tFrameMetadata &metadata = output->_d()->metadata();\n+\tmetadata.status = input->metadata().status;\n+\tmetadata.sequence = input->metadata().sequence;\n+\tmetadata.timestamp = input->metadata().timestamp;\n+\n+\tMappedFrameBuffer in(input, MappedFrameBuffer::MapFlag::Read);\n+\tMappedFrameBuffer out(output, MappedFrameBuffer::MapFlag::Write);\n+\tif (!in.isValid() || !out.isValid()) {\n+\t\tLOG(Debayer, Error) << \"mmap-ing buffer(s) failed\";\n+\t\tmetadata.status = FrameMetadata::FrameError;\n+\t\treturn;\n+\t}\n+\n+\tdebayerGPU(in, out, params);\n+\n+\tdmaSyncers.clear();\n+\n+\tbench_.finishFrame();\n+\n+\tmetadata.planes()[0].bytesused = out.planes()[0].size();\n+\n+\t// Calculate stats for the whole frame\n+\tstats_->processFrame(frame, 0, input);\n+\n+\toutputBufferReady.emit(output);\n+\tinputBufferReady.emit(input);\n+}\n+\n+SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)\n+{\n+\tSize patternSize = this->patternSize(inputFormat);\n+\tunsigned int borderHeight = patternSize.height;\n+\n+\tif (patternSize.isNull())\n+\t\treturn {};\n+\n+\t/* No need for top/bottom border with a pattern height of 2 */\n+\tif (patternSize.height == 2)\n+\t\tborderHeight = 0;\n+\n+\t/*\n+\t * For debayer interpolation a border is kept around the entire image\n+\t * and the minimum output size is pattern-height x pattern-width.\n+\t */\n+\tif (inputSize.width < (3 * patternSize.width) ||\n+\t inputSize.height < (2 * borderHeight + patternSize.height)) {\n+\t\tLOG(Debayer, Warning)\n+\t\t\t<< \"Input format size too small: \" << inputSize.toString();\n+\t\treturn {};\n+\t}\n+\n+\treturn SizeRange(Size(patternSize.width, patternSize.height),\n+\t\t\t Size((inputSize.width - 2 * patternSize.width) & ~(patternSize.width - 1),\n+\t\t\t (inputSize.height - 2 * borderHeight) & ~(patternSize.height - 1)),\n+\t\t\t patternSize.width, patternSize.height);\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nnew file mode 100644\nindex 00000000..c0fc220f\n--- /dev/null\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -0,0 +1,164 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2025, Bryan O'Donoghue.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * debayer_opengl.h - EGL debayer header\n+ */\n+\n+#pragma once\n+\n+#include \n+#include \n+#include \n+\n+#define GL_GLEXT_PROTOTYPES\n+#define EGL_EGLEXT_PROTOTYPES\n+#include \n+#include \n+#include \n+\n+#include \n+\n+#include \"debayer.h\"\n+\n+#include \"libcamera/internal/bayer_format.h\"\n+#include \"libcamera/internal/egl.h\"\n+#include \"libcamera/internal/framebuffer.h\"\n+#include \"libcamera/internal/mapped_framebuffer.h\"\n+#include \"libcamera/internal/software_isp/benchmark.h\"\n+#include \"libcamera/internal/software_isp/swstats_cpu.h\"\n+\n+namespace libcamera {\n+\n+#define DEBAYER_EGL_MIN_SIMPLE_RGB_GAIN_TEXTURE_UNITS 4\n+#define DEBAYER_OPENGL_COORDS 4\n+\n+/**\n+ * \\class DebayerEGL\n+ * \\brief Class for debayering using an EGL Shader\n+ *\n+ * Implements an EGL shader based debayering solution.\n+ */\n+class DebayerEGL : public Debayer\n+{\n+public:\n+\t/**\n+\t * \\brief Constructs a DebayerEGL object.\n+\t * \\param[in] stats Pointer to the stats object to use.\n+\t */\n+\tDebayerEGL(std::unique_ptr stats);\n+\t~DebayerEGL();\n+\n+\t/*\n+\t * Setup the Debayer object according to the passed in parameters.\n+\t * Return 0 on success, a negative errno value on failure\n+\t * (unsupported parameters).\n+\t */\n+\tint configure(const StreamConfiguration &inputCfg,\n+\t\t const std::vector> &outputCfgs,\n+\t\t bool ccmEnabled);\n+\n+\t/*\n+\t * Get width and height at which the bayer-pattern repeats.\n+\t * Return pattern-size or an empty Size for an unsupported inputFormat.\n+\t */\n+\tSize patternSize(PixelFormat inputFormat);\n+\n+\tstd::vector formats(PixelFormat input);\n+\tstd::tuple strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n+\n+\tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params);\n+\n+\t/**\n+\t * \\brief Get the file descriptor for the statistics.\n+\t *\n+\t * \\return the file descriptor pointing to the statistics.\n+\t */\n+\tconst SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n+\n+\t/**\n+\t * \\brief Get the output frame size.\n+\t *\n+\t * \\return The output frame size.\n+\t */\n+\tunsigned int frameSize() { return outputConfig_.frameSize; }\n+\n+\tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n+\n+private:\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tint setupStandardBayerOrder(BayerFormat::Order order);\n+\tvoid pushEnv(std::vector &shaderEnv, const char *str);\n+\tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n+\tint initEGLContext();\n+\tint generateTextures();\n+\tint compileShaderProgram(GLuint &shaderId, GLenum shaderType,\n+\t\t\t\t unsigned char *shaderData, int shaderDataLen,\n+\t\t\t\t std::vector shaderEnv);\n+\tint linkShaderProgram(void);\n+\tint getShaderVariableLocations();\n+\tvoid setShaderVariableValues(void);\n+\tvoid configureTexture(GLuint &texture);\n+\tvoid debayerGPU(MappedFrameBuffer &in, MappedFrameBuffer &out, DebayerParams ¶ms);\n+\n+\t// Shader program identifiers\n+\tGLuint vertexShaderId_;\n+\tGLuint fragmentShaderId_;\n+\tGLuint programId_;\n+\tenum {\n+\t\tBAYER_INPUT_INDEX = 0,\n+\t\tBAYER_OUTPUT_INDEX,\n+\t\tBAYER_BUF_NUM,\n+\t};\n+\n+\t// Pointer to object representing input texture\n+\teGLImage *eglImageBayerIn_;\n+\n+\teGLImage *eglImageRedLookup_;\n+\teGLImage *eglImageGreenLookup_;\n+\teGLImage *eglImageBlueLookup_;\n+\n+\t// Shader parameters\n+\tfloat firstRed_x_;\n+\tfloat firstRed_y_;\n+\tGLint attributeVertex_;\n+\tGLint attributeTexture_;\n+\tGLint textureUniformStep_;\n+\tGLint textureUniformSize_;\n+\tGLint textureUniformStrideFactor_;\n+\tGLint textureUniformBayerFirstRed_;\n+\tGLint textureUniformProjMatrix_;\n+\n+\tGLint textureUniformBayerDataIn_;\n+\tGLint textureUniformRedLookupDataIn_;\n+\tGLint textureUniformGreenLookupDataIn_;\n+\tGLint textureUniformBlueLookupDataIn_;\n+\n+\tRectangle window_;\n+\tstd::unique_ptr stats_;\n+\teGL egl_;\n+\tGBM gbmSurface_;\n+\tuint32_t width_;\n+\tuint32_t height_;\n+\tbool ccmEnabled_;\n+\n+\tGLfloat vcoordinates[DEBAYER_OPENGL_COORDS][2] = {\n+\t\t{ -1.0f, -1.0f },\n+\t\t{ -1.0f, +1.0f },\n+\t\t{ +1.0f, +1.0f },\n+\t\t{ +1.0f, -1.0f },\n+\t};\n+\n+\tGLfloat tcoordinates[DEBAYER_OPENGL_COORDS][2] = {\n+\t\t{ 0.0f, 1.0f },\n+\t\t{ 0.0f, 0.0f },\n+\t\t{ 1.0f, 0.0f },\n+\t\t{ 1.0f, 1.0f },\n+\t};\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\nindex 59fa5f02..c61ac7d5 100644\n--- a/src/libcamera/software_isp/meson.build\n+++ b/src/libcamera/software_isp/meson.build\n@@ -2,6 +2,7 @@\n \n softisp_enabled = pipelines.contains('simple')\n summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n+summary({'SoftISP GPU acceleration' : gles_headless_enabled}, section : 'Configuration')\n \n if not softisp_enabled\n subdir_done()\n@@ -14,3 +15,10 @@ libcamera_internal_sources += files([\n 'software_isp.cpp',\n 'swstats_cpu.cpp',\n ])\n+\n+if softisp_enabled and gles_headless_enabled\n+ config_h.set('HAVE_DEBAYER_EGL', 1)\n+ libcamera_internal_sources += files([\n+ 'debayer_egl.cpp',\n+ ])\n+endif\n","prefixes":["23/35"]}