{"id":23490,"url":"https://patchwork.libcamera.org/api/1.1/patches/23490/?format=json","web_url":"https://patchwork.libcamera.org/patch/23490/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250606164156.1442682-10-barnabas.pocze@ideasonboard.com>","date":"2025-06-06T16:41:42","name":"[RFC,v1,09/23] libcamera: ipa_data_serializer: Support `MetadataListPlan`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c7e4514bf80ad8d2635bf1dbe9bb2a0a4f8f9de3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23490/mbox/","series":[{"id":5210,"url":"https://patchwork.libcamera.org/api/1.1/series/5210/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5210","date":"2025-06-06T16:41:33","name":"libcamera: Add `MetadataList`","version":1,"mbox":"https://patchwork.libcamera.org/series/5210/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23490/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23490/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A221C3328\n\tfor ;\n\tFri, 6 Jun 2025 16:42:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C572A68DC5;\n\tFri, 6 Jun 2025 18:42:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BFD368DB3\n\tfor ;\n\tFri, 6 Jun 2025 18:42:17 +0200 (CEST)","from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC5BA6DC\n\tfor ;\n\tFri, 6 Jun 2025 18:42:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pCXhTnsI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228133;\n\tbh=NBWnkHiQNaNt4gPUtAlgyBGwTlS7OK0WUY5YX86mWYs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pCXhTnsIUHPy8I2vV9kKNO539FP+w51WVOJxHpg40egrIfA3JBF4ouJ1iqhNPWFPs\n\t+Wjvc3pDHvvTpEQ8lXHtmeJuXCEeS9eyERZyecRWuEgEoHo23pbgou9Z0dd9YLZ7Lu\n\tUiatgMDHv2oISdtqxaeE2NdKjSfLqovvYdwwHNy8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 09/23] libcamera: ipa_data_serializer: Support\n\t`MetadataListPlan`","Date":"Fri, 6 Jun 2025 18:41:42 +0200","Message-ID":"<20250606164156.1442682-10-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","References":"<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Define the type in `core.mojom` with external (de)serialization, and\nadd the necessary `IPADataSerializer` template specialization.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/ipa/core.mojom | 1 +\n src/libcamera/ipa_data_serializer.cpp | 84 +++++++++++++++++++\n .../core_ipa_interface.h.tmpl | 1 +\n 3 files changed, 86 insertions(+)","diff":"diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\nindex bce797245..754e4065c 100644\n--- a/include/libcamera/ipa/core.mojom\n+++ b/include/libcamera/ipa/core.mojom\n@@ -83,6 +83,7 @@ module libcamera;\n [skipSerdes, skipHeader] struct ControlInfoMap {};\n [skipSerdes, skipHeader] struct ControlList {};\n [skipSerdes, skipHeader] struct SharedFD {};\n+[skipSerdes, skipHeader] struct MetadataListPlan {};\n \n [skipHeader] struct Point {\n \tint32 x;\ndiff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp\nindex 0537f785b..4646f4aa9 100644\n--- a/src/libcamera/ipa_data_serializer.cpp\n+++ b/src/libcamera/ipa_data_serializer.cpp\n@@ -11,6 +11,8 @@\n \n #include \n \n+#include \n+\n #include \"libcamera/internal/byte_stream_buffer.h\"\n \n /**\n@@ -620,6 +622,88 @@ IPADataSerializer::deserialize(const std::vector &d\n \treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n }\n \n+template<>\n+std::tuple, std::vector>\n+IPADataSerializer::serialize([[maybe_unused]] const MetadataListPlan &data,\n+\t\t\t\t\t [[maybe_unused]] ControlSerializer *cs)\n+{\n+\tstd::vector dataVec;\n+\n+\tappendPOD(dataVec, data.size());\n+\n+\tfor (auto &&[tag, e] : data) {\n+\t\tappendPOD(dataVec, tag);\n+\t\tappendPOD(dataVec, e.size);\n+\t\tappendPOD(dataVec, e.alignment);\n+\t\tappendPOD(dataVec, e.type);\n+\t\tappendPOD(dataVec, e.isArray);\n+\t}\n+\n+\treturn { dataVec, {} };\n+}\n+\n+template<>\n+MetadataListPlan\n+IPADataSerializer::deserialize([[maybe_unused]] std::vector::const_iterator dataBegin,\n+\t\t\t\t\t\t [[maybe_unused]] std::vector::const_iterator dataEnd,\n+\t\t\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsBegin,\n+\t\t\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsEnd,\n+\t\t\t\t\t\t [[maybe_unused]] ControlSerializer *cs)\n+{\n+\tMetadataListPlan ret;\n+\tstd::size_t offset = 0;\n+\n+\tauto count = readPOD(dataBegin, 0, dataEnd);\n+\toffset += sizeof(count);\n+\n+\twhile (count--) {\n+\t\tauto tag = readPOD(dataBegin, offset, dataEnd);\n+\t\toffset += sizeof(tag);\n+\n+\t\tauto size = readPOD(dataBegin, offset, dataEnd);\n+\t\toffset += sizeof(size);\n+\n+\t\tauto alignment = readPOD(dataBegin, offset, dataEnd);\n+\t\toffset += sizeof(alignment);\n+\n+\t\tauto type = readPOD(dataBegin, offset, dataEnd);\n+\t\toffset += sizeof(type);\n+\n+\t\tauto isArray = readPOD(dataBegin, offset, dataEnd);\n+\t\toffset += sizeof(isArray);\n+\n+\t\tret.add(tag, size, 1, alignment, static_cast(type), isArray);\n+\t}\n+\n+\treturn ret;\n+}\n+\n+template<>\n+MetadataListPlan\n+IPADataSerializer::deserialize(std::vector::const_iterator dataBegin,\n+\t\t\t\t\t\t std::vector::const_iterator dataEnd,\n+\t\t\t\t\t\t ControlSerializer *cs)\n+{\n+\treturn deserialize(dataBegin, dataEnd, {}, {}, cs);\n+}\n+\n+template<>\n+MetadataListPlan\n+IPADataSerializer::deserialize(const std::vector &data,\n+\t\t\t\t\t\t ControlSerializer *cs)\n+{\n+\treturn deserialize(data.cbegin(), data.end(), cs);\n+}\n+\n+template<>\n+MetadataListPlan\n+IPADataSerializer::deserialize(const std::vector &data,\n+\t\t\t\t\t\t const std::vector &fds,\n+\t\t\t\t\t\t ControlSerializer *cs)\n+{\n+\treturn deserialize(data.cbegin(), data.end(), fds.cbegin(), fds.end(), cs);\n+}\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace libcamera */\ndiff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\nindex 3942e5708..b3774cd64 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n@@ -21,6 +21,7 @@\n #include \n #include \n #include \n+#include \n \n #include \n \n","prefixes":["RFC","v1","09/23"]}